Re: [Wireshark-dev] Master build broken for me (packet-http2.c)

2018-09-28 Thread Anders Broman
Hi, I think a patch to that effect has been committed. Regards Anders Den fre 28 sep. 2018 17:48Martin Mathieson via Wireshark-dev < wireshark-dev@wireshark.org> skrev: > I am getting this build error: > > home/martin/wireshark/epan/dissectors/packet-http2.c: In function > ‘http2_get_stream_id’:

Re: [Wireshark-dev] Compile error: no member named 'current_stream_id' in 'http2_session_t'

2018-09-28 Thread Graham Bloice
On Fri, 28 Sep 2018 at 16:45, Bruno Rijsman wrote: > I found the solution already: > > brew install nghttp2 > > fixes it > > (It causes HAVE_NGHTTP2 to be set, which adds current_stream_id to > http2_session_t) > > The code should probably still be fixed to avoid a compile error when > NGHTTP2

[Wireshark-dev] Master build broken for me (packet-http2.c)

2018-09-28 Thread Martin Mathieson via Wireshark-dev
I am getting this build error: home/martin/wireshark/epan/dissectors/packet-http2.c: In function ‘http2_get_stream_id’: /home/martin/wireshark/epan/dissectors/packet-http2.c:1124:21: error: ‘http2_session_t’ has no member named ‘current_stream_id’ return h2session->current_stream_id;

Re: [Wireshark-dev] Compile error: no member named 'current_stream_id' in 'http2_session_t'

2018-09-28 Thread Bruno Rijsman
I found the solution already: brew install nghttp2 fixes it (It causes HAVE_NGHTTP2 to be set, which adds current_stream_id to http2_session_t) The code should probably still be fixed to avoid a compile error when NGHTTP2 is not installed > On Sep 27, 2018, at 10:21 AM, Bruno Rijsman

[Wireshark-dev] Compile error: no member named 'current_stream_id' in 'http2_session_t'

2018-09-28 Thread Bruno Rijsman
Any suggestions on how to avoid the following compiler error? [ 30%] Building C object epan/dissectors/CMakeFiles/dissectors.dir/packet-hsrp.c.o [ 30%] Building C object epan/dissectors/CMakeFiles/dissectors.dir/packet-http.c.o [ 30%] Building C object

Re: [Wireshark-dev] [Wireshark-commits] master 7458f40: Diameter: add a bunch more AVPs from RFC 5777.

2018-09-28 Thread Jeff Morriss
Hi folks, Now that the Diameter XML is passing tools/validate-diameter-xml.sh again, could/should we add this verification check to the Petri dish and buildbot? I had added it to pre-commit previously but it passes silently if the user does not have `xmllint` installed. Regards, -Jeff On Fri,

Re: [Wireshark-dev] Switch to C++11 or C++14

2018-09-28 Thread Anders Broman
-Original Message- From: Wireshark-dev On Behalf Of Luke Mewburn Sent: den 28 september 2018 02:45 To: Michał Łabędzki Cc: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Switch to C++11 or C++14 On 18-06-02 11:26, Michał Łabędzki wrote: | C++11 seems to be