Re: [Wireshark-dev] Petri Dish Buildbot failure

2019-08-14 Thread Dario Lombardo
Moreover, be sure your code compiles on the master. Changes are expected to run on top of it. Backport to older versions happen for bugfixes only. Since it looks to me this is not your case it is basically pointless to test it on top of stable versions. On Wed, Aug 14, 2019 at 6:26 PM Graham

Re: [Wireshark-dev] Petri Dish Buildbot failure

2019-08-14 Thread Graham Bloice
On Wed, 14 Aug 2019 at 17:18, Crawford, Anthony R < anthony.r.crawf...@charter.com> wrote: > Hi everyone, > > This week was the first time I’ve submitted code to the Wireshark project. > My first submission was for packet-mpeg-dsmcc.c. ( > https://code.wireshark.org/review/34258) > > I built and

[Wireshark-dev] Petri Dish Buildbot failure

2019-08-14 Thread Crawford, Anthony R
Hi everyone, This week was the first time I've submitted code to the Wireshark project. My first submission was for packet-mpeg-dsmcc.c. (https://code.wireshark.org/review/34258) I built and run both 2.6.10 and 3.0.3 versions of Wireshark successfully on my Ubuntu 16.04 VM. I would like to

Re: [Wireshark-dev] Field with flags dissected

2019-08-14 Thread Crawford, Anthony R
Thanks this was the elegant solution: proto_tree_add_bitmask_with_flags(sub_tree, tvb, offset, msg_id, ett_dsmcc_message_id, bf_message_id, ENC_NA, BMT_NO_APPEND); AC From: Wireshark-dev On Behalf Of Alexis La Goutte Sent: Wednesday, August 14, 2019 2:32 AM To: Developer support list for

Re: [Wireshark-dev] Field with flags dissected

2019-08-14 Thread Alexis La Goutte
Hi Look proto_tree_add_bitmask_with_flags and there is a flag for don't append the top Cheers On Sat, Aug 10, 2019 at 12:48 AM Crawford, Anthony R < anthony.r.crawf...@charter.com> wrote: > Hi all, > > I need some help dissecting a field with its flags. I am trying to present > the dissection