Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Guy Harris
On Mar 19, 2020, at 11:38 AM, Guy Harris wrote: > In addition, we tend to use src_, rather than s_, as a prefix for "source", > and "dst_" or "dest" as a prefix for "destination", so I posted a change to > rename s_addr and d_addr to src_addr and dst_addr: > > https://code.wireshark.org/

Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Guy Harris
On Mar 19, 2020, at 7:40 AM, Gisle Vanem wrote: > I'm surprised no one has come across this compile > error yet: > epan/dissectors/packet-f5ethtrailer.c(482): error C2143: syntax error: > missing ';' before '.' > epan/dissectors/packet-f5ethtrailer.c(485): error C2224: left of '.S_addr' > must

Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Jason Cohen
Gisle, Do you have the steps you used to setup your build environment, and then the steps to build Wireshark? Unless we're able to reproduce it, there may be little we can do. It certainly hasn't been something I've seen either. Jason On Thu, Mar 19, 2020 at 12:34 PM Gisle Vanem wrote: > Mayn

Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Maynard, Chris via Wireshark-dev
> -Original Message- > From: Wireshark-dev On Behalf > Of Gisle Vanem > Sent: Thursday, March 19, 2020 1:33 PM > To: wireshark-dev@wireshark.org > Subject: Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c' > > Maynard, Chris wrote: > > > Which specific release of VS2019 are you runnin

Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Graham Bloice
On Thu, 19 Mar 2020 at 17:34, Gisle Vanem wrote: > Maynard, Chris wrote: > > > Which specific release of VS2019 are you running? This is a bit of a > stretch, but *possibly* your version could use an update? > > I have the latest AFAIK I ran vs_installer last week. > > From 'cl /?': Version 1

Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Gisle Vanem
Maynard, Chris wrote: Which specific release of VS2019 are you running? This is a bit of a stretch, but *possibly* your version could use an update? I have the latest AFAIK I ran vs_installer last week. From 'cl /?': Version 19.24.28319 for x86 From 'vswhere': VisualStudio.16.Release/16.4

Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Graham Bloice
On Thu, 19 Mar 2020 at 14:41, Gisle Vanem wrote: > BTW. > note the time-stamp on the 'a' file. How come it > gets updated as soon as I do a 'git pull'? > From a 'git log packet-f5ethtrailer.c', the last > change was 19 days ago. > > See https://git.wiki.kernel.org/index.php/GitFaq#Why_isn.27t_Gi

Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Maynard, Chris via Wireshark-dev
> -Original Message- > From: Wireshark-dev On Behalf > Of Gisle Vanem > Sent: Thursday, March 19, 2020 10:41 AM > To: wireshark-dev > Subject: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c' > > I'm surprised no one has come across this compile error yet: >epan/dissectors/packet-f5

[Wireshark-dev] Problem in 'packet-f5ethtrailer.c'

2020-03-19 Thread Gisle Vanem
I'm surprised no one has come across this compile error yet: epan/dissectors/packet-f5ethtrailer.c(482): error C2143: syntax error: missing ';' before '.' epan/dissectors/packet-f5ethtrailer.c(485): error C2224: left of '.S_addr' must have struct/union type epan/dissectors/packet-f5ethtrai

Re: [Wireshark-dev] Build without LUA fails

2020-03-19 Thread Pascal Quantin
Le jeu. 19 mars 2020 à 08:54, Anders Broman a écrit : > > > > > *From:* Pascal Quantin > *Sent:* den 17 mars 2020 10:13 > *To:* Developer support list for Wireshark > *Cc:* Anders Broman > *Subject:* Re: [Wireshark-dev] Build without LUA fails > > > > Hi Anders, > > > > Le mar. 17 mars 2020 à

Re: [Wireshark-dev] Build without LUA fails

2020-03-19 Thread Anders Broman via Wireshark-dev
From: Pascal Quantin Sent: den 17 mars 2020 10:13 To: Developer support list for Wireshark Cc: Anders Broman Subject: Re: [Wireshark-dev] Build without LUA fails Hi Anders, Le mar. 17 mars 2020 à 10:02, Anders Broman via Wireshark-dev mailto:wireshark-dev@wireshark.org> > a écrit