Re: [Wireshark-dev] Gerrit commit missing in Gitlab

2021-02-09 Thread Guy Harris
On Feb 9, 2021, at 4:57 PM, Guy Harris wrote: > "Doesn't exist" as in "immediately tells you no such commit" or as in "takes > a long time and eventually gives you a 500 error"? I get the latter; > presumably that's "500 Internal Server Error". > > The commit *is* in repositories I've cloned

Re: [Wireshark-dev] Gerrit commit missing in Gitlab

2021-02-09 Thread Guy Harris
On Feb 9, 2021, at 3:26 PM, chuck c wrote: > 2eb7b05b - Convert most UDP dissectors to use "auto" preferences. > > Exists in Gerrit: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eb7b05b8c9c6408268f0d1e81f0a18a02610f1c > > Links to it in Gitlab on these pages: >

Re: [Wireshark-dev] Procedure to solve/close issues in Gitlab

2021-02-09 Thread Jirka Novak
Hi Pascal, > Le mar. 9 févr. 2021 à 12:51, Jirka Novak > a écrit : > > Hi, > >   what is proposed procedure to solve and close issues in Gitlab? > >   During conversion to gitlab all bugzilla issues were created as > issues. I reviewed many voice

Re: [Wireshark-dev] Procedure to solve/close issues in Gitlab

2021-02-09 Thread Pascal Quantin
Hi Jirka, Le mar. 9 févr. 2021 à 12:51, Jirka Novak a écrit : > Hi, > > what is proposed procedure to solve and close issues in Gitlab? > > During conversion to gitlab all bugzilla issues were created as > issues. I reviewed many voice related issues, made solutions (e.g. > patches) for

[Wireshark-dev] Procedure to solve/close issues in Gitlab

2021-02-09 Thread Jirka Novak
Hi, what is proposed procedure to solve and close issues in Gitlab? During conversion to gitlab all bugzilla issues were created as issues. I reviewed many voice related issues, made solutions (e.g. patches) for them and updated issues, but they are still open even it makes no sense anymore.

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

2021-02-09 Thread Jirka Novak
Hi, > > Change calls to open() to call ws_open(), instead, so that, on > Windows, they can handle UTF-8 pathnames (by turning them into > UTF-16 pathnames and passing them to routines that take UTF-16 > pathnames, rather than using various code page encodings for strings). > >

[Wireshark-dev] pcapng decoding error when preamble is shortened

2021-02-09 Thread Timmy Brolin
Hi, It seems Wireshark fails to decode captured packets with shortened preamble? Normally Ethernet packets have a preamble and SFD like this: 55D5 But during transmission over Ethernet, sometimes the preamble arrives slightly shorter at the receiving end. Some bytes, or even half a

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

2021-02-09 Thread Jirka Novak
Hi, > > Also use ws_close() instead of close().  (The ws_ calls, on > Windows, also call the Visual Studio C library routines that > implement UN*X-style APIs, with an underscore preceding the UN*X API > name.) > > Thank you for explanation and I understand the reasons, but I

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

2021-02-09 Thread Pascal Quantin
Hi Jirka, Le mar. 9 févr. 2021 à 09:13, Jirka Novak a écrit : > Hi, > > >> I commited patch and pipeline failed because: > >> > >> ... > >> FAILED: ui/qt/CMakeFiles/checkAPI_ui-qt > >> ... > >> Error: Found prohibited APIs in utils/rtp_audio_silence_generator.cpp: > open > >> Error: Found

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

2021-02-09 Thread Jirka Novak
Hi, >> I commited patch and pipeline failed because: >> >> ... >> FAILED: ui/qt/CMakeFiles/checkAPI_ui-qt >> ... >> Error: Found prohibited APIs in utils/rtp_audio_silence_generator.cpp: open >> Error: Found prohibited APIs in utils/rtp_audio_routing_filter.cpp: open >> >> but message gives me

Re: [Wireshark-dev] What mean "Error: Found prohibited APIs in ..." error during build?

2021-02-09 Thread Guy Harris
On Feb 8, 2021, at 11:57 PM, Jirka Novak wrote: > I commited patch and pipeline failed because: > > ... > FAILED: ui/qt/CMakeFiles/checkAPI_ui-qt > ... > Error: Found prohibited APIs in utils/rtp_audio_silence_generator.cpp: open > Error: Found prohibited APIs in