Re: [Wireshark-dev] Calling a dissector: Type for data parameter

Hi, Yes the method is fragile. At the time of development I think it was proposed to pass a struct containing a string and the void pointer where the string could be used as a identifier. But that was voted down. Regards Anders Den lör 29 maj 2021 09:26Guy Harris skrev: > On May 29, 2021, at

Re: [Wireshark-dev] Calling a dissector: Type for data parameter

On May 29, 2021, at 12:12 AM, Anders Broman wrote: > Shouldn't the caller be calling with the right data type or NULL? So a bug in > the MQTT disector? How can the MQTT dissector determine what the right data type *is* - especially given that the dissectors aren't wired in, there's a UAT

Re: [Wireshark-dev] Calling a dissector: Type for data parameter

Makes sense for me. I will change the MQTT dissector to call call_dissector_with_data() only for sparkplug payload. > Am 29.05.2021 um 09:12 schrieb Anders Broman >: > > Hi, > Shouldn't the caller be calling with the right data type or NULL? So a bug in > the MQTT

Re: [Wireshark-dev] Calling a dissector: Type for data parameter

Hi, Shouldn't the caller be calling with the right data type or NULL? So a bug in the MQTT disector? Regards Anders Den lör 29 maj 2021 09:07Uli Heilmeier skrev: > With MR 2706 [1] the MQTT dissector calls now subdissectors with > call_dissector_with_data() [2]. Previously this was

[Wireshark-dev] Calling a dissector: Type for data parameter

With MR 2706 [1] the MQTT dissector calls now subdissectors with call_dissector_with_data() [2]. Previously this was call_dissector(). With this change the JSON dissector crashes WS with a memory access segfault (while using MQTT decode topic as option). This is because for JSON we expect