Re: [Wireshark-dev] Replacing wmem_packet_scope() with pinfo->pool?

2021-07-21 Thread Pascal Quantin
Hi Moshe, Le mer. 21 juil. 2021 à 17:56, Moshe Kaplan a écrit : > Coverity is complaining that some of the allocations made with pinfo -> > pool are leaking. Is it possible that the pinfo->pool based allocations are > not always cleaned up? > > As an example, CoverityID 1487512 complains about

Re: [Wireshark-dev] Replacing wmem_packet_scope() with pinfo->pool?

2021-07-21 Thread Moshe Kaplan
Coverity is complaining that some of the allocations made with pinfo -> pool are leaking. Is it possible that the pinfo->pool based allocations are not always cleaned up? As an example, CoverityID 1487512 complains about packet-tcp.c's calls to port_with_resolution_to_str leaking:

Re: [Wireshark-dev] Replacing wmem_packet_scope() with pinfo->pool?

2021-07-21 Thread Evan Huus
FYI this migration has now begun. Going forward, please use pinfo->pool instead of wmem_packet_scope() in new code when possible. And if anybody has some time, there are lots of existing dissectors left to convert. I expect most of them to be pretty straightforward, just adding pinfo to a few more