Re: [Wireshark-dev] Some items with apparently out-of-range value_string values?

2023-02-12 Thread John Thacker
The bittorrent one is fine. The message type field in a packet with the standard protocol is a single byte. There's an Azureus dialect that clients can switch to if they both speak it, and it has some extra message types specified with string names only. The dissector uses the message type field

[Wireshark-dev] Some items with apparently out-of-range value_string values?

2023-02-12 Thread Martin Mathieson via Wireshark-dev
Hi, I have added another check to CHECK_HF_FILTER in proto.c (extra checks that only get done in the 'CLANG + Code checks' pipeline build) to check for values in an item's value_string that could not be represented in the item's type (e.g. a value of > 255 for FT_UINT8). I can eventually look