Re: [Wireshark-dev] add a BASE_DEFAULT_VALS

2023-08-16 Thread Jaap Keuter
Hi, Use range_string rather than value_string. Jaap > On 14 Aug 2023, at 17:22, John Dill wrote: > > I've recently been doing a lot of enums that have multiple illegal values, > and the illegal value shouldn't be displayed as "Unknown" as it's hard coded > in proto.c (in 3.6.x).

Re: [Wireshark-dev] Timestamp from icmp data is incorrect in Wireshark v4.0.7-0-g0ad1823cc090

2023-08-16 Thread John Sullivan
Haha! Yes. The problem is triggered by the specific value you have: 64dad964 Note that the first and fourth bytes are the same, and the second and third bytes are almost the same. That value is on the wire here in little-endian order. The problem being both orders are possible and wireshark

Re: [Wireshark-dev] Timestamp from icmp data is incorrect in Wireshark v4.0.7-0-g0ad1823cc090

2023-08-16 Thread chuck c
That timestamp (64dad964) starts and end with a 64 byte so it passes the check in: https://gitlab.com/wireshark/wireshark/-/blob/master/epan/dissectors/packet-icmp.c#L1741 Please open an issue on the Wireshark Gitlab issues page ( https://gitlab.com/wireshark/wireshark/-/issues/) including the

[Wireshark-dev] Timestamp from icmp data is incorrect in Wireshark v4.0.7-0-g0ad1823cc090

2023-08-16 Thread Stefan Kleedehn
Hello all, I have attached a pcap with 6 icmp echo requests. In frame 5 the icmp.data_time is wrong. It looks to me that the order of the hex value of the icmp.data_time field in frame 5, is interpreted incorrectly. For the other values it looks fine. Many greetings, Stefan