Re: [Wireshark-dev] [Wireshark-commits] rev 47724: /trunk/ /trunk/: print.c

2013-02-17 Thread Bill Meier
On 2/17/2013 9:18 PM, Guy Harris wrote: On Feb 17, 2013, at 4:52 PM, wme...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=47724 User: wmeier Date: 2013/02/17 04:52 PM Log: Implement proto_tree_write_fields without using ep_strbufs. - Fixes

Re: [Wireshark-dev] [Wireshark-commits] rev 47629: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bitcoin.c

2013-02-11 Thread Bill Meier
On 2/11/2013 8:23 AM, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=47629 User: eapache Date: 2013/02/11 05:23 AM Log: Add an if (tree) check to prevent a very-long-but-not-infinite loop, since without a tree the proto_tree_add_item calls

Re: [Wireshark-dev] Dissector for OID:1.2.826.0.1249.58.1.0 not implemented. Contact Wireshark developers if you want this supported

2013-02-10 Thread Bill Meier
On 2/10/2013 7:37 AM, Rajinish Kumar wrote: Hello, am facing the below issue for a pcap trace captured from Ericsson node Dissector for OID:1.2.826.0.1249.58.1.0 not implemented. Contact Wireshark developers if you want this supported Please file an enhancement request at

Re: [Wireshark-dev] [Wireshark-commits] rev 47326: / /trunk/tools/: checkhf-v2.pl

2013-01-31 Thread Bill Meier
On 1/28/2013 3:31 PM, Evan Huus wrote: Tangentially, CppCheck [1] has support for custom checks using plugins. I've never had time to investigate properly, but I suspect that implementing the three check scripts (checkhf, checkAPIs, checkfiltername) as CppCheck plugins would be a major win,

[Wireshark-dev] A very minor Q re checkAPIs 'name for hf... has trailing space ...' error checking

2013-01-30 Thread Bill Meier
I've been doing a small update to checkAPIs.pl. Among other things: I changed the code to remove comments from the source code string before calling check_hf_entries() since the check doesn't detect an hf... entry if it contains a comment. I now get: Error: the name for hf_ppi_vector_rot_x

Re: [Wireshark-dev] [Wireshark-commits] rev 47326: / /trunk/tools/: checkhf-v2.pl

2013-01-28 Thread Bill Meier
On 1/28/2013 2:58 PM, wme...@wireshark.org wrote: Log: Re-implemention of checkhf.pl: Main objective: reduce the number of false positives. Normal usage: the same as for checkhf.pl. For now: named checkhf-v2.pl I've just committed a re-implementation of checkhf.pl and named it

Re: [Wireshark-dev] [Wireshark-commits] rev 47326: / /trunk/tools/: checkhf-v2.pl

2013-01-28 Thread Bill Meier
On 1/28/2013 3:31 PM, Evan Huus wrote: Tangentially, CppCheck [1] has support for custom checks using plugins. I've never had time to investigate properly, but I suspect that implementing the three check scripts (checkhf, checkAPIs, checkfiltername) as CppCheck plugins would be a major win,

Re: [Wireshark-dev] Deprecate some UI preferences?

2013-01-19 Thread Bill Meier
On 1/18/2013 1:21 PM, Gerald Combs wrote: Does anyone use the packet list and protocol tree selection mode preferences? A long time ago in a GTK+ version far far away you could click-drag in GTK_SELECTION_BROWSE mode and have the selection follow the mouse. Now GTK_SELECTION_BROWSE and

[Wireshark-dev] failure generating layouts.h on Windows 7

2013-01-19 Thread Bill Meier
On my Windows 7 system: After adding the appropriate rule to gtk/makefile.nmake to generate layouts.h gdb-pixbuf-cssource fails when he rule is executed. Doing a test command: $ gdk-pixbuf-csource --raw --name=foo layout_1.png Gives: failed to load layout_1.png: Couldn't recognize the

Re: [Wireshark-dev] failure generating layouts.h on Windows 7

2013-01-19 Thread Bill Meier
On 1/19/2013 1:18 PM, Gerald Combs wrote: On 1/19/13 8:28 AM, Bill Meier wrote: layout_[1-6].png were generated from Inkscape via layouts.svg. They have the proper MIME types set in SVN so they *should* work. Are you using gdk-pixbuf-csource from the wireshark-win32-libs GTK+ bundle? I'm

Re: [Wireshark-dev] the compile problem

2013-01-13 Thread Bill Meier
On 1/13/2013 8:00 PM, Danniel_zeng wrote: Thanks Anders Broman and Guy Harris But How can I see the entire error ? As i don't know what the exact error is . If you look at the prceeding output there should (will) be an error message explicitly saying something like warning ... or error

Re: [Wireshark-dev] Some quick Bugzilla statistics

2013-01-05 Thread Bill Meier
On 1/5/2013 1:30 PM, Evan Huus wrote: I've been playing with some of the bugzilla statistics tools recently, and I am pleased to discover that despite a record number of reported bugs in 2012, we managed to shrink the backlog by 26 bugs. My raw data: Year - Created - Resolved 2012 - 1449 -

[Wireshark-dev] Win32 GTK3 bundle 3.4.0-3.9 not in current 'tag' ?

2012-12-21 Thread Bill Meier
Anders: In SVN #46614 you changed config.nmake GTK3 (for Win32) to switch back to 3.4.0-3.9. r46614 | etxrab | 2012-12-19 01:55:11 -0500 (Wed, 19 Dec 2012) | 1 line Don't yse the new GTK3 bundle, it lacks the tools

Re: [Wireshark-dev] [Wireshark-commits] rev 46606: /trunk/epan/wmem/ /trunk/epan/wmem/: wmem_core.c

2012-12-18 Thread Bill Meier
On 12/18/2012 11:43 PM, Guy Harris wrote: On Dec 18, 2012, at 5:08 PM, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=46606 User: eapache Date: 2012/12/18 05:08 PM Log: Try to fix windows builds - MSVC doesn't like g_assert_not_reached() ?

Re: [Wireshark-dev] [Wireshark-commits] rev 46606: /trunk/epan/wmem/ /trunk/epan/wmem/: wmem_core.c

2012-12-18 Thread Bill Meier
On 12/18/2012 11:48 PM, Bill Meier wrote: On 12/18/2012 11:43 PM, Guy Harris wrote: On Dec 18, 2012, at 5:08 PM, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=46606 User: eapache Date: 2012/12/18 05:08 PM Log: Try to fix windows builds

Re: [Wireshark-dev] Buildbot version number in fuzz-test bugs?

2012-12-07 Thread Bill Meier
On 12/7/2012 1:05 PM, Gerald Combs wrote: On 12/5/12 1:37 PM, Bill Meier wrote: On 12/5/2012 2:57 PM, Bill Meier wrote: On 12/5/2012 2:32 PM, Evan Huus wrote: In cases like bug 8045 [1], it would have been handy for it to say in the report somewhere which build-bot (version and OS) had found

Re: [Wireshark-dev] [Wireshark-commits] rev 46431: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-afs.c

2012-12-06 Thread Bill Meier
On 12/6/2012 6:19 PM, g...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=46431 User: guy Date: 2012/12/06 03:19 PM Log: Squelch some -Wshadow warnings (inappropriate warnings - they're just names in a prototype declaration - but maybe that's what you

Re: [Wireshark-dev] [Wireshark-commits] rev 46431: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-afs.c

2012-12-06 Thread Bill Meier
On 12/6/2012 6:44 PM, Guy Harris wrote: Hmm. Maybe the test for can I enable -Wshadow should be does the compiler support it *and* does it complain about names in prototype declarations shadowing variables?, not just does the compiler support it? My thoughts, exactly, but left for

Re: [Wireshark-dev] Buildbot version number in fuzz-test bugs?

2012-12-05 Thread Bill Meier
On 12/5/2012 2:32 PM, Evan Huus wrote: In cases like bug 8045 [1], it would have been handy for it to say in the report somewhere which build-bot (version and OS) had found the error... is that reasonably easy to do? Thanks, Evan I agree completely: As I've going through the process of

Re: [Wireshark-dev] Buildbot version number in fuzz-test bugs?

2012-12-05 Thread Bill Meier
On 12/5/2012 2:57 PM, Bill Meier wrote: On 12/5/2012 2:32 PM, Evan Huus wrote: In cases like bug 8045 [1], it would have been handy for it to say in the report somewhere which build-bot (version and OS) had found the error... is that reasonably easy to do? I agree completely: As I've going

Re: [Wireshark-dev] fuzz failures not generating bugs

2012-11-30 Thread Bill Meier
On 11/30/2012 2:05 PM, Gerald Combs wrote: It looks like I should have read the release notes more closely. Fuzz failure reporting uses the bugzilla-submit script, which requires converting to a new status workflow in Bugzilla 4.0 and 4.2:

Re: [Wireshark-dev] fuzz failures not generating bugs

2012-11-30 Thread Bill Meier
On 11/30/2012 4:08 PM, Evan Huus wrote: Would UNCONFIRMED be less confusing than CONFIRMED? I would think so. It's bothered me for a while that we didn't have a way to distinguish between brand new, nobody has looked at it yet bugs and solution identified, but nobody wants to work on it

Re: [Wireshark-dev] Problems in capture_win_ifnames.c

2012-11-23 Thread Bill Meier
On 11/23/2012 8:16 AM, Gisle Vanem wrote: Guy Harris g...@alum.mit.edu wrote: Checked in (with the checks and #defines moved up a little earlier). Thanks. Works fine now. But I'm curious about why this: #if 0 /* XXX: including config.h causes compilation errors; TBD: why */ #include

Re: [Wireshark-dev] TVB Composite packet byte pane problem

2012-11-20 Thread Bill Meier
On 11/20/2012 3:48 AM, Zadik, Maayan wrote: Yes the composite TVB is displayed as single sequence but the composite is in fact several TVBs concatenated together, so when I click on a field that was generated from the second concatenated TVB, it is displays in the byte pane as if it's the base

Re: [Wireshark-dev] TVB Composite packet byte pane problem

2012-11-19 Thread Bill Meier
On 11/19/2012 2:48 PM, Zadik, Maayan wrote: Hi, I’m using TVB composite to assemble some data chunks, using tvb_new_child_real_data. My problem is that every chunk is displayed in the byte pane as if it’s at offset=0 instead of its actual location in the original TVB. Does anybody know how I

[Wireshark-dev] capture_win_ifnames.c compile fails if config.h is included ??

2012-11-19 Thread Bill Meier
The recently added file 'capture_win_ifnames.c' fails to compile if config.h is included. After a bit of poking around, I found that (one or both of) 2 defines in config.h (shown below) cause the problem. (That is: 'capture_win_ifnames.c' compiles OK if the two defines are commented out.

Re: [Wireshark-dev] Appending 2 TVBs in Wireshark 1.8.2

2012-10-29 Thread Bill Meier
On 10/28/2012 12:20 PM, Zadik, Maayan wrote: Hi all, How do I create a single TVB from several data chunks? Is there a way to append two TVBs? I know the composite doesn't work. I tried it. Regards, Maayan Well: you can create your own tvb using tvb_new_real_data() pointing to a buffer

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7922] Buildbot crash output: fuzz-2012-10-27-11126.pcap

2012-10-28 Thread Bill Meier
On 10/28/2012 4:24 PM, bugzilla-dae...@wireshark.org wrote: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7922 Evan Huus eapa...@gmail.com changed: What|Removed |Added

[Wireshark-dev] tcp_dissect_pdus. get reassemble TCP

2012-10-15 Thread Bill Meier
. How are you determining the actual length of the PDU in get_foo_message_len() ? dissect_foo_message() will be handed a tvb of whatever length is returned by get_foo_message_len() (12 Oct, 06:48) Bill Meier Comment: void proto_reg_handoff_dataparse(void

Re: [Wireshark-dev] tcp_dissect_pdus. get reassemble TCP

2012-10-15 Thread Bill Meier
On 10/15/2012 11:05 AM, Bill Meier wrote: Hi Bill, I didn't finish the code, now i'm testing the function tcp_dissect_pdus() to check whether it works. But i try to give specific code in the below comment. besides that I have two questions: 1. I cannot get the len in advance, for the protocol

Re: [Wireshark-dev] [Wireshark-commits] rev 45462: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sctp.c

2012-10-11 Thread Bill Meier
On 10/11/2012 1:27 AM, Guy Harris wrote: Actually, this one: for(sid_number = 1; sid_number = number_of_sids; sid_number++) { proto_tree_add_item(parameter_tree, hf_stream_reset_sid, parameter_tvb, sid_offset, SID_LENGTH, ENC_BIG_ENDIAN); sid_offset += SID_LENGTH; }

[Wireshark-dev] GTK3 vs GTK2: visual differences: frame border

2012-10-05 Thread Bill Meier
While working with a *nix version of GTK3 Wireshark, I noticed that the pull-down menus (File, Edit, etc) were not clearly delineated from the underlying window. IOW: there's no border around the drop-down. To my eye the missing borders make the dropdowns more difficult to read. [ ...

Re: [Wireshark-dev] Compilation failure - privileges.c: In function 'relinquish_special_privs_perm' - ignoring return value of 'setresgid', declared with attribute warn_unused_result [-Werror=unused-r

2012-09-30 Thread Bill Meier
On 9/29/2012 5:49 PM, Evan Huus wrote: On Sat, Sep 29, 2012 at 4:05 PM, Bill Meier wme...@newsguy.com wrote: My inclination: test the return value of the various set*id calls and if fail, do g_error(). Thoughts ? I'd be tempted to make it a g_warning() since Wireshark will *probably* keep

Re: [Wireshark-dev] [Wireshark-commits] rev 45212: /trunk/ui/gtk/ /trunk/ui/gtk/: gui_utils.c

2012-09-29 Thread Bill Meier
On 9/29/2012 11:49 AM, cmayn...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45212 User: cmaynard Date: 2012/09/29 08:49 AM Log: Revert most of r45210. We don't use the return value of GetExitCodeProcess(), but it still needs to be called to get

Re: [Wireshark-dev] [Wireshark-commits] rev 45212: /trunk/ui/gtk/ /trunk/ui/gtk/: gui_utils.c

2012-09-29 Thread Bill Meier
On 9/29/2012 12:02 PM, Bill Meier wrote: On 9/29/2012 11:49 AM, cmayn...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45212 User: cmaynard Date: 2012/09/29 08:49 AM Log: Revert most of r45210. We don't use the return value of GetExitCodeProcess

Re: [Wireshark-dev] Compilation failure - privileges.c: In function 'relinquish_special_privs_perm' - ignoring return value of 'setresgid', declared with attribute warn_unused_result [-Werror=unused-r

2012-09-29 Thread Bill Meier
On 8/21/2012 2:19 AM, Guy Harris wrote: On Aug 20, 2012, at 12:49 PM, Kaul wrote: If it were git, I'm sure I could easily use 'git bisect' and find the issue. As Evan Huus indicated, what you probably need to bisect is compiler updates. :-) The offending routine is probably

Re: [Wireshark-dev] The Wireshark documentation for building on Windows may need some updating

2012-09-23 Thread Bill Meier
On 9/23/2012 5:27 PM, Guy Harris wrote: ... While investigating the issue about win32.mak being not part of VS2012, I think I also read that SDK 8 is smaller because the SDK no longer includes compilers etc and that the compilers needed to be downloaded separately (VS2012EE, etc).

Re: [Wireshark-dev] The Wireshark documentation for building on Windows may need some updating

2012-09-23 Thread Bill Meier
On 9/23/2012 6:20 PM, Guy Harris wrote: On Sep 23, 2012, at 3:11 PM, Bill Meier wme...@newsguy.com wrote: While investigating the issue about win32.mak being not part of VS2012, I think I also read that SDK 8 is smaller because the SDK no longer includes compilers etc

Re: [Wireshark-dev] The Wireshark documentation for building on Windows may need some updating

2012-09-23 Thread Bill Meier
On 9/23/2012 6:56 PM, Bill Meier wrote: On 9/23/2012 6:20 PM, Guy Harris wrote: I *think* both 32bit and 64bit compilers (and SDK ?) are available as part of VS2012 although I can't find the page with the info at the moment; https://www.microsoft.com/visualstudio/eng/products/visual-studio

Re: [Wireshark-dev] [Wireshark-commits] rev 44860: /trunk/ /trunk/asn1/camel/: camel.cnf /trunk/asn1/charging_ase/: packet-charging_ase-template.c /trunk/asn1/cmp/: packet-cmp-template.c /trunk/asn1/c

2012-09-18 Thread Bill Meier
On 9/18/2012 3:35 PM, Jeff Morriss wrote: darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=44860 User: darkjames Date: 2012/09/10 02:40 PM Log: Initial commit to support yet another method of passing data between dissectors. Add new parameter

Re: [Wireshark-dev] Building Wireshark with VS 2012 {Was: [Wireshark-commits] rev 44982: /trunk/ /trunk/: config.nmake]

2012-09-18 Thread Bill Meier
On 9/18/2012 4:18 PM, Maynard, Chris wrote: From http://ask.wireshark.org/questions/14343/setting-development-project-under-visual-studio-2012, you indicated the error was: ws2tcpip.h(531) : error C2373: 'ws_inet_pton' : redefinition; different type modifiers. Could this be because of the

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7729] Full support of RFC2428 in FTP dissector

2012-09-16 Thread Bill Meier
On 9/16/2012 2:26 PM, bugzilla-dae...@wireshark.org wrote: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7729 --- Comment #5 from Alexander Koeppe forma...@online.de 2012-09-16 11:26:18 PDT --- Thank for your comments and hints. I'll go back and work on that to provide a new version.

Re: [Wireshark-dev] Disabling a dissector doesn't seem to quite work.

2012-09-15 Thread Bill Meier
On 9/15/2012 4:35 PM, Evan Huus wrote: The obvious solution for now is to remove the comments that are getting falsely picked up as function definitions, but the better fix is to the make-dissector-reg scripts. Is it valid for there to be two register functions in a file, or could the scripts

[Wireshark-dev] GTK3 libs for Windows version mismatch: svn vs config.nmake ?

2012-09-12 Thread Bill Meier
config.nmake: has GTK_PKG=3.4.2-3.5 as the GTK3 version desired; However: the GTK3 bundles available (32 bit) in svn are: svn tag: [Wireshark-win32-libs] / tags / 2012-05-30 / packages has: gtk+-bundle_3.4.2-2.4_win32ws.zip svn trunk: [Wireshark-win32-libs] / trunk / packages has:

Re: [Wireshark-dev] RFD: Creating subdirectories in epan/dissectors/

2012-08-30 Thread Bill Meier
[Graham Bloice said] Some folks have articulated the drawbacks (to them) of making these changes but I haven't seen any actual advantages listed. Can anyone list them as they see it? +1 ___ Sent via:

Re: [Wireshark-dev] http://anonsvn issues

2012-08-27 Thread Bill Meier
On 8/27/2012 9:29 AM, Jeff Morriss wrote: Hi Gerald, I noticed that looking at a revision by pointing my web browser at http://anonsvn.wireshark.org/viewvc?revision=Xview=revision doesn't look very good today (fonts are big, spacing seems to be off). More troubling is I'm not getting any

Re: [Wireshark-dev] [Wireshark-commits] rev 44576: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-e212.c

2012-08-24 Thread Bill Meier
On 8/18/2012 10:27 PM, mart...@wireshark.org wrote: Found error by adding temp debug to _match_strval_ext_init() - do we ever expect the entries not to be in order? If the effort is taken to use an extended value string, then the value string array entries ought to be in order such that

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7647] Buildbot crash output: randpkt-2012-08-16-9693.pcap

2012-08-17 Thread Bill Meier
On 8/17/2012 7:59 AM, bugzilla-dae...@wireshark.org wrote: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7647 Michael Mann mman...@netscape.net changed: What|Removed |Added

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7647] Buildbot crash output: randpkt-2012-08-16-9693.pcap

2012-08-17 Thread Bill Meier
A little checking of the buildbot info indicates that the fix was committed after the build started. Build: Timing: StartThu Aug 16 06:23:06 2012 EndThu Aug 16 23:45:08 2012 r44540 was committed @ 6:58 Am (Pacific time). To be specific: It appears that the build was done with SVN

Re: [Wireshark-dev] Bug 7506: Analyze-Apply as Filter and Analyze-Prepare a Filter cause crashes

2012-07-24 Thread Bill Meier
It appears that this bug has existed for a while and has just recently been reported by a user. IOW: maybe accessing the 'Apply as Filter' and 'Prepare a Filter' functionality via the 'Analyze' dropdown isn't used much. So: Given that there's already a lot of choices on the 'Analyze'

Re: [Wireshark-dev] Help needed

2012-07-23 Thread Bill Meier
On 7/23/2012 1:52 AM, Krishnamurthy Mayya wrote: Hi Bill, To answer your questions: a) I am using Centos version - 6.2 (Oracle Virtual Box Environment) b) Yes, i am building unchanged Wireshark SVN code. (*wireshark-1.9.0-SVN-43850, which i have downloaded from the repository*). c) After

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7493] Dissector for the Parrot AR Drone

2012-07-22 Thread Bill Meier
On 7/22/2012 6:15 AM, bugzilla-dae...@wireshark.org wrote: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493 --- Comment #5 from Martin Kaiser wiresh...@kaiser.cx 2012-07-22 03:14:58 PDT --- Hi, some more comments Variables should be declared at the beginning of a function, not

Re: [Wireshark-dev] Help needed

2012-07-22 Thread Bill Meier
On 7/23/2012 12:19 AM, Krishnamurthy Mayya wrote: Hi all, When i am trying to run the wireshark through command prompt, i am getting the following error. Any clue what might have gone wrong? How to correct this??? */home/wireshark-1.9.0-SVN-43850/.libs/lt-wireshark: symbol lookup error:

Re: [Wireshark-dev] Trunk not playing nicely with Ubuntu's overlay scrollbars

2012-07-21 Thread Bill Meier
This is rather bizarre. The problem is revision 43646. I have double-checked by reverting just those two lines on my local latest trunk, and the bisection is accurate - somehow revision 43646 is the problem. I see that the code it calls does some things with the packet display, but the crash is

Re: [Wireshark-dev] [Wireshark-commits] rev 43890: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sprt.c packet-v150fw.c

2012-07-21 Thread Bill Meier
I'm not exactly sure what's up with the v150fw dissector, since it defines a heuristic which is never used and registers in no tables. The comments indicate it's carried over rtp, but rtp doesn't have a heuristic table. FWIW: packet-rtp.c does register the v150fw dissector to the rtp

Re: [Wireshark-dev] GTK3 problems

2012-07-16 Thread Bill Meier
On 7/16/2012 2:18 PM, Stephen Fisher wrote: On Sun, 15 Jul 2012 08:56:28 -0600 Joerg Mayer wrote I opened https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7377 a while ago but except for one person who added a me too nothing happend. This problem basically makes the GTK3 version

Re: [Wireshark-dev] Wireshark with QT

2012-07-07 Thread Bill Meier
On 7/7/2012 2:06 PM, Martin Kaiser wrote: Hi, Thus wrote Akos Vandra (axo...@gmail.com): I'm having problems building wireshark with Qt. I'm trying to build on Ubuntu 10.04LTS x64, with QT 4.7.0, qmake 2.01a, latest svn revision at the moment, r43597. I used the following commands to

Re: [Wireshark-dev] Coding convention query

2012-07-06 Thread Bill Meier
On 7/6/2012 10:05 AM, Jeff Morriss wrote: Arun Sharma wrote: Does in coding convention, it Limit lines to 79 characters? I have gone through README.developer but didn't find any such restriction. Even when i see some codes, packet-tcp.c etc, some or most lines does not limit to 79 characters.

Re: [Wireshark-dev] Exposing KRB5 value_strings to other dissectors ...

2012-07-03 Thread Bill Meier
On 7/3/2012 11:22 AM, Stephen Fisher wrote: On Tue, 03 Jul 2012 08:45:46 -0600 Richard Sharpe wrote There are protocols that specify the use of KRB5 specified values. Eg, NegoEx specifies RFC3961 strings. Rather than simply re-entering these values it would be useful to reuse the

Re: [Wireshark-dev] A potential patch for epan/dissectors/packet-smb2.c

2012-06-26 Thread Bill Meier
On 6/26/2012 12:56 AM, Richard Sharpe wrote: Hi folks, I noticed some inconsistencies in the command naming. The following patch fixes those (so that they now match between SMB and SMB2): Index: epan/dissectors/packet-smb2.c ===

Re: [Wireshark-dev] [Wireshark-commits] rev 43497: /trunk/epan/ /trunk/epan/: expert.c

2012-06-26 Thread Bill Meier
On 6/26/2012 3:36 PM, pas...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=43497 User: pascal Date: 2012/06/26 12:36 PM Log: Display expert codes in hexadecimal (less painful for my eyes :)) The real question: Why are the essentially meaningless

Re: [Wireshark-dev] [Wireshark-commits] rev 43497: /trunk/epan/ /trunk/epan/: expert.c

2012-06-26 Thread Bill Meier
On 6/26/2012 6:18 PM, Pascal Quantin wrote: This is due to the now forbidden usage of BASE_NONE with FT_(U)INT* done in r43412. I first used a BASE_CUSTOM to get completely rid of the numeric display but then nice filters like expert.severity == Note were not working anymore :( Thus the tradeoff

Re: [Wireshark-dev] Problem with protocol in udp por 3800

2012-06-20 Thread Bill Meier
On 6/20/2012 9:52 AM, Pedro Fuentes Ortega wrote: . Hello, This is the my first post and do not know if is the right way to question. In the company I work we used two proprietary protocols to communicate, in a private network, diferent equipments. One protocol uses udp port 3500 and the other

Re: [Wireshark-dev] Problem with protocol in udp por 3800

2012-06-20 Thread Bill Meier
On 6/20/2012 10:47 AM, Pedro Fuentes Ortega wrote: Yes, the frames are displayed but but aren't dissected by the dissector. Does 'tshark -G decodes | grep udp\.port' show your dissector as being registered on udp.port 3800 ? If not, then maybe there's something wrong with your code to

Re: [Wireshark-dev] Style question passing boolean parameters

2012-06-20 Thread Bill Meier
On 6/20/2012 1:12 AM, Joerg Mayer wrote: The following commit retriggered an allergic reaction to controlling function behaviour via booleans: if (cf_save_packets(cfile, file_name8-str, filetype, FALSE/*compressed */, FALSE/*discard_comments */, FALSE/* dont_reopen */) != CF_OK) { To

Re: [Wireshark-dev] ui/qt directory installed with gtk version (1.8rc1)

2012-06-14 Thread Bill Meier
On 6/14/2012 10:55 AM, Petr Sumbera wrote: Hi, why do I have installed ui/qt directory with all png files when I built 1.8.rc1 with gtk? Thanks, Petr The ui/qt directory (and contents) is part of the source tarball (I'm assuming you built from the tarball). When you build with gtk,

Re: [Wireshark-dev] Linear search in value_string_ext

2012-06-11 Thread Bill Meier
On 6/11/2012 3:24 PM, Jakub Zawadzki wrote: Hi, Bill recently converted lot of code which were using value_string API to newer value_string_ext API. But the problem is that not all value_string arrays are sorted for faster access. If value_string_ext is used in hfinfo it can be easily found

Re: [Wireshark-dev] [Wireshark-commits] rev 43176: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

2012-06-09 Thread Bill Meier
On 6/9/2012 2:26 PM, Jeff Morriss wrote: The code in epan/proto.c seems to indicate that using BASE_NONE with FT_*INT* types should be OK when there the strings converter is supplied: case FT_UINT32: case FT_UINT64: if (hfinfo-strings == NULL) { /* Require integral types (other than frame

[Wireshark-dev] lua5_1_4_Win64_dll10_lib.zip now needed ??

2012-06-06 Thread Bill Meier
Not really knowing much about this, I do note that there is a lua library named 'lua5_1_4_Win32_dll9_lib.zip' (as well as 'lua5_1_4_Win32_dll6_lib.zip'); config.nmake for win32 specifies: LUA_DIST=5_1_4_Win32_dll6 LUA_DIR=$(WIRESHARK_LIB_DIR)\lua5.1.4 I also note that config.nmake for win64

Re: [Wireshark-dev] Bug #6844: work in progress

2012-06-05 Thread Bill Meier
FYI: I'm in the midst of updating the files associated with bug #6844: packet-ua.c packet-ua3g.c packet-uasip.c packet-noe.c packet-uaudp.c packet-uaudp.h I expect to commit the changes later today Bill ___ Sent

Re: [Wireshark-dev] recent buildbot errors: I'm working on them ....

2012-06-05 Thread Bill Meier
___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Bug in Radius dictionary.3gpp

2012-06-03 Thread Bill Meier
On 6/3/2012 5:12 PM, René Scheibe wrote: Hi, I just noticed when upgrading from 1.2.15 to 1.6.8 that the file dictionary.3gpp now contains an invalid entry. There is a typo (3GGP instead of 3GPP) and the decoding is incorrect too. wireshark: ATTRIBUTE 3GGP-IMEISV 20 octets freeradius:

Re: [Wireshark-dev] SVN HEAD not building

2012-05-26 Thread Bill Meier
On 5/26/2012 7:40 PM, Akos Vandra wrote: On 27 May 2012 01:18, Pascal Quantinpascal.quan...@gmail.com wrote: Le 27 mai 2012 à 01:12, Akos Vandraaxo...@gmail.com a écrit : Sorry, I forgot to mention: I am running ubuntu 10.10, x64 version. On 27 May 2012 01:05, Akos Vandraaxo...@gmail.com

Re: [Wireshark-dev] Stop dissection in get_pdu_len

2012-05-24 Thread Bill Meier
On 5/24/2012 12:02 PM, Jakub Zawadzki wrote: Hi, On Thu, May 24, 2012 at 11:35:34AM -0400, Tobias Weiss wrote: I'm using tcp_dissect_pdus() to reassemble packets in my dissector. One of my functions will calculate the length of the real message based on a header with a fixed length

Re: [Wireshark-dev] Stop dissection in get_pdu_len

2012-05-24 Thread Bill Meier
On 5/24/2012 12:24 PM, Bill Meier wrote: On 5/24/2012 12:02 PM, Jakub Zawadzki wrote: Hi, On Thu, May 24, 2012 at 11:35:34AM -0400, Tobias Weiss wrote: I'm using tcp_dissect_pdus() to reassemble packets in my dissector. One of my functions will calculate the length of the real message based

Re: [Wireshark-dev] [Wireshark-commits] rev 42368: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bfd.c

2012-04-30 Thread Bill Meier
On 4/30/2012 7:08 PM, g...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=42368 User: guy Date: 2012/04/30 04:08 PM Log: No C++-style comments, please; some C compilers reject them. Directory: /trunk/epan/dissectors/ ChangesPathAction

Re: [Wireshark-dev] tcp_dissect_pdus() fixed_len issue

2012-04-26 Thread Bill Meier
On 4/26/2012 8:55 AM, Tobias Weiss wrote: Hi everyone, I'm currently developing a dissector for a quite old TCP protocol. Most of the stuff is straight forward and not a real problem. But right now I'm facing an issue and need some help. In my main dissector function I'm calling

Re: [Wireshark-dev] tools/svnadd

2012-04-26 Thread Bill Meier
Can pcapng files also be given a mime-type of application/vnd.tcpdump.pcap ? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] Wireshark 1.6.x requires GLib 2.10 or later, but the configure script doesn't check for that

2012-04-23 Thread Bill Meier
On 4/23/2012 2:51 PM, Guy Harris wrote: Most of Wireshark 1.6.x uses GLib memory slices only if built with GLib 2.10 or later; it uses memory chunks otherwise. However, MATE unconditionally uses memory slices, which means it fails to build with GLib releases prior to 2.10. The configure

Re: [Wireshark-dev] [Wireshark-commits] rev 42200: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-diameter.c

2012-04-22 Thread Bill Meier
On 4/22/2012 9:36 PM, wme...@wireshark.org wrote: Fixes Bug #7138 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7138) A puzzle: why did the buildbot fuzz-testing only start failing on this on 04/18/2012 since the bug has existed for quite some time ? I now see that

Re: [Wireshark-dev] Bugzilla / SVN commit autolinkification

2012-04-01 Thread Bill Meier
On 4/1/2012 4:46 PM, Gerald Combs wrote: I managed to convince Bugzilla to automatically link SVN revision references in bug comments (e.g. r12345) to the repository viewer at anonsvn.wireshark.org/viewvc. The regex looks for r, rev, and revision: (?:r|rev \#?|revision \#?)\s?\d{1,6}

Re: [Wireshark-dev] Memory corrupted

2012-03-14 Thread Bill Meier
On 3/14/2012 3:52 PM, Akos Vandra wrote: Hi! I'm developing a dissector for a proprrietary protocol. It has been working up until now. Today it started crashing wireshark, with the not very helpful message: 20:48:51 Err Memory corrupted Aborted Can you please help me what could be

[Wireshark-dev] Store selected Wireshark prefs in pcapng capture file ?

2012-03-05 Thread Bill Meier
Would it make any sense to be able to store application specific information in a pcapng file ? E.g., selected Wireshark prefs so that Wireshark can act on same ? This would be useful when a capture file reqires specific dissector preferences to properly dissect the file. Would this fit (at

Re: [Wireshark-dev] MSVC2008EE build broken??

2012-02-29 Thread Bill Meier
On 2/29/2012 9:47 AM, Anders Broman wrote: Sorry my fault, I checked in a change to config.win32 and my default is MSVC10. On Windows I do the following so I don't have to touch config.nmak 1. Set some environment variables set MSVC_VARIANT=MSVC2008 set VERSION_EXTRA=-DEV ... 2. Do

Re: [Wireshark-dev] Bug found

2012-02-25 Thread Bill Meier
On 2/24/2012 9:22 AM, Steven W. Stoner wrote: Hello all, I just installed your version 1.7.0 SVN Rev 39768 from /trunk and started the application. There is an error you have in initial window placement, which is difficult to resolve in Windows 7. The problem is that on a two monitor system,

Re: [Wireshark-dev] Windows buildbots failing

2012-02-19 Thread Bill Meier
On 2/19/2012 10:49 AM, Christopher Maynard wrote: The Windows buildbots are all failing with: Linking tshark.exe link @C:\Users\buildbot\AppData\Local\Temp\nm2AA1.tmp LINK : fatal error LNK1181: cannot open input file 'ui/cli/tap-afpstat.obj' Running nmake -f Makefile.nmake

Re: [Wireshark-dev] [Question]how to add an dissector for 802.11 Action frame in Lua?

2012-02-13 Thread Bill Meier
On 2/13/2012 3:12 PM, Guy Harris wrote: On Feb 12, 2012, at 9:46 PM, 李刚 wrote: I have an Vendor Specific Action and want to add an dissector for it. Usually, an dissector is added by: udp_table = DissectorTable.get(udp.port) udp_table:add(,trivial_proto) But for an Action

Re: [Wireshark-dev] can't compile wireshark

2012-02-12 Thread Bill Meier
On 2/12/2012 2:29 AM, Rafi Lavi wrote: erf.c erf.c(651) : warning C4244: '=' : conversion from 'gint64' to 'int', possible loss of data This compiles w/o a warning using my Windows 2008 compiler to compile the latest SVN (development) Wireshark source. Which version of the Wireshark source

Re: [Wireshark-dev] can't compile wireshark

2012-02-12 Thread Bill Meier
On 2/12/2012 11:27 AM, Bill Meier wrote: On 2/12/2012 2:29 AM, Rafi Lavi wrote: erf.c erf.c(651) : warning C4244: '=' : conversion from 'gint64' to 'int', possible loss of data This compiles w/o a warning using my Windows 2008 compiler to compile the latest SVN (development) Wireshark source

Re: [Wireshark-dev] Meeting minutes from (pre)FOSDEM meeting

2012-02-03 Thread Bill Meier
Jörg: Thanks for the detailed write-up. Bill (See below) On 2/3/2012 10:51 AM, Joerg Mayer wrote: qtshark: - maybe we can attract a seasoned qt-developer to help us getting started with the qtshark design stuff +1 cmake: - on windows + cmake would allow out-of-tree builds on

Re: [Wireshark-dev] Meeting minutes from (pre)FOSDEM meeting

2012-02-03 Thread Bill Meier
On 2/3/2012 11:50 AM, Graham Bloice wrote: cmake: - on windows + cmake would allow out-of-tree builds on Windows + starting with a cygwin/nmake alternative would be an idea as there is no native windows / VisualStudio setup available right now. Meaning: out-of-tree using

[Wireshark-dev] Building Qt Wireshark:: using QMake

2012-02-01 Thread Bill Meier
From doc/README.qt Autotools + QMake is a basket full of crazy that hasn't yet been sorted and folded. (Autotools + Boring Old Make, without using QMake at all, might actually be simpler: +1 ! - Understanding and coping with the details of qmake doesn't particularly appeal to me.

[Wireshark-dev] Qt 5 Implications for Wireshark Qt ?

2012-01-31 Thread Bill Meier
Can someone knowledgeable about QT comment on the implications for Wireshark Qt of the following ? http://labs.qt.nokia.com/wp-content/uploads/2011/05/Qt5.pdf There are statements like the following: Qt 5.0 will be the foundation for a new way of developing applications. While offering all

Re: [Wireshark-dev] Qt 5 Implications for Wireshark Qt ?

2012-01-31 Thread Bill Meier
On 1/31/2012 5:02 PM, Bill Meier wrote: Can someone knowledgeable about QT comment on the implications for Wireshark Qt of the following ? http://labs.qt.nokia.com/wp-content/uploads/2011/05/Qt5.pdf There are statements like the following: Qt 5.0 will be the foundation for a new way

Re: [Wireshark-dev] [Wireshark-commits] rev 40768: /trunk/ /trunk/doc/: README.qt /trunk/ui/qt/: QtShark.pro /trunk/: Makefile.nmake

2012-01-29 Thread Bill Meier
On 1/29/2012 11:37 PM, wme...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=40768 User: wmeier Date: 2012/01/29 08:37 PM Log: Rework Windows Wireshark Qt build configuration a bit: 1. Compile and link with (almost exactly) the same options as used

Re: [Wireshark-dev] [Wireshark-commits] rev 40715: /trunk/ /trunk/ui/gtk/: capture_dlg.c capture_dlg.h capture_if_dlg.c capture_if_dlg.h main.c main.h main_welcome.c main_welcome.h prefs_capture.c pre

2012-01-25 Thread Bill Meier
On 1/25/2012 8:04 AM, tue...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=40715 capture_if_dlg.c: In function ‘store_selected’: capture_if_dlg.c:168:12: warning: variable ‘found’ set but not used [-Wunused-but-set-variable] capture_if_dlg.c: In

Re: [Wireshark-dev] Use of deprecated glib function

2012-01-15 Thread Bill Meier
On 1/15/2012 12:41 PM, Joerg Mayer wrote: Hello, compiling with current glib (2.31.6) dies with: [ 95%] Building C object plugins/mate/CMakeFiles/mate.dir/mate_runtime.c.o cc1: warnings being treated as errors /Users/jmayer/wireshark/svn/plugins/mate/mate_runtime.c: In function

[Wireshark-dev] Windows Wireshark being compiled w/o any optimization ??

2012-01-11 Thread Bill Meier
I was curious about the code being being generated by the Windows compiler for the g_?to? macros so I used the /FAs option to generate a listing which contained the assembly code for one of the dissectors. Upon examining the code, I found it to be rather inefficient. Upon poking around a bit,

Re: [Wireshark-dev] Win32 build

2012-01-10 Thread Bill Meier
On 1/10/2012 2:47 PM, Andriy Beregovenko wrote: Hi, I'm write a custom dissector, and it works fine... under Linux, but not under Windows. Thus I have a problem to run wireshark under Windows as well as debug problem. So, I built wireshark stable version 1.6.4 and 1.4.10 using manual [0]. Of

Re: [Wireshark-dev] Win32 build

2012-01-10 Thread Bill Meier
On 1/10/2012 3:02 PM, Bill Meier wrote: On 1/10/2012 2:47 PM, Andriy Beregovenko wrote: Hi, I'm write a custom dissector, and it works fine... under Linux, but not under Windows. Thus I have a problem to run wireshark under Windows as well as debug problem. So, I built wireshark stable version

<    1   2   3   4   5   6   7   >