Re: [Wireshark-dev] Bluetooth and Miscellaneous menus

2015-01-28 Thread Stephen Fisher
On Wed, Jan 28, 2015 at 11:59:10AM +0100, Michal Labedzki wrote: This is good time to ask about platform-dependant options... what if some functionality can be done only on Linux? Show only on Linux, hide on other? (disable?) Or maybe Wireshark does not like stuff like that at all?

Re: [Wireshark-dev] Open-only-once capture devices and the packet rate spark lines (was Re: nflog in qt and gtk)

2015-01-25 Thread Stephen Fisher
On Sat, Jan 24, 2015 at 05:32:19PM -0800, Guy Harris wrote: (It would be Truly Nice if Oracle/HP/IBM provided isolated Solaris/HP-UX/AIX virtual machines, for which free-software developers could request access including root access if necessary, for build testing and run-time testing.) I

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 10750] Use of GdkPixdata / gdk_pixbuf_new_from_inline deprecated in gdk-pixbuf 2.31.2

2015-01-07 Thread Stephen Fisher
On Wed, Jan 07, 2015 at 06:21:06PM +, bugzilla-dae...@wireshark.org wrote: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10750 --- Comment #7 from Balint Reczey bal...@balintreczey.hu --- (In reply to Stephen Fisher from comment #6) Distribution sources really shouldn't disable

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 10750] Use of GdkPixdata / gdk_pixbuf_new_from_inline deprecated in gdk-pixbuf 2.31.2

2015-01-07 Thread Stephen Fisher
On Wed, Jan 07, 2015 at 07:51:33PM +0100, B?lint R?czey wrote: Removing usages of the deprecated functions is on my TODO list, but if I can't finish that in reasonable time keeping the reminder would help others to act. What about leaving disabled functions deprecated in git and removing it

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-07 Thread Stephen Fisher
On Tue, Jan 06, 2015 at 07:45:08PM +0100, B?lint R?czey wrote: Originally I was skeptical regarding CMake, but now I think this is the best cross-platform option, thus the best option for Wireshark. Just give it a try, and you will never look back. :-) Oookay, I'll try it :) Theoretically

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Stephen Fisher
On Mon, Jan 05, 2015 at 08:26:23AM +, Graham Bloice wrote: CMake can still generate nmake files if you wish, but IMHO the normal route would be to generate VS solution files and then build from the command line with msbuild, or fire up the IDE and build from there. I've always liked the

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Stephen Fisher
On Mon, Jan 05, 2015 at 05:20:27PM +, Graham Bloice wrote: Yes, use CMake :-) There are other cross-platform build solutions such as SCons, but it's just as bad as CMake (or maybe worse, I haven't tried anything other than a toy project). Adding a dissector to CMake is as simple as

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Stephen Fisher
On Mon, Jan 05, 2015 at 03:34:16PM -0500, Ed Beroset wrote: Having been around this particular block a couple of times, yes, CMake at times is a battle, but it's also better than the alternative of producing (and maintaining) multiple mutually incompatible and inevitably arbitrarily

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Stephen Fisher
On Mon, Jan 05, 2015 at 11:46:48PM +, Graham Bloice wrote: On 5 January 2015 at 23:39, Stephen Fisher sfis...@sdf.org wrote: Right, that's the best part of of autoconf: it generates a shell script called configure that will run on any system without having autoconf installed

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Stephen Fisher
On Tue, Jan 06, 2015 at 09:35:32AM +1000, David Arnold wrote: In my experience, shipping the configure(.sh) and Makefile(s) will work on any Unix system: you don?t need the configure.ac, Makefile.am or autoconf/automake installed in order to configure and build. Right, that's the best part

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Stephen Fisher
On Mon, Jan 05, 2015 at 03:34:16PM -0500, Ed Beroset wrote: Stephen Fisher wrote: Indeed. So what about making a script to read in Makefile.common and spitting out those XML files for msbuild? Or update the msbuild so IDE things in those files (if any) aren't reset every time its rebuilt

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Stephen Fisher
On Mon, Jan 05, 2015 at 06:02:53PM +, Graham Bloice wrote: I don't get your last comment. Unless you're modifying the build system or adding new files, CMake doesn't come into it after the initial solution generation. The solution files automagically rebuild themselves if something

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-04 Thread Stephen Fisher
On Sun, Jan 04, 2015 at 10:08:53AM +, Graham Bloice wrote: Maybe your Win7 SDK came from an earlier install of the Platform SDK? My Win8 32-bit machine at home is a fresh install, so VC 2013 CE is the only VC I've ever installed. The Win7 64-bit install at work install may have had

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-03 Thread Stephen Fisher
On Sat, Jan 03, 2015 at 03:39:42PM +, Graham Bloice wrote: What version of VS are you using? VS 2013 Community Edition (on 64-bit Win7) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-03 Thread Stephen Fisher
On Sat, Jan 03, 2015 at 06:52:56PM +, Graham Bloice wrote: OK, it seems that even after all the complaints MS still haven't updated VS 201x to provide it. IIRC it went missing in VS2010. See here for at least one complaint about it:

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-02 Thread Stephen Fisher
On Fri, Jan 02, 2015 at 12:52:04PM -0800, Gerald Combs wrote: We have PowerShell scripts that prep text files and assist with NSIS packaging, both of which are specific to Windows. You must also have PowerShell 2.0 or later installed if you want to install Chocolatey packages. Gotcha,

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-02 Thread Stephen Fisher
On Mon, Dec 22, 2014 at 12:01:58PM +, Graham Bloice wrote: I have mostly got the rework to the Developers Guide ready to update it to use VS2013 Community Edition. I'm setting up a Windows build environment again for the first time in a couple of years and the instructions are working

[Wireshark-dev] Our Git URLs: https vs ssh

2015-01-02 Thread Stephen Fisher
I've seen two URLs for getting Wireshark via Git: https://code.wireshark.org/review/wireshark and ssh://my.usern...@code.wireshark.org:29418/wireshark The first one is mentioned in the developer's guide and elsewhere, while the second is mentioned for using

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-02 Thread Stephen Fisher
One more thing I ran into: https://ask.wireshark.org/questions/4725/file-win32mak-not-found-stop Using Gerald's suggestion worked to get past verify_tools and setup so far: SET INCLUDE=%INCLUDE%;c:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Include Should this be included in the dev

Re: [Wireshark-dev] Update Windows Build Instructions

2014-12-22 Thread Stephen Fisher
On Mon, Dec 22, 2014 at 12:01:58PM +, Graham Bloice wrote: I have mostly got the rework to the Developers Guide ready to update it to use VS2013 Community Edition. The question is how far do I go in removing old stuff? I've already removed anything from earlier than VS2010, but I'm

Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig version 0.28 so we can use th...

2014-12-19 Thread Stephen Fisher
On Fri, Dec 19, 2014 at 09:05:17AM +, Anders Broman wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Stephen Fisher Sent: den 19 december 2014 00:45 To: wireshark-dev@wireshark.org Subject: Re

Re: [Wireshark-dev] [Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions.

2014-12-19 Thread Stephen Fisher
Thanks for correcting this. I see now that there are other functions defined the way you re-defined floorl(). The example I randomly picked to follow was wsutil/tempfile.[ch], which is done with just AC_CHECK_FUNCS() and #ifndef HAVE_MKSTEMP. Does that need to be corrected too then? On

Re: [Wireshark-dev] [Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions.

2014-12-19 Thread Stephen Fisher
My build, on a system without floorl(), is now failing here (I'm building --with-gtk2 and --without-qt currently): gmake[2]: Entering directory '/usr/local/src/wireshark' CCLD wireshark-gtk ui/libui.a(libui_a-time_shift.o): In function `time_string_to_nstime':

Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig version 0.28 so we can use th...

2014-12-18 Thread Stephen Fisher
-MessageType: comment Gerrit-Change-Id: I4c5af4cedd8c1927c1e00dd6b42faef3f31b84d4 Gerrit-PatchSet: 1 Gerrit-Project: wireshark Gerrit-Branch: master Gerrit-Owner: Stephen Fisher sfis...@sdf.org Gerrit-Reviewer: Michael Mann mman...@netscape.net Gerrit-Reviewer: Petri Dish Buildbot buildbot

Re: [Wireshark-dev] [Wireshark-commits] master b000ada: Finish renaming si_code to mtp3_si_code.

2014-12-18 Thread Stephen Fisher
On Fri, Dec 19, 2014 at 02:32:13AM +, Wireshark code review wrote: b000ada by Jeff Morriss (jeff.morriss...@gmail.com): Finish renaming si_code to mtp3_si_code. Thanks for catching that. I'm still fixing a bunch of other things for my first compile on NetBSD, so I didn't get that

Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...

2014-12-15 Thread Stephen Fisher
On Mon, Dec 15, 2014 at 08:23:47AM +0100, Michal Labedzki wrote: Personally I prefer ENC_NA for single-byte. Me too. How about changing proto_tree_add_item() so that the endian field is optional? Single byte: proto_tree_add_item(tree, proto_test, tvb, 0, 1); Multi-byte:

Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...

2014-12-14 Thread Stephen Fisher
On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: That being said, the convention (certainly not enforced) seems to be to use ENC_..._ENDIAN for fetching all integral types. Could this be related to when we made the change from using FALSE / TRUE to specify if its big endian in

Re: [Wireshark-dev] What Wireshark base version to use for customization

2014-12-10 Thread Stephen Fisher
On Wed, Dec 10, 2014 at 03:13:08PM -0500, John Dill wrote: Does the license only apply to those to whom the binary has been distributed to? If the plugin is never publicly released, does the license imply that only the receivers of the plugin are required to be sent the source code? If

Re: [Wireshark-dev] The possibility of a curses based Wireshark

2014-12-01 Thread Stephen Fisher
On Sun, Nov 30, 2014 at 06:54:43PM +1100, Edwin Groothuis wrote: I would totally make this with TurboVision as the TUI. Ah, the good oll' days. And I had no idea it was open source now! ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] The possibility of a curses based Wireshark

2014-12-01 Thread Stephen Fisher
On Sat, Nov 29, 2014 at 11:05:20AM +0100, B?lint R?czey wrote: While I would not stop you from starting a nice big interesting project you can already run Wireshark remotely via HTTP using GTK+ 3's Broadway backend. You just need to use a tunnel for HTTP and it works way better on

[Wireshark-dev] The possibility of a curses based Wireshark

2014-11-28 Thread Stephen Fisher
I've started tinkering with the possibility of making a curses text based GUI for Wireshark (cshark, I suppose). I started by making a new directory under ui/ for it and creating dummy functions for things that the main code base runs (such as file.c) to display things in the user interface.

Re: [Wireshark-dev] The possibility of a curses based Wireshark

2014-11-28 Thread Stephen Fisher
On Fri, Nov 28, 2014 at 12:23:03PM -0700, Stephen Fisher wrote: One major issue would be implementing things like the packet list. We currently extend the GtkTreeView/GtkTreeModel in GTK and at quick glance it appears that we extend QTreeView/QAbstractItemModel in a similar fashion for Qt

Re: [Wireshark-dev] The possibility of a curses based Wireshark

2014-11-28 Thread Stephen Fisher
On Fri, Nov 28, 2014 at 11:46:08AM -0800, Guy Harris wrote: I don't think completely eliminating GLib is a project for 2.0 (or whatever the version number of the Qt-as-the-default Wireshark will be). That might happen in the future, but that means changing a lot more of Wireshark to C++

Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-26 Thread Stephen Fisher
Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? We could simplify it to be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the latest version of GTK on the system (3.x, if available, otherwise 2.x) when

Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-26 Thread Stephen Fisher
On Wed, Nov 26, 2014 at 01:26:51PM -0500, Jeff Morriss wrote: I have both Gtk3 and Gtk2 installed but build with Gtk2. The Gtk3 UI just looks horrible to me (and, no, I'm not one who really cares about how things look but, well, I have a choice). I was hoping it was just me that had that

[Wireshark-dev] Toolbar icons without text -- know issue in Qt?

2014-11-25 Thread Stephen Fisher
Is it a known issue in Wireshark Qt that it only shows icons in the main toolbar, even when the icons and text option is chosen in the preferences? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org

[Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-25 Thread Stephen Fisher
I decided to stop building my local Wireshark with GTK3 support by adding --without-gtk3 (or --with-gtk3=no) assuming that this would still imply that I wanted it built with qt (--with-qt or --with-qt=yes), since they both default to yes, but the current logic in configure.ac doesn't account

[Wireshark-dev] Screenshot for Gerrit review 5185

2014-11-20 Thread Stephen Fisher
As requested by Alexis Gouette on Gerrit review #5185 (https://code.wireshark.org/review/#/c/5185/), I'm attaching a screenshot showing the group box with title in the preferences screen since Gerrit doesn't seem to have a way to attach normal files.

Re: [Wireshark-dev] Compilation error in ws_mempbrk_sse42.c

2014-11-04 Thread Stephen Fisher
On Mon, Nov 03, 2014 at 04:14:15PM -0700, Stephen Fisher wrote: I haven't done Wireshark development in a while, so I'm not familiar with some of the new code, such as wsutil/ws_mempbrk_sse42.c. On FreeBSD 10.0-RELEASE on amd64 (with clang as the new default compiler), I'm getting

Re: [Wireshark-dev] Compilation error in ws_mempbrk_sse42.c

2014-11-04 Thread Stephen Fisher
On Tue, Nov 04, 2014 at 12:34:36PM -0800, Guy Harris wrote: You presumably meant gint8, that being what you used in the commit. Yes, thanks for the clarification. int8_t is a C99 datatype; older versions of various UN*Xes might not support it, and, even on those that do, you might have to

[Wireshark-dev] Compilation error in ws_mempbrk_sse42.c

2014-11-03 Thread Stephen Fisher
I haven't done Wireshark development in a while, so I'm not familiar with some of the new code, such as wsutil/ws_mempbrk_sse42.c. On FreeBSD 10.0-RELEASE on amd64 (with clang as the new default compiler), I'm getting this error on my initial build: Making all in wsutil gmake[2]: Entering

[Wireshark-dev] Type-punned pointer... breaks anti-aliasing rules in dfilter-macro.c

2013-06-18 Thread Stephen Fisher
When trying to compile Wireshark (SVN trunk) on FreeBSD for the first time in a long time, I ran across a familiar error:     dfilter-macro.c: In function 'dfilter_macro_init':     dfilter-macro.c:614: warning: dereferencing type-punned pointer will break strict-aliasing rules However, line

Re: [Wireshark-dev] Why are authors never Cc'ed before their code is changed?

2012-08-20 Thread Stephen Fisher
From: lafo...@gnumonks.org 1) Is this the way how the wireshark development model / flow is supposed to work ? Yes. The Wireshark model is that people submit patchs and then the Wireshark core developers become the ongoing maintainers. This seems to have been necessary for a long time

Re: [Wireshark-dev] How to save the stream data for a special protocol

2012-07-27 Thread Stephen Fisher
On Fri, 27 Jul 2012 02:51:02 -0600 qiang.huangqiang.hu...@symbio.com wrote It's no problem for us to write a dissector Plugin to dissect one or more packets for a special protocol. But we find that it's nearly impossible to use it to save its stream data for its

Re: [Wireshark-dev] GTK3 problems

2012-07-16 Thread Stephen Fisher
On Sun, 15 Jul 2012 08:56:28 -0600 Joerg Mayer wrote I opened https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7377 a while ago but except for one person who added a me too nothing happend. This problem basically makes the GTK3 version unuseable on my system. !(me too) I just

[Wireshark-dev] r43579 Generic preference implementation broken compile

2012-07-06 Thread Stephen Fisher
SVN revision 43579 broke compilation: prefs_nameres.c: In function 'nameres_prefs_show': prefs_nameres.c:109: error: 'e_prefs' has no member named 'name_resolve' prefs_nameres.c:126: error: 'e_prefs' has no member named 'name_resolve' This is one case of trying to use the variable that no longer

Re: [Wireshark-dev] r43579 Generic preference implementation    broken compile

2012-07-06 Thread Stephen Fisher
On Fri, 06 Jul 2012 11:57:35 -0600 Pascal Quantinpascal.quan...@gmail.com wrote give a try to current top of tree: it should compile. I just did an svn update again and I'm at r43588 but still the same problem.

Re: [Wireshark-dev] r43579 Generic preference implementation broken compile

2012-07-06 Thread Stephen Fisher
On Fri, 06 Jul 2012 12:03:30 -0600 mman...@netscape.net wrote Also, prefs_nameres.c shouldn't be building anymore. The top of the tree should have it removed from any makefiles (unless I screwed up the patch). The functionality of prefs_nameres.c was replaced with the

Re: [Wireshark-dev] Exposing KRB5 value_strings to other dissectors ...

2012-07-03 Thread Stephen Fisher
On Tue, 03 Jul 2012 08:45:46 -0600 Richard Sharpe wrote There are protocols that specify the use of KRB5 specified values. Eg, NegoEx specifies RFC3961 strings. Rather than simply re-entering these values it would be useful to reuse the existing value_string variables, but they are

Re: [Wireshark-dev] Exposing KRB5 value_strings to other dissectors ...

2012-07-03 Thread Stephen Fisher
On Tue, 03 Jul 2012 09:22:40 -0600 Stephen Fisher wrote On Tue, 03 Jul 2012 08:45:46 -0600 Richard Sharpe wrote There are protocols that specify the use of KRB5 specified values. Eg, NegoEx specifies RFC3961 strings. Rather than simply re-entering these values

Re: [Wireshark-dev] Use shared libraries for dissectors?

2012-06-29 Thread Stephen Fisher
On Fri, 29 Jun 2012 08:23:07 -0600 Richard Sharpe wrote One of the problems I see is that the startup time of Wireshark can be long because of the size of the Wireshark binary. There are a large number of protocols in Wireshark now, many of which I don't use. There is also the

Re: [Wireshark-dev] strange packet dissection order when loading the 1st pcap file

2012-06-25 Thread Stephen Fisher
On Mon, 25 Jun 2012 14:08:22 -0600 wsgd wrote Summary : - packets are dissected twice (3 times for packet 1) - in the good order for 1st sequence - not in the good order for the 2nd sequence packet 4 dissected just after packet 1 This happens on wireshark : 1.8.0, 1.6.0,

Re: [Wireshark-dev] strange packet dissection order when loading the 1st pcap file

2012-06-25 Thread Stephen Fisher
On Mon, 25 Jun 2012 14:54:59 -0600 wsgd wrote But even I reduce the summary pane to less than 1 line, the 2nd sequence is : 1 4 1. 4th packet still here ! If I remember correctly, it may render a few extra lines (packets) that are outside of the visible area too.

Re: [Wireshark-dev] Style question passing boolean parameters

2012-06-20 Thread Stephen Fisher
On Tue, 19 Jun 2012 23:12:26 -0600 Joerg Mayer wrote What ways are there to fix this? Is replacing the boolean types by an enum with speaking elements a valid solution? As an example, the above might read: Or using macros, such as: #define NOT_COMPRESSED FALSE if

Re: [Wireshark-dev] Looking for explanation of build files

2012-05-16 Thread Stephen Fisher
On Wed, 16 May 2012 07:59:22 -0600 Beth wrote Is there a description somewhere of what each of the files are for?  I've been poking around in the various docs, both the ones included with the Wireshark source and the ones based at http://wiki.wireshark.org/Development, and so far

Re: [Wireshark-dev] ANSI escape codes

2012-05-15 Thread Stephen Fisher
On Tue, 15 May 2012 05:00:14 -0600 Marek Tews wrote I create my dissector and I found ANSI escape codes in strings. Is there already something ready to dissection ANSI escape codes? I don't think so. What is the protocol?

Re: [Wireshark-dev] Conversation tracking

2012-05-11 Thread Stephen Fisher
On Fri, 11 May 2012 08:30:03 -0600 Tobias Weiss wrote Right now I'm puzzled: I wanted to use conversation tracking in order to save information about the state of the communication across packet dissection. The dissector is called completely out of order (which is reasonable)

Re: [Wireshark-dev] Conversation tracking

2012-05-11 Thread Stephen Fisher
On Fri, 11 May 2012 09:46:45 -0600 Stephen Fisher wrote Are you trying to keep track of where the current packet belongs in the whole conversation? The exec dissector I previously mentioned (packet-exec.c) does this. Look at the exec_hash_entry_t struct up toward the top. A more

Re: [Wireshark-dev] Conversation tracking

2012-05-10 Thread Stephen Fisher
On Thu, 10 May 2012 10:26:46 -0600 Tobias Weiss wrote I'm using conversation tracking and ran into an issue. My code looks like this (as suggested in the README.developer): conv = find_conversation(pinfo-fd-num, pinfo-src, pinfo-dst, pinfo-ptype,

Re: [Wireshark-dev] Conversation tracking

2012-05-10 Thread Stephen Fisher
On Thu, 10 May 2012 15:54:44 -0600 Tobias Weiss wrote Thanks, this is working just fine. But in that case I suggest an update to README.developer as I copied the buggy source-code from there. Which section(s) were you copying the source code from?

Re: [Wireshark-dev] Problem in using a global variable in wireshark/gtk folder which is defined in epan/dissectors/ folder

2012-05-02 Thread Stephen Fisher
On Wed, 02 May 2012 02:01:02 -0600 Vishnu Bhatt wrote I am implementing a functionality where I want to scan all packets in a pcap file, and depending on a configuration, select only the relevant packets of a call flow (basically create a filter and then apply it). I will be

Re: [Wireshark-dev] tcp_dissect_pdus() fixed_len issue

2012-04-26 Thread Stephen Fisher
On Thu, 26 Apr 2012 06:55:02 -0600 Tobias Weisstwe...@ra.rockwell.com wrote I'm currently developing a dissector for a quite old TCP protocol. Most of the stuff is straight forward and not a real problem. But right now I'm facing an issue and need some help. In my main

[Wireshark-dev] Clear packet comment should remove the comment entirely?

2012-03-30 Thread Stephen Fisher
Unfortunately, I haven't been following development much lately. I see that we have a packet comment feature now. Is there a way to remove a comment entirely? I envision the clear button in the Edit or Add Packet Comments could do this instead of just clearing the text buffer, but I see that

Re: [Wireshark-dev] Runtime error

2012-03-29 Thread Stephen Fisher
On Wed, 28 Mar 2012 21:34:16 -0600 Adam Grbec wrote Attached is a screenshot of an error I am getting when running wire shark. Is there a fix or a workaround for this error? Can you please type the text of the error into an e-mail? It's bad enough to have a huge screenshot, but

Re: [Wireshark-dev] Built wireshark failed make[2]: *** [services] Error 1

2012-02-24 Thread Stephen Fisher
On Fri, 24 Feb 2012 02:32:51 -0700 Marcel Haas wrote i wanna bulit wireshark and get a failure. Maybe someone of u know the reason. /usr/bin/perl ./tools/make-services.pl starting to fetch http://www.iana.org/assignments/port-numbers ... request for

[Wireshark-dev] Problems with r40742

2012-02-16 Thread Stephen Fisher
r40742 is causing compilation problems on FreeBSD (64-bit 9.0-RELEASE): packet-smpp.c: In function 'smpp_mktime': packet-smpp.c:1189: error: invalid operands to binary - With reference to this code: *secs -= timezone; ... for which Jeff had concerns about its portability in the

Re: [Wireshark-dev] accessing all TVB elements

2012-02-02 Thread Stephen Fisher
On Wed, 01 Feb 2012 19:24:19 -0700 Andrew Kampjes wrote I have a dissector and I need to load all the TVB elements to be displayed to preform a custom reassembly on them. The dissect_PROTO() function only gets the current TVB that you've clicked on at a time. I need either

[Wireshark-dev] CMake can't find glib

2012-01-27 Thread Stephen Fisher
I'm anxious to try out the beginnings of a Qt Wireshark, but I'm having trouble with CMake on FreeBSD. After making a separate directory to bulid in, and running cmake ../wireshark I get to this point; /usr/bin/ld: cannot find -lglib-2.0 *** Error code 1 As far as I can tell, the

Re: [Wireshark-dev] Question regarding QT/future Wireshark version

2012-01-05 Thread Stephen Fisher
On Thu, 05 Jan 2012 08:04:58 -0700 Roland Knall wrote Is there a point in the forseeable future, where new development for the GTK version will cease to exist (and just focus on bug-fixing) and all further development should go into the QT version? Considering that the new packet

Re: [Wireshark-dev] [Wireshark-commits] rev 40321: /trunk/ /trunk/epan/: base64.h epan.h epan_dissect.h ex-opt.h prefs.h strutil.h timestamp.h tvbuff.h /trunk/gtk/: recent.h /trunk/: airpcap_loader.h

2012-01-04 Thread Stephen Fisher
On Sun, 01 Jan 2012 04:06:06 -0700 Joerg Mayer wrote As it looks like we will soon have a second full blown ui (tshark isn't interactive, so I don't count this), how about - reorganizing the filesystem into something like: ui/- common ui stuff if it exists ui/gtk/

Re: [Wireshark-dev] How to retrieve text displayed for a proto_item ?

2011-12-29 Thread Stephen Fisher
On Fri, 23 Dec 2011 06:17:22 -0700 Teto wrote Thx for the quick answer as usual. Note this won't pass the inspection by reviewers. That was dissuasive ^^ I've done like you said, using a temp GString* , thanks for the advice See also doc/README.developer section 1.1.2 which talks

[Wireshark-dev] Crash in edit interface settings when doing remote capture (Windows)

2011-12-16 Thread Stephen Fisher
Wireshark crashes after the first character I type into the capture filter in the Edit Interface Settings window of a remote interface on Windows with latest SVN (and has for a while, but I never took the time to investigate). The crash is happening on line 407 of gtk\capture_dlg.c because of

Re: [Wireshark-dev] Console Window option moved?

2011-12-12 Thread Stephen Fisher
On Sun, Dec 11, 2011 at 01:11:46AM +0100, Akos Vandra wrote: As far as I know, I can use g_print for printing debug info from dumpcap code... isn't that right? I tried compiling code with that, and it builds fine. However nothing is printed on the console. I am using a linux build system

Re: [Wireshark-dev] [RFC] CANOpen dissector

2011-12-02 Thread Stephen Fisher
On Fri, Dec 02, 2011 at 04:21:15PM +0100, Yegor Yefremov wrote: I'm writing a CANOpen dissector (http://en.wikipedia.org/wiki/CANopen). The dissector itself is almost ready. The main problem I have is, how do I hook this dissector on to SocketCan one? CAN has no ports, so I can't decide on

Re: [Wireshark-dev] SPX protocol subdissector

2011-11-25 Thread Stephen Fisher
On Fri, Nov 25, 2011 at 12:28:19AM -0800, Guy Harris wrote: ...at least until a standard version of Wireshark is released with your changes (which requires that you give a patch to the Wireshark core developers, e.g. in a bug on bugs.wireshark.org). We will typically accept a patch to add

Re: [Wireshark-dev] Debugging on Windows

2011-11-14 Thread Stephen Fisher
On Sat, Nov 12, 2011 at 11:12:07AM -0500, Bill Meier wrote: (Note: Wireshark builds with VC2008 but VC2010 should also be OK). VC2010EE doesn't let you use the debugger to attach to a running process anymore like VC2008EE lets you do (although I couldn't get it to properly debug the other day

Re: [Wireshark-dev] Debugging on Windows

2011-11-14 Thread Stephen Fisher
On Mon, Nov 14, 2011 at 05:34:22PM +, Chris Maynard wrote: Hmm, I've had no problems doing that, running on either Windows XP SP3 (32-bit) or Windows 7 64-bit. In 2008? It used to work for me, but didn't the other day. I didn't spend too much time troubleshooting though. In 2010, they

[Wireshark-dev] Build problems with sbc-ap asn1 dissector

2011-11-08 Thread Stephen Fisher
Anders committed a fix for the compile problems with the sbc-ap asn1 dissector and I just committed another, but there are 3 others: cc1: warnings being treated as errors ../../asn1/sbc-ap/packet-sbc-ap-fn.c:28: warning: 'dissect_sbc_ap_Presence' defined but not used

Re: [Wireshark-dev] please help to look at my reject file produced by installing wireshark under FreeBSD ports!

2011-11-04 Thread Stephen Fisher
On Wed, Nov 02, 2011 at 07:14:59PM -0700, Li, Ming (Candy) wrote: I tried to install the wireshark under my FreeBSD ports, it failed and get the reject file, I want to know what the reject file mean, Does anyone of you can tell me that? Thank you! See my response to your message on the

Re: [Wireshark-dev] [Wireshark-commits] rev 39534: /trunk/epan/wspython/ /trunk/epan/wspython/: register-dissector.py wspy_register.c

2011-11-03 Thread Stephen Fisher
I removed these in SVN r39723. On Fri, Oct 28, 2011 at 01:13:23PM -0600, Stephen Fisher wrote: This patch causes debug output on the console when launching Wireshark: looking for dissectors in /usr/local/src/wireshark/epan/wspython/wspy_dissectors looking for dissectors in /home/sfisher

Re: [Wireshark-dev] Issue with building wireshark from source

2011-11-01 Thread Stephen Fisher
On Mon, Oct 31, 2011 at 09:06:48PM -0400, Jeff Morriss wrote: In this case the latest version of GTK+ is not really a good thing. GTK3 is special in that they ripped out backwards compatability for a lot of stuff, which means that applications (such as Wireshark) frequently need to be

Re: [Wireshark-dev] [Wireshark-commits] rev 39534: /trunk/epan/wspython/ /trunk/epan/wspython/: register-dissector.py wspy_register.c

2011-10-28 Thread Stephen Fisher
This patch causes debug output on the console when launching Wireshark: looking for dissectors in /usr/local/src/wireshark/epan/wspython/wspy_dissectors looking for dissectors in /home/sfisher/.wireshark/plugins registered protocols [] Can these be removed? On Mon, Oct 24, 2011 at 04:33:02PM

Re: [Wireshark-dev] Is tcp.len -1 a valid display filter?

2011-10-27 Thread Stephen Fisher
On Thu, Oct 27, 2011 at 08:28:43AM +0200, Stig Bjørlykke wrote: On a 32-bit system the display filter tcp.len -1 seems to be valid, and does return all TCP packets. The attached patch fixes this, but can we do this check in a simpler manner? Is there a problem with accepting -1 in that

Re: [Wireshark-dev] [libdissectors_la-packet-dtls.lo] Error 1 on Mac OSX Lion

2011-10-26 Thread Stephen Fisher
On Tue, Oct 25, 2011 at 09:07:04AM +0200, Flavio Pace wrote: When i try to compile Wireshark rev. 37286 ( but also the last ) on my Mac OSX Lion 10.7.2 /opt/local/include/gcrypt.h:1393: warning: 'gcry_md_algo_t' is deprecated I'm having this problem as well on FreeBSD as reported in my

Re: [Wireshark-dev] Wireshark newbee

2011-10-24 Thread Stephen Fisher
On Mon, Oct 24, 2011 at 12:44:47PM -0500, vijay wrote: I am looking for some information on how Wireshark uses libpcap to capture the packets and dissects it i.e, the complete process from packet capture from the network to displaying to the user. I searched for such a resource for some

Re: [Wireshark-dev] [Wireshark-commits] rev 39487: /trunk/debian/ /trunk/debian/: control

2011-10-20 Thread Stephen Fisher
I don't know how the debian things work in the Wireshark source, but I assume that this minimum GTK requirement will need to be bumped every time it is bumped in configure.in. Should we put a comment in configure.in to remind us to change it in debian/control as well? On Thu, Oct 20, 2011 at

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

2011-10-19 Thread Stephen Fisher
On Tue, Oct 04, 2011 at 03:07:43PM -0400, Tony Trinh wrote: The comment for ENC_NA: /* * For protocols (FT_PROTOCOL), aggregate items with subtrees (FT_NONE), * opaque byte-array fields (FT_BYTES), and other fields where there * is no choice of encoding (either because it's just a

Re: [Wireshark-dev] include tvbuff.h failed

2011-10-11 Thread Stephen Fisher
On Tue, Oct 11, 2011 at 02:02:48PM +0200, Marcel Haas wrote: i want to include the tvbuff.h to my code so i can make own tvbs with tvbuff_t* my code lies at wireshark/epan so as tvbuff.h. except.h:97: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’ Problem

Re: [Wireshark-dev] [Wireshark-commits] rev 39305: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sdp.c

2011-10-11 Thread Stephen Fisher
On Mon, Oct 10, 2011 at 11:13:41AM +0100, Martin Mathieson wrote: packet-sdp.c:1302 'data_tvb' might get clobbered by 'longjmp' or 'vfork' Making 'data_tvb' volatile doesn't work as I then get warnings about discarding the volatile qualifier by passing data_tvb to the various

Re: [Wireshark-dev] [Wireshark-commits] rev 39310: /trunk/ /trunk/: macosx-setup.sh

2011-10-11 Thread Stephen Fisher
Should this comment above the second GEOIP_VERSION be removed too? # # XXX - they appear to have an unversioned gzipped tarball for the # current version; should we just download that, with some other # way of specifying whether to download the GeoIP API? # On Sat, Oct 08, 2011 at 03:17:57PM

Re: [Wireshark-dev] Global conversation

2011-10-07 Thread Stephen Fisher
On Fri, Oct 07, 2011 at 02:51:35PM +0200, Anders Broman wrote: Perhaps it could be done if we had a Global conversation to which you cold add a List of per protocol conversations. We could create a new set of conversation functions, such as: global_conversation_new()

Re: [Wireshark-dev] Decompress Data

2011-10-07 Thread Stephen Fisher
On Fri, Oct 07, 2011 at 11:31:24AM +0200, Marcel Haas wrote: I have some packets witch are compress witz zlib. I want to uncompress them. Take a look at the tvb_uncompress() or tvb_child_uncompress() functions in epan/tvbuff.c. An example of tvb_child_uncompress() is in the HTTP

Re: [Wireshark-dev] core dump on starting wireshark (latest SVN update 39266?)

2011-10-05 Thread Stephen Fisher
On Wed, Oct 05, 2011 at 10:07:36PM +0200, Kaul wrote: I'm on #39276. Something tells me that until I delete the prefs., it's not going to go away :( Do a mv ~/.wireshark/preferences ~/.wireshark/preferences.old and see if it works fine after that. If so, sharing your preferences.old file

[Wireshark-dev] Can g_warning() be removed from gtk/main_menubar.c

2011-10-05 Thread Stephen Fisher
Can the calls to g_warning() be removed from gtk/main_menubar.c? I noticed it when I go to View - Time Display Format - Millseconds when it was on Automatic before. There are more cases of the g_warning(), which were presumably for testing when the UI manager code was being created.

Re: [Wireshark-dev] wireshark new protocol for IPv6

2011-09-30 Thread Stephen Fisher
On Fri, Sep 30, 2011 at 02:56:42PM +, Nadir BENOUHOUD wrote: I work on developing a new protocol (Q-ESP6) that provides security and QoS inIPv6, the protocol was developed in 2009 under IPv4 (Q-ESP) in wireshark as a plug-in. and to test my work I must develop an IPv6 wireshark

Re: [Wireshark-dev] Doubts regarding bug report submission

2011-09-29 Thread Stephen Fisher
On Thu, Sep 29, 2011 at 10:40:54AM +0530, Krishnamurthy Mayya wrote: review_for_checkin?* What does this mean?? That means that it will show up in the list of patches pending revie by one of the core developers for possible inclusion into the Wireshark source code repository. If a core

Re: [Wireshark-dev] Doubts regarding bug report submission

2011-09-29 Thread Stephen Fisher
On Thu, Sep 29, 2011 at 10:40:54AM +0530, Krishnamurthy Mayya wrote: I saw a message saying that 6382,6383,6384 and 6388,6389,6390 are duplicate bugs. We are sorry for that. Since we did not know whether to submit in the SVN repository or 1.7.x, both of us just submitted it listing

Re: [Wireshark-dev] Display multiple frames (of multiple TCP segments) in COL_INFO

2011-09-29 Thread Stephen Fisher
On Thu, Sep 29, 2011 at 09:33:02PM +0300, Kaul wrote: In the COL_INFO, I'll just see 'PDU 1'. Without trying out your dissector, my first guess is that the column is no longer writable the next time you're trying to write to it. You can check if it's writable before you write to it with the

Re: [Wireshark-dev] modelines

2011-09-28 Thread Stephen Fisher
On Wed, Sep 28, 2011 at 01:51:05AM +, Chris Maynard wrote: however, I am wondering if 8 is simply used more than 4 because that's what the Wireshark modeline generation tool happens to default to, I believe the GNU standard is for an 8 space tabstop, but now I can't find a reference to

Re: [Wireshark-dev] plugin development

2011-09-28 Thread Stephen Fisher
On Thu, Sep 29, 2011 at 12:38:59AM +0400, shjoon OoO wrote: I had gone through the documentation to see how the plugin can be developed , but i couldn't compile the Foo plugin example Which documentation have you read? It's simplier to make it a built-in dissector as described in

  1   2   3   4   5   6   7   8   9   10   >