On Aug 5, 2019, at 2:37 PM, Dario Lombardo wrote:
> On Mon, Aug 5, 2019 at 11:20 PM Guy Harris wrote:
>
>> On Aug 5, 2019, at 1:02 PM, Dario Lombardo wrote:
>>
>>> The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8
>>> fiield,
>>
>> If that's what it's telling you,
On Aug 5, 2019, at 1:02 PM, Dario Lombardo wrote:
> The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8
> fiield,
If that's what it's telling you, it's lying - the line in question is adding
hf_cdp_data, which is an FT_BYTES field.
The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8
fiield, that is 1 byte long, then no point is setting the endianess. From a
quick look of the dissector I can tell that hf_cdp_data has been used with
variable lengths. What's its len? If it's a variable len field ("data"
Re: https://code.wireshark.org/review/c/34169/
I've simply expanding definitions for existing flags in CDP packets,
specifically for four additional CDP capabilities, yet the Ubuntu
pre-commit check is failing due to code that shouldn't have anything to do
with changes I made.
On Aug 3, 2019, at 7:47 AM, Oliver Brown wrote:
> Re: https://code.wireshark.org/review/c/34169/
>
> I've simply expanding definitions for existing flags in CDP packets,
> specifically for four additional CDP capabilities, yet the Ubuntu pre-commit
> check is failing due to code that
