Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-23 Thread Jeff Morriss
Marc Petit-Huguenin wrote: > Jeff Morriss wrote: >> A more generic question is: how are dissectors using tcp_dissect_pdus() >> supposed to be "new style" (this dissector is now effectively no longer >> "new style"). "packet-xot" takes one approach but it's not obvious to >> me if that will real

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-23 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Morriss wrote: > Marc Petit-Huguenin wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> >> Please find attached a new version of the patch. > > Checked in (rev 22383), thanks! > > BTW, this dissector really should be broken up into

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-23 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Morriss wrote: > Marc Petit-Huguenin wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi, >> >> This is an update to the STUN2 dissector using the last draft, >> draft-ietf-behave-rfc3489bis-07. > > It doesn't compile as is: > >>

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-23 Thread Jeff Morriss
Marc Petit-Huguenin wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jeff Morriss wrote: >> Marc Petit-Huguenin wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> Hi, >>> >>> This is an update to the STUN2 dissector using the last draft, >>> draft-ietf-behave-rfc3489b

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-20 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Morriss wrote: > Marc Petit-Huguenin wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi, >> >> This is an update to the STUN2 dissector using the last draft, >> draft-ietf-behave-rfc3489bis-07. > > It doesn't compile as is: > >>

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-20 Thread Jeff Morriss
Marc Petit-Huguenin wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > This is an update to the STUN2 dissector using the last draft, > draft-ietf-behave-rfc3489bis-07. It doesn't compile as is: > gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I./../.. -I./.. -I/usr/include > -I/usr/l

[Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-09 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, This is an update to the STUN2 dissector using the last draft, draft-ietf-behave-rfc3489bis-07. Here is the changelog: * My employer is now sponsoring this work, so added a copyright line. * Added a comment for each method/attribute with the RFC