Re: [Wireshark-dev] [Patch] pragma warning

2007-04-03 Thread Sebastien Tandel
Now these changes are in the svn tree. Note that I've moved some dissectors from DISSECTOR_SRC to CLEAN_DISSECTOR_SRC but there are many others which could already be moved to CLEAN_DISSECTOR_SRC. Regards, Sebastien Tandel I made it partly for the Unix side. (Makefile.common and Makefile.am

Re: [Wireshark-dev] [Patch] pragma warning

2007-04-02 Thread Stephen Fisher
On Wed, Mar 28, 2007 at 05:01:06PM +0200, Sebastien Tandel wrote: I made it partly for the Unix side. (Makefile.common and Makefile.am affected). The Makefile is, in fact, building now four libraries : - asn dissectors : libasndissectors.la - pidl dissectors : libpidldissectors.la - normal

Re: [Wireshark-dev] [Patch] pragma warning

2007-04-02 Thread Guy Harris
On Apr 2, 2007, at 4:13 PM, Stephen Fisher wrote: We're still compiling epan/dissectors with a ton of warnings from auto-generated dissectors on Unix. How many of them are coming from asn2wrs-generated dissectors? asn2wrs is, for some reason, generating a lot of dissect_ functions that

Re: [Wireshark-dev] [Patch] pragma warning

2007-04-02 Thread Stephen Fisher
On Mon, Apr 02, 2007 at 04:40:05PM -0700, Guy Harris wrote: On Apr 2, 2007, at 4:13 PM, Stephen Fisher wrote: We're still compiling epan/dissectors with a ton of warnings from auto-generated dissectors on Unix. How many of them are coming from asn2wrs-generated dissectors? asn2wrs

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Graham Bloice
Gisle Vanem wrote: Graham Bloice [EMAIL PROTECTED] wrote: Gisle Vanem wrote: The #pragma warning() statements are MSVC specific. So embed them inside #ifdef _MSC_VER. I always thought unrecognised #pragma directives were ignored. I take it that MinGw barfs on them in some way? MingW

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread ronnie sahlberg
I dont think it is really realistic to have all autogenerated files always compile without any warnings. Maybe we should instead split Makefile.common up into three parts : First part : normal dissectors Second part : ANS2WRS generated dissectors which take extra compile time flags and

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread ronnie sahlberg
On 3/28/07, Ulf Lamping [EMAIL PROTECTED] wrote: ronnie sahlberg wrote: I dont think it is really realistic to have all autogenerated files always compile without any warnings. Maybe we should instead split Makefile.common up into three parts : First part : normal dissectors Second

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Luis Ontanon
On 3/28/07, ronnie sahlberg [EMAIL PROTECTED] wrote: On 3/28/07, Ulf Lamping [EMAIL PROTECTED] wrote: ronnie sahlberg wrote: I dont think it is really realistic to have all autogenerated files always compile without any warnings. Maybe we should instead split Makefile.common up into

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Joerg Mayer
On Wed, Mar 28, 2007 at 08:21:24AM +, ronnie sahlberg wrote: I dont think it is really realistic to have all autogenerated files always compile without any warnings. Which warnings do you have in mind specifically? Why do you think they can't be avoided? Maybe we should instead split

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Sebastien Tandel
I dont think it is really realistic to have all autogenerated files always compile without any warnings. Maybe we should instead split Makefile.common up into three parts : First part : normal dissectors Second part : ANS2WRS generated dissectors which take extra compile time flags and

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Luis Ontanon
On 3/28/07, Sebastien Tandel [EMAIL PROTECTED] wrote: I dont think it is really realistic to have all autogenerated files always compile without any warnings. Maybe we should instead split Makefile.common up into three parts : First part : normal dissectors Second part : ANS2WRS

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-28 Thread Sebastien Tandel
Hi Ulf, Maybe we should instead split Makefile.common up into three parts : First part : normal dissectors Second part : ANS2WRS generated dissectors which take extra compile time flags and definitions to suppress artefacts from the compiler. Third part : PIDL generated dissectors that

[Wireshark-dev] [Patch] pragma warning

2007-03-27 Thread Gisle Vanem
The #pragma warning() statements are MSVC specific. So embed them inside #ifdef _MSC_VER. Patch attached. --gv diff -u3 -Hb -r SVN-Latest\asn1\rrlp\packet-rrlp-template.c .\asn1\rrlp\packet-rrlp-template.c --- SVN-Latest\asn1\rrlp\packet-rrlp-template.c Tue Mar 27 17:18:46 2007 +++

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-27 Thread Graham Bloice
Gisle Vanem wrote: The #pragma warning() statements are MSVC specific. So embed them inside #ifdef _MSC_VER. I always thought unrecognised #pragma directives were ignored. I take it that MinGw barfs on them in some way? -- Regards, Graham Bloice

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-27 Thread Gisle Vanem
Graham Bloice [EMAIL PROTECTED] wrote: Gisle Vanem wrote: The #pragma warning() statements are MSVC specific. So embed them inside #ifdef _MSC_VER. I always thought unrecognised #pragma directives were ignored. I take it that MinGw barfs on them in some way? MingW ignores them, but

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-27 Thread Ulf Lamping
Gisle Vanem wrote: The #pragma warning() statements are MSVC specific. So embed them inside #ifdef _MSC_VER. Patch attached. checked in, If you still have such problems, please note. Regards, ULFL ___ Wireshark-dev mailing list

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-27 Thread Gisle Vanem
Ulf Lamping [EMAIL PROTECTED] wrote: If you still have such problems, please note. There's still some in generated files. It seems someone added the pragmas after they where autogenerated. IMHO the #pragma should go elsewhere. But where, should be left to the experts. A patch for now: diff

Re: [Wireshark-dev] [Patch] pragma warning

2007-03-27 Thread Ulf Lamping
Gisle Vanem wrote: Ulf Lamping [EMAIL PROTECTED] wrote: If you still have such problems, please note. There's still some in generated files. It seems someone added the pragmas after they where autogenerated. IMHO the #pragma should go elsewhere. But where, should be left to the