Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Stig Bjørlykke
On Tue, Jul 7, 2009 at 4:26 PM, wme...@wireshark.org wrote:  Various fixes:  1. For some reason: using an using the external tfs_yes_no doesn't work in a plugin; Does r28985 fix this issue? -- Stig Bjørlykke ___ Sent

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Bill Meier
Stig Bjørlykke wrote: On Tue, Jul 7, 2009 at 4:26 PM, wme...@wireshark.org wrote: Various fixes: 1. For some reason: using an using the external tfs_yes_no doesn't work in a plugin; Does r28985 fix this issue? I'll give it a try; (Maybe that's the real problem). (On a separate note

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Stig Bjørlykke
On Tue, Jul 7, 2009 at 4:48 PM, Bill Meierwme...@newsguy.com wrote: Stig Bjørlykke wrote: Does r28985 fix this issue? I'll give it a try; (Maybe that's the real problem). If this works I have a patch for all plugins dissectors. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Bill Meier
Stig Bjørlykke wrote: On Tue, Jul 7, 2009 at 4:48 PM, Bill Meierwme...@newsguy.com wrote: Stig Bjørlykke wrote: Does r28985 fix this issue? I'll give it a try; (Maybe that's the real problem). If this works I have a patch for all plugins dissectors. The compile of packet-esl still

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Stig Bjørlykke
On 7. juli. 2009, at 18.02, Bill Meier wrote: Also: given the typedef for true_false_strings, I'm curious as to the rationale for the changes like the following: WS_VAR_IMPORT const true_false_string tfs_true_false;to WS_VAR_IMPORT const true_false_string tfs_true_false[]; Doing

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Bill Meier
Stig Bjørlykke wrote: On 7. juli. 2009, at 18.02, Bill Meier wrote: I know value_string's are used in plugins, so it should be possible. But I'm no windows user so I have to say pass on this one... Right: I would guess that all the value_strings used in the plugins are defined in

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Stig Bjørlykke
On 7. juli. 2009, at 18.49, Bill Meier wrote: Right: I would guess that all the value_strings used in the plugins are defined in the plugin and that this is also true for true_false strings used in plugins I was looking at eap_code_vals[], defined in epan/dissectors/packet- eap.c (and

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Anders Broman
-dev-boun...@wireshark.org] On Behalf Of Bill Meier Sent: den 7 juli 2009 18:02 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h Stig Bjørlykke wrote: On Tue, Jul 7

Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h

2009-07-07 Thread Jaap Keuter
for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 28986: /trunk/plugins/ethercat/ /trunk/plugins/ethercat/: packet-esl.c packet-esl.h Stig Bjørlykke wrote: On Tue, Jul 7, 2009 at 4:48 PM, Bill Meierwme...@newsguy.com wrote: Stig Bjørlykke wrote: Does r28985 fix this issue