Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c

2012-11-04 Thread Jakub Zawadzki
On Sat, Nov 03, 2012 at 07:55:51PM -0400, Evan Huus wrote: On Mon, Oct 8, 2012 at 7:12 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: + if (cf-count frames_count framenum = cf-count) { +/* XXX, what we should do when new frames were received during rescaning but user clicked

Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c

2012-11-04 Thread Evan Huus
On Sun, Nov 4, 2012 at 3:34 AM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Sat, Nov 03, 2012 at 07:55:51PM -0400, Evan Huus wrote: On Mon, Oct 8, 2012 at 7:12 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: + if (cf-count frames_count framenum = cf-count) { +/* XXX,

Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c

2012-10-08 Thread Jakub Zawadzki
On Sun, Sep 30, 2012 at 06:32:26PM +0200, Jakub Zawadzki wrote: If we want to have bug #6208 fixed in 1.x we need to revert r45189 + do: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6208#c9 I'm not sure if I have time for writting such patch, but If anyone write one, I can review.

Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c

2012-09-30 Thread Maynard, Chris
So should r45182 and r45189 be scheduled for backport to fix bug 6208? - Chris From: wireshark-commits-boun...@wireshark.org [wireshark-commits-boun...@wireshark.org] On Behalf Of darkja...@wireshark.org [darkja...@wireshark.org] Sent: Friday, September

Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c

2012-09-30 Thread Jakub Zawadzki
On Sun, Sep 30, 2012 at 12:01:01PM -0400, Maynard, Chris wrote: So should r45182 and r45189 be scheduled for backport to fix bug 6208? I think r45189 is buggy, if wireshark is refiltering, and you get new packets, some packets might have wrong relative timestamps (displayed, captured), and wrong