Re: [Wireshark-dev] [Wireshark-commits] rev 45445: /trunk/epan/ /trunk/epan/: emem.c

2012-10-10 Thread Evan Huus
On Wed, Oct 10, 2012 at 8:24 AM, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45445 User: darkjames Date: 2012/10/10 05:24 AM Log: Fix bug #7814 We need to pass original pointer and length to munmap(). Directory: /trunk/epan/

Re: [Wireshark-dev] [Wireshark-commits] rev 45445: /trunk/epan/ /trunk/epan/: emem.c

2012-10-10 Thread Evan Huus
On Wed, Oct 10, 2012 at 8:32 AM, Evan Huus eapa...@gmail.com wrote: On Wed, Oct 10, 2012 at 8:24 AM, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45445 User: darkjames Date: 2012/10/10 05:24 AM Log: Fix bug #7814 We need to pass

Re: [Wireshark-dev] [Wireshark-commits] rev 45445: /trunk/epan/ /trunk/epan/: emem.c

2012-10-10 Thread Jakub Zawadzki
On Wed, Oct 10, 2012 at 08:32:00AM -0400, Evan Huus wrote: On Wed, Oct 10, 2012 at 8:24 AM, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45445 User: darkjames Date: 2012/10/10 05:24 AM Log: Fix bug #7814 We need to pass

Re: [Wireshark-dev] [Wireshark-commits] rev 45445: /trunk/epan/ /trunk/epan/: emem.c

2012-10-10 Thread Evan Huus
On Wed, Oct 10, 2012 at 8:53 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: On Wed, Oct 10, 2012 at 08:32:00AM -0400, Evan Huus wrote: On Wed, Oct 10, 2012 at 8:24 AM, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45445 User: darkjames

Re: [Wireshark-dev] [Wireshark-commits] rev 45445: /trunk/epan/ /trunk/epan/: emem.c

2012-10-10 Thread Jakub Zawadzki
On Wed, Oct 10, 2012 at 09:32:07AM -0400, Evan Huus wrote: The fix is needed regardless of what else happens - even with the old old allocator this was still a bug (in the sl_ allocator, if not the ep_ one) Nah, sl_ allocator don't have this bug. 1. Right now sl_free_all() is never used 2.

Re: [Wireshark-dev] [Wireshark-commits] rev 45445: /trunk/epan/ /trunk/epan/: emem.c

2012-10-10 Thread Evan Huus
On Wed, Oct 10, 2012 at 9:50 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: On Wed, Oct 10, 2012 at 09:32:07AM -0400, Evan Huus wrote: The fix is needed regardless of what else happens - even with the old old allocator this was still a bug (in the sl_ allocator, if not the ep_ one) Nah,

Re: [Wireshark-dev] [Wireshark-commits] rev 45445: /trunk/epan/ /trunk/epan/: emem.c

2012-10-10 Thread Jakub Zawadzki
On Wed, Oct 10, 2012 at 10:10:08AM -0400, Evan Huus wrote: I still think that https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5284#c26 would also fix the problem, and we just unnecessary overcomplicate allocator. Is that not the same idea Guy and Jeff discussed that earlier in the