Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-20 Thread Bill Meier
On 12/19/2014 11:28 PM, Bill Meier wrote: I will make the changes (for packet.h related) to the epan/dissector .c files and upload the changes to Gerrit in the next day or so. Bill Done (committed) ... ___ Sent via:

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-19 Thread Bill Meier
On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote: Change subject: Remove unneeded #includes from epan/dissectors .. Remove unneeded #includes from epan/dissectors Martin: Obviously, #includes usage in

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-19 Thread Martin Mathieson
This makes good sense to me, Bill. I was having too much fun with my python script to look carefully look at the bigger picture. I didn't realise how many header files epan/packet.h already pulls in. In particular, it indirectly includes glib.h (through column-utils.h), so we should remove

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-19 Thread Bill Meier
On 12/19/2014 4:19 PM, Bill Meier wrote: On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote: Change subject: Remove unneeded #includes from epan/dissectors .. Remove unneeded #includes from epan/dissectors