Re: [Wireshark-dev] DBUILD_logray=ON breaks linking

2022-10-04 Thread Eugène Adell
*"When linking with DBUILD_logray=ON, there won't be a WiresharkMainWindow, will there?"* Both are built. Finally, as both logray and wireshark have the same parent class, I could move the implementation and just call the parent and all is now working. Le mar. 27 sept. 2022 à 16:38, chuck c

Re: [Wireshark-dev] DBUILD_logray=ON breaks linking

2022-09-27 Thread chuck c
https://gitlab.com/wireshark/wireshark/-/blob/19b04bf5ed906a1c03854595d424ad1e13f17df9/ui/qt/protocol_preferences_menu.cpp WiresharkMainWindow* ptest; ptest = new WiresharkMainWindow( QApplication::topLevelAt(parentWidget()->mapToGlobal(QPoint())) );

Re: [Wireshark-dev] DBUILD_logray=ON breaks linking

2022-09-27 Thread Eugène Adell
Yes Chuck, I did that multiple times, and just before pushing my latest code. Le mar. 27 sept. 2022 à 15:57, chuck c a écrit : > > Since you have been working on it for a while, have you updated your master > and rebased the MR branch? > > On Tue, Sep 27, 2022 at 7:06 AM Eugène Adell wrote: >>

Re: [Wireshark-dev] DBUILD_logray=ON breaks linking

2022-09-27 Thread chuck c
Since you have been working on it for a while, have you updated your master and rebased the MR branch? On Tue, Sep 27, 2022 at 7:06 AM Eugène Adell wrote: > Hi all, > > I've been working on MR !2445 for a while and almost finished this > work, things were going rather well until

[Wireshark-dev] DBUILD_logray=ON breaks linking

2022-09-27 Thread Eugène Adell
Hi all, I've been working on MR !2445 for a while and almost finished this work, things were going rather well until DBUILD_logray=ON was added on the "Job Code Checks + Clang Warnings" job. It's still compiling and linking on my dev environment, but adding DBUILD_logray=ON is reproducing the