Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-09 Thread Martin Burnicki
Dario Lombardo wrote: > On Wed, Aug 8, 2018 at 9:39 AM Martin Burnicki > mailto:martin.burni...@meinberg.de>> wrote: > > So IMO it would make more sense to display such values with a fixed > floating point format similar to the Peer Clock Precision field, e.g. > > 0.00 instead of

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Dario Lombardo
On Wed, Aug 8, 2018 at 9:39 AM Martin Burnicki wrote: > So IMO it would make more sense to display such values with a fixed > floating point format similar to the Peer Clock Precision field, e.g. > > 0.00 instead of 0 > 0.944107 instead of 0.944107055664063 > 0.76 instead of

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Peter Wu
On Wed, Aug 08, 2018 at 09:48:46AM +0200, Martin Burnicki wrote: > > Eventually you (or the email admin) can find out why this happens. > > > > I don't have access to the infrastructure, but others can check.  > > Just FYI: Surprisingly, the confirmation emails for my private email > address

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Martin Burnicki
Dario Lombardo wrote: > On Mon, Aug 6, 2018 at 1:20 PM Martin Burnicki > mailto:martin.burni...@meinberg.de>> wrote: [...] > Then I tried to create account on bugzilla with that private email > address, and bugzilla said a confirmation email had been sent. However, > that email never

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-08 Thread Martin Burnicki
Guy Harris wrote: > On Aug 6, 2018, at 2:19 PM, Guy Harris wrote: > >> On Aug 6, 2018, at 4:20 AM, Martin Burnicki >> wrote: >> >>> As far as I have seen, proto_tree_add_double() seems to add a double >>> value to the output tree, >> >> *All* doubles use the same format string. The part of

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-07 Thread Guy Harris
On Aug 6, 2018, at 2:19 PM, Guy Harris wrote: > On Aug 6, 2018, at 4:20 AM, Martin Burnicki > wrote: > >> As far as I have seen, proto_tree_add_double() seems to add a double >> value to the output tree, > > *All* doubles use the same format string. The part of the format string for > the

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-06 Thread Dario Lombardo
On Mon, Aug 6, 2018 at 1:20 PM Martin Burnicki wrote: > > I think to do this would be easy for someone who is a bit familiar with > the wireshark source code. However, I'm new to this stuff so I can > potentially get it wrong unless I'm doing quite a bit of investigation > first. ;-) > > Don't

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-06 Thread Martin Burnicki
Hi Dario, Dario Lombardo wrote: > Hi Martin > If you can code the patch, feel free to push it to gerrit for code > review. I think to do this would be easy for someone who is a bit familiar with the wireshark source code. However, I'm new to this stuff so I can potentially get it wrong unless

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-06 Thread Dario Lombardo
Hi Martin If you can code the patch, feel free to push it to gerrit for code review. Otherwise, your best bet is bugzilla. Which login issues are you experiencing? On Mon, Aug 6, 2018 at 11:20 AM Martin Burnicki wrote: > Hi all, > > actually the root dispersion field from an NTP packet is only

[Wireshark-dev] Display more digits for NTP packet's root dispersion

2018-08-06 Thread Martin Burnicki
Hi all, actually the root dispersion field from an NTP packet is only displayed with 4 digits after the decimal point, i.e. 0.1 ms resolution. However, modern NTP servers may provide a better root dispersion. E.g., if only the LSB in the scaled integer of an NTP packet is set then this means ~15