Even in that tree/version (which is from 9 years ago), packet-xml.c doesn't
call the function itself. I don't see any out-of-tree commits to
packet-xml.c in the history of that tree. The only file that includes
packet-xml.h is packet-xmpp-utils.h (which is included by various XMPP
dissectors),
Hi,
Did some googling out of curiosity and found
https://jelmer.uk/klaus/wireshark/blob/e738b556d72d4db5d7df85969c15117dedd0d063/epan/dissectors/packet-xml.c
Search for “xml_get_attrib" So it seems it was part of packet-xml.c at some
point so perhaps safe to remove…
/Anders
From:
Hi *João,*
*I agree that every function / variable needs to be looked at carefully,
but more so if they have *WS_DLL_PUBLIC in a header file.
I will reinstate the XML functions in my change. Hopefully, in other
places I will find clear comments saying that they are provided for calling
from
Hi Martin,
As you said some functions may only be used by third party plugins so
indiscriminately removing every exported but not used function would be
a bad policy. Even if they're not actually being used right now, who
knows, they may be part of some public API for plugins, so for use as
My most recent MR (
https://gitlab.com/wireshark/wireshark/-/merge_requests/1829), has come
across some symbols that don't appear to be in used by our repo.
dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols
file: see diff output below
4934
I have done a bit more on this - I started picking off the ones at the end
of the (alphabetical) list - 2nd one is
https://gitlab.com/wireshark/wireshark/-/merge_requests/1817. Please feel
free if anyone feels motivated to tackle some of the earlier ones. The
script is much tidier now, and also
On Sun, Jan 24, 2021 at 8:27 PM Jirka Novak wrote:
> Hi,
>
> I checked the code I know:
>
> > epan/dissectors/packet-rtp-events.c (01a0 D>
> rtp_event_type_values_ext) is not referred to so could be static? (in>
> header)
> It is used in UI, outside of dissectors. Therefore it
Hi,
I checked the code I know:
> epan/dissectors/packet-rtp-events.c (01a0 D>
> rtp_event_type_values_ext) is not referred to so could be static? (in>
header)
It is used in UI, outside of dissectors. Therefore it should be exported.
> epan/dissectors/packet-rtp.c
Hi Moshe,
It would be possible. I would still like to hear from people if they think
it is worth doing, and we would need to clear the current cases (perhaps
with a list of agreed exemptions, like the PDCP key-setting functions I
mentioned). I will likely start picking off issues when I have
Would it also be possible to build this script into a GitLab CI job, to
detect and prevent the issue from recurring?
Moshe
On Sat, Jan 23, 2021 at 11:45 AM Martin Mathieson via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:
> Hi,
>
> I wrote a script to check whether variables and
Hi,
I wrote a script to check whether variables and functions in dissector
modules that were not static were:
- not called by any other dissector modules (including dissectors.c)
- mentioned in the header file corresponding to that dissector
Reasons to clean up these cases could include:
- it
11 matches
Mail list logo
