Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-27 Thread Gerald Combs
On 3/26/14 6:06 AM, Bálint Réczey wrote: 2014-03-21 22:24 GMT+01:00 Bálint Réczey bal...@balintreczey.hu: Hi, 2014-03-20 23:11 GMT-01:00 Guy Harris g...@alum.mit.edu: On Mar 20, 2014, at 2:24 PM, Chris Kilgour tec...@whiterocker.com wrote: On 03/20/2014 01:07 PM, Gerald Combs wrote: If

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-26 Thread Bálint Réczey
2014-03-21 22:24 GMT+01:00 Bálint Réczey bal...@balintreczey.hu: Hi, 2014-03-20 23:11 GMT-01:00 Guy Harris g...@alum.mit.edu: On Mar 20, 2014, at 2:24 PM, Chris Kilgour tec...@whiterocker.com wrote: On 03/20/2014 01:07 PM, Gerald Combs wrote: If the build system had open access what would

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-21 Thread Bálint Réczey
Hi, 2014-03-20 23:11 GMT-01:00 Guy Harris g...@alum.mit.edu: On Mar 20, 2014, at 2:24 PM, Chris Kilgour tec...@whiterocker.com wrote: On 03/20/2014 01:07 PM, Gerald Combs wrote: If the build system had open access what would keep someone from uploading a shell script containing a box full

[Wireshark-dev] Gerrit versus Buildbot

2014-03-20 Thread Chris Kilgour
Just had the unpleasant experience of having a patch submitted to gerrit where it sat for nearly one month, just got merged after a code review, then got reverted when buildbot revealed issues. When I have submitted to other gerrit-based projects like OpenOCD, they have an automated build

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-20 Thread Gerald Combs
On 3/20/14 11:40 AM, Chris Kilgour wrote: Just had the unpleasant experience of having a patch submitted to gerrit where it sat for nearly one month, just got merged after a code review, then got reverted when buildbot revealed issues. When I have submitted to other gerrit-based projects

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-20 Thread Chris Kilgour
On 03/20/2014 01:07 PM, Gerald Combs wrote: If the build system had open access what would keep someone from uploading a shell script containing a box full of weasels wearing clown shoes? Isn't the same thing true for Jenkins/buildbot spawned from gerrit? Surely the build machines must be

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-20 Thread Roland Knall
Fyi, the current Version of Jenkins works just fine with gerrit 2.8.2 on my setup. Regards, Roland Am Donnerstag, 20. März 2014 schrieb Gerald Combs : On 3/20/14 11:40 AM, Chris Kilgour wrote: Just had the unpleasant experience of having a patch submitted to gerrit where it sat for nearly

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-20 Thread Guy Harris
On Mar 20, 2014, at 2:24 PM, Chris Kilgour tec...@whiterocker.com wrote: On 03/20/2014 01:07 PM, Gerald Combs wrote: If the build system had open access what would keep someone from uploading a shell script containing a box full of weasels wearing clown shoes? Isn't the same thing true