Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2020-01-07 Thread Jiří Novák
Hi Pascal, > Where can we find a sample capture for testing? Could you create an > enhancement bug with the capture attached and referenced by the changeset? see bug 16314. It will be referred in next patch comment... Best regards,

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2020-01-07 Thread Pascal Quantin
Hi Jiří, Le mar. 7 janv. 2020 à 22:02, Jiří Novák a écrit : > Hello, > > I posted patch with iLBC for review: > > https://code.wireshark.org/review/#/c/35686/ > > I made my best with updating tools/*setup* files, but I have no way > how to test them. I kindly ask you for help: > - update

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2020-01-07 Thread Jiří Novák
Hello, I posted patch with iLBC for review: https://code.wireshark.org/review/#/c/35686/ I made my best with updating tools/*setup* files, but I have no way how to test them. I kindly ask you for help: - update Windows setup files - update MacOS macos-setup.sh - test other Unix like non

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 21:16, João Valverde wrote: On 29/12/19 20:46, Roland Knall wrote: The way here would be to push your patch to gerrit. iLBC seems to be distributed (at least the codec as part of the WebRTC project) with a BSD-Style license, so integration should be doable. Please also check,

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 20:46, Roland Knall wrote: The way here would be to push your patch to gerrit. iLBC seems to be distributed (at least the codec as part of the WebRTC project) with a BSD-Style license, so integration should be doable. Please also check, beside tools/debian-setup.sh there are

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Roland Knall
The way here would be to push your patch to gerrit. iLBC seems to be distributed (at least the codec as part of the WebRTC project) with a BSD-Style license, so integration should be doable. Please also check, beside tools/debian-setup.sh there are scripts in there for other Linux distributions as

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 13:46, Jiří Novák wrote: Hi, For Ubuntu there is tools/debian-setup.sh that installs optional packages (as this). I suggest you to test your change at least on this platform since it's the most common. OK. I will try. Did you make your change compilable without that library?

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 13:46, Jiří Novák wrote: Hi, For Ubuntu there is tools/debian-setup.sh that installs optional packages (as this). I suggest you to test your change at least on this platform since it's the most common. OK. I will try. Did you make your change compilable without that library?

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Pascal Quantin
Hi Jiri, Le dim. 29 déc. 2019 à 14:47, Jiří Novák a écrit : > Hi, > > > For Ubuntu there is tools/debian-setup.sh that installs optional > > packages (as this). > > I suggest you to test your change at least on this platform since it's > > the most common. > > OK. I will try. > > > Did you make

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Jiří Novák
Hi, > For Ubuntu there is tools/debian-setup.sh that installs optional > packages (as this). > I suggest you to test your change at least on this platform since it's > the most common. OK. I will try. > Did you make your change compilable without that library? You need some > preprocessor

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-28 Thread Dario Lombardo
Hi For Ubuntu there is tools/debian-setup.sh that installs optional packages (as this). I suggest you to test your change at least on this platform since it's the most common. Did you make your change compilable without that library? You need some preprocessor ifdefs for that. If you push your

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-28 Thread Jiří Novák
Hello, I finished iLBC codec support and it works fine for decoding and audio saving. The only issue is that I'm able to build and test it on Linux only. It depends on iLBC lib from https://github.com/TimothyGu/libilbc. It is package ilbc/ilbc-devel on Fedora

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-11-16 Thread Guy Harris
On Nov 16, 2019, at 10:58 AM, Gerald Combs wrote: > Adding the library to win-setup.ps1 requires action by the operations team, > as does installing it on the build machines. And adding it to macos-setup.sh doesn't require action by the operations team, but installing it on the macOS

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-11-16 Thread Gerald Combs
On 11/16/19 10:00 AM, Jiří Novák wrote: > Hi, > > I would like to write decoder for RTP with iLBC payload. I plan to use > ilbc library (https://github.com/TimothyGu/libilbc). > I copied detection commands from another library to CMakeFile and I > created/adapted cmake/modules/FindILBC.cmake

[Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-11-16 Thread Jiří Novák
Hi, I would like to write decoder for RTP with iLBC payload. I plan to use ilbc library (https://github.com/TimothyGu/libilbc). I copied detection commands from another library to CMakeFile and I created/adapted cmake/modules/FindILBC.cmake too. When I run cmake, it do not try to detect iLBC