Re: [Wireshark-dev] New WiMAX R6 plug-in

2007-07-24 Thread Jaap Keuter
Hi, Overruns aren't a problem as long as you end the value_string array with the closing tuple {0, NULL}. Thanx, Jaap Nitin Naveen wrote: > Hello, > > Thank you Martin and Sawada san for your comments. > I am OK with any plug-in name and I leave it up to you to decide. > I also accept most of

Re: [Wireshark-dev] New WiMAX R6 plug-in

2007-07-24 Thread Nitin Naveen
Hello, Thank you Martin and Sawada san for your comments. I am OK with any plug-in name and I leave it up to you to decide. I also accept most of the comments. One comment that I would like to discuss: Martin mentioned that I use value_str_array. But i was not sure how array overrun

Re: [Wireshark-dev] New WiMAX R6 plug-in

2007-07-24 Thread SAWADA Kentaro
I also express my thanks to Nivin. A few comments to add. (1) I also agree to give the different name to R6 plugin or rename the existsted wimax plugin with packet-ieee80216e and keep yours. (2) I'd like to feedback some points, but is it right place to do such things here, or I'd better

Re: [Wireshark-dev] New WiMAX R6 plug-in

2007-07-24 Thread Martin Mathieson
Thanks for posting this Nivin, I'm building it now and will try to test later on today, but here are a few quick comments: (1) I renamed the folder (on my machine) to be plugins/wimax-r6r4, so as not to clash with the exisint air interface protocols plugin. Does that seem OK to you? (2) you do

Re: [Wireshark-dev] New WiMAX R6 plug-in

2007-07-19 Thread Martin Mathieson
Hi, Please do send the code, preferably with one or more test captures (I have examples for some of R6, but not all)! Thanks, Martin On 7/19/07, Nitin Naveen <[EMAIL PROTECTED]> wrote: > Hi, > > I generated dummy packets for WiMAX protocol. Saved the capture to a dummy > file wimax_ether.cap. >

[Wireshark-dev] New WiMAX R6 plug-in

2007-07-18 Thread Nitin Naveen
Hi, I generated dummy packets for WiMAX protocol. Saved the capture to a dummy file wimax_ether.cap. Then ran 'fuzz-test.sh" ../fuzz-test.sh -p 2000 -d /root/ /root/wimax_ether.cap For all passes I got the following message Pass 839: /root/wimax_ether.cap: OK Have I missed something or all

Re: [Wireshark-dev] New WiMAX R6 plug-in

2007-07-10 Thread Jaap Keuter
Hi, First thing to so it testdrive it using fuzztest. Have a collection of capture files ready which fuzztest will feed to your Wireshark+plugin. That way you may find bugs not found during code review. Then make sure all support files are in as stated in README.plugin. Then 'make clean' the pl

[Wireshark-dev] New WiMAX R6 plug-in

2007-07-10 Thread Nitin Naveen
Hi, I am Nitin Naveen working at HUGHES SYSTIQUE. We have developed a plug-in to display WiMAX R6 messages (between BTS and ASNGW). This plug-in is NOT for the AIR interface. It is for WiMAX signalling messages carried over Ethernet/ IP/ UDP. We have followed most of the guidelines as per READM