Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-21 Thread Stig Bjørlykke
On 20. nov.. 2007, at 23.51, Didier wrote: It's called because the packet is selected and a redissection is triggered with old frame states (like visited) but only after dissector tables have been updated. ie wireshark outputs junk. Yup. And your patch seems to fix. Will commit.

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-20 Thread Stig Bjørlykke
2007/11/20, Didier [EMAIL PROTECTED]: Can you share a small capture? http://wiki.wireshark.org/SampleCaptures?action=AttachFiledo=gettarget=dmp-examples.pcap.gz Add port 24209 in the preferences. If register_init_routine() is called I don't see how flags.visited could be false. cf file.c

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-20 Thread Didier
[UTF-8?]On Tue, 20 Nov 2007 11:42:12 +0100, Stig Bjørlykke wrote 2007/11/20, Didier [EMAIL PROTECTED]: Can you share a small capture? http://wiki.wireshark.org/SampleCaptures?action=AttachFiledo=gettarget=dmp-examples.pcap.gz Add port 24209 in the preferences. Thanks. My problem is

[Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Stig Bjørlykke
Hi. In the DMP dissector I build a hash_table with some SEQ/ACK analysis values the first time the package is dissected (when pinfo-fd- flags.visited==FALSE). This hash_table is deleted in the dissectors init routine. When changing the udp port in the dissectors preferences, from an

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Jeff Morriss
Stig Bjørlykke wrote: Hi. In the DMP dissector I build a hash_table with some SEQ/ACK analysis values the first time the package is dissected (when pinfo-fd- flags.visited==FALSE). This hash_table is deleted in the dissectors init routine. When changing the udp port in the

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Stig Bjørlykke
On 19. nov.. 2007, at 22.15, Jeff Morriss wrote: Free it (and recreate it) in a routine registered with register_init_routine() instead? I am freeing it in the register_init_routine (which is called), but does not recreate it before the packages are dissected again. And with flags.visited

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Jeff Morriss
Stig Bjørlykke wrote: On 19. nov.. 2007, at 22.15, Jeff Morriss wrote: Free it (and recreate it) in a routine registered with register_init_routine() instead? I am freeing it in the register_init_routine (which is called), but does not recreate it before the packages are dissected

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Didier
[UTF-8?]On Mon, 19 Nov 2007 22:35:14 +0100, Stig Bjørlykke wrote On 19. nov.. 2007, at 22.15, Jeff Morriss wrote: Free it (and recreate it) in a routine registered with register_init_routine() instead? I am freeing it in the register_init_routine (which is called), but does not