Re: [Wireshark-dev] Question / nit / ocd trigger

2021-05-24 Thread chuck c
Not a why but when: https://gitlab.com/wireshark/wireshark/-/commit/5110b21fd8cba19554f0c4f7a52e96af3acf4927 typedef struct _packet_info { char *srcip; int ip_src; char *destip; int ipproto; int srcport; int destport; int iplen; int iphdrlen;} packet_info; Looks like "dest" was

Re: [Wireshark-dev] Question / nit / ocd trigger

2021-05-24 Thread John Thacker
On Mon, May 24, 2021 at 12:19 PM Graham Bloice wrote: > > > On Mon, 24 May 2021 at 16:22, Jason Cohen wrote: > >> One thing that has bothered me for years has been the TCP flags filters. >> ... >> >> Is there history, reasoning for this? Should there be some level of >> consistency? I

Re: [Wireshark-dev] Question / nit / ocd trigger

2021-05-24 Thread Graham Bloice
On Mon, 24 May 2021 at 16:22, Jason Cohen wrote: > One thing that has bothered me for years has been the TCP flags filters. > > The 6 primary TCP flags are: > SYN > ACK > PSH > RST > URG > FIN > > Then you get into the CWR, NS, ECE (ECN), etc... > > The filters in Wireshark all use the accepted,

[Wireshark-dev] Question / nit / ocd trigger

2021-05-24 Thread Jason Cohen
One thing that has bothered me for years has been the TCP flags filters. The 6 primary TCP flags are: SYN ACK PSH RST URG FIN Then you get into the CWR, NS, ECE (ECN), etc... The filters in Wireshark all use the accepted, known abbreviations save for RST and PSH. Those are spelled out as