Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-16 Thread Jeff Morriss
Hi Ulf, Ulf Lamping wrote: First of all, a big thank you to take some time to look at this topic. I guess the only way to improve the current situation is to find an automated way to find stuff like this and your approach looks promissing. :-) Thanks Does Subversion have the concept of a

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-15 Thread Ulf Lamping
Hi Jeff! First of all, a big thank you to take some time to look at this topic. I guess the only way to improve the current situation is to find an automated way to find stuff like this and your approach looks promissing. Although my perl knowledge is very limited, I was able to read and

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-09 Thread Richard van der Hoff
Ulf Lamping wrote: LEGO wrote: what about #defining them so they trigger an error? Although this would be a nice solution, I don't see a way to do this - it will conflict with the existing function declarations IMHO. I would be more than glad if we could do it that simple ... how

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-09 Thread Thomas Steffen
On 11/9/06, Ulf Lamping [EMAIL PROTECTED] wrote: LEGO wrote: what about #defining them so they trigger an error?Although this would be a nice solution, I don't see a way to do this -it will conflict with the existing function declarations IMHO. I think it depends on what kind of symbol you have.

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-09 Thread Joerg Mayer
On Tue, Nov 07, 2006 at 12:57:59PM +, LEGO wrote: what about #defining them so they trigger an error? #define ntohl error() won't work, a g_ntohl would match as well. But how about creating our own ntohl function with a conflicting prototype? ok, forget it, in that case we cannot include

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-09 Thread LEGO
I'm exploring Richard's proposal of using (nm -u) to write a report of what forbiden functions are baing used by which objects, if the report (a dependency of libwireshark.so ?) has more than 0 lines, the build will fail and output the contents of the report. Which functions should we add to the

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-08 Thread Ulf Lamping
LEGO wrote: what about #defining them so they trigger an error? Although this would be a nice solution, I don't see a way to do this - it will conflict with the existing function declarations IMHO. I would be more than glad if we could do it that simple ... Regards, ULFL

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-07 Thread Ulf Lamping
Jaap Keuter wrote: Hi, Checked in. Thanx, Jaap On Mon, 6 Nov 2006, Albert Chin wrote: Patch attached to convert usage of ntohl() - g_ntohl(). On HP-UX, ntohl() isn't available unless you -D_XOPEN_SOURCE_EXTENDED but there are other uses of g_ntohl(). -- albert chin ([EMAIL

Re: [Wireshark-dev] Replace ntohl() with g_ntohl() - automated check?

2006-11-07 Thread LEGO
what about #defining them so they trigger an error? On 11/7/06, Ulf Lamping [EMAIL PROTECTED] wrote: Jaap Keuter wrote: Hi, Checked in. Thanx, Jaap On Mon, 6 Nov 2006, Albert Chin wrote: Patch attached to convert usage of ntohl() - g_ntohl(). On HP-UX, ntohl() isn't