[Wireshark-dev] Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Evan Huus
Perhaps this is a discussion we should have had at Sharkfest, but it's come up now. Oh well. My objections to generated code in git are two-fold: practical and philosophical. Practically, it's painful to have to run make twice to test ASN.1 changes. It's painful to review diffs full of #line

Re: [Wireshark-dev] Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Guy Harris
On Jun 23, 2014, at 2:06 PM, Evan Huus eapa...@gmail.com wrote: As far as I can see, the main arguments for storing generated code in git are: - not all platforms have the tools necessary to generate the code - generating it can take lots of time I see four different types of people/groups

Re: [Wireshark-dev] Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Evan Huus
On Mon, Jun 23, 2014 at 5:32 PM, Guy Harris g...@alum.mit.edu wrote: On Jun 23, 2014, at 2:06 PM, Evan Huus eapa...@gmail.com wrote: As far as I can see, the main arguments for storing generated code in git are: - not all platforms have the tools necessary to generate the code -