Re: [Wireshark-dev] Warnings in gtkvumeter.c

2006-11-08 Thread Ulf Lamping
Hmmm, I don't understand both. Joerg Mayer wrote: gtkvumeter.c:946: warning: comparison of unsigned expression 0 is always false CLAMP is called with three variables of type GtkVUMeterScaling gtkvumeter.c:1144: warning: comparison of unsigned expression 0 is always false CLAMP is

Re: [Wireshark-dev] Warnings in gtkvumeter.c

2006-11-08 Thread Stephen Fisher
On Wed, Nov 08, 2006 at 11:07:15PM +0100, Ulf Lamping wrote: Joerg Mayer wrote: gtkvumeter.c:946: warning: comparison of unsigned expression 0 is always false CLAMP is called with three variables of type GtkVUMeterScaling gtkvumeter.c:1144: warning: comparison of unsigned expression

Re: [Wireshark-dev] Warnings in gtkvumeter.c

2006-11-08 Thread Stephen Fisher
On Wed, Nov 08, 2006 at 04:48:58PM -0800, Stephen Fisher wrote: One way that you can fix the warning is by manually assigning numbers to the enumerated values in gtkvumeter.h: A cleaner fix would be to just reverse the parameter order: CLAMP (scaling, GTK_VUMETER_SCALING_LINEAR,

Re: [Wireshark-dev] Warnings in gtkvumeter.c

2006-11-08 Thread Stephen Fisher
On Wed, Nov 08, 2006 at 04:59:56PM -0800, Stephen Fisher wrote: On Wed, Nov 08, 2006 at 04:48:58PM -0800, Stephen Fisher wrote: One way that you can fix the warning is by manually assigning numbers to the enumerated values in gtkvumeter.h: A cleaner fix would be to just reverse the

Re: [Wireshark-dev] Warnings in gtkvumeter.c

2006-11-07 Thread Ulf Lamping
Joerg Mayer wrote: gtkvumeter.c:946: warning: comparison of unsigned expression 0 is always false gtkvumeter.c:1144: warning: comparison of unsigned expression 0 is always false I'll have a look probably tomorrow ... Regards, ULFL ___