Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-20 Thread Andrew Feren
--- Guy Harris [EMAIL PROTECTED] wrote: Stephen Fisher wrote: My bad, it does work as I had intended. It highlights the field (with the function highlight_field()) whenever you do a hex or string search, but not when you do a filter search. Should we add filter search matches too?

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-20 Thread Andrew Feren
--- Stephen Fisher [EMAIL PROTECTED] wrote: On Mon, Nov 19, 2007 at 02:43:13PM -0700, Stephen Fisher wrote: On Mon, Nov 19, 2007 at 10:29:12PM +0100, Stig Bj?rlykke wrote: Does wireshark have any functionality like this? I know we have Find Packet, but this does not display the

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-20 Thread Stephen Fisher
On Tue, Nov 20, 2007 at 09:44:52AM -0800, Andrew Feren wrote: On Mon, Nov 19, 2007 at 02:43:13PM -0700, Stephen Fisher wrote: My bad, it does work as I had intended. It highlights the field (with the function highlight_field()) whenever you do a hex or string search, but not when you

[Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stig Bjørlykke
Hi. Often, when I have a packet with alot of elements, it's a bit hard to find the element matching the display filter. And when using a complex filter it would be nice to know why each packet matches. Does wireshark have any functionality like this? I know we have Find Packet, but this

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stephen Fisher
On Mon, Nov 19, 2007 at 10:29:12PM +0100, Stig Bj?rlykke wrote: Does wireshark have any functionality like this? I know we have Find Packet, but this does not display the matching element in the packet. Wireshark used to do this - I remember adding the feature myself. I'll take a look at why

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stephen Fisher
On Mon, Nov 19, 2007 at 02:43:13PM -0700, Stephen Fisher wrote: On Mon, Nov 19, 2007 at 10:29:12PM +0100, Stig Bj?rlykke wrote: Does wireshark have any functionality like this? I know we have Find Packet, but this does not display the matching element in the packet. Wireshark used to do

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Guy Harris
Stephen Fisher wrote: My bad, it does work as I had intended. It highlights the field (with the function highlight_field()) whenever you do a hex or string search, but not when you do a filter search. Should we add filter search matches too? I'd say yes - if a search pattern of any sort

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stig Bjørlykke
On 19. nov.. 2007, at 23.53, Stephen Fisher wrote: My bad, it does work as I had intended. It highlights the field (with the function highlight_field()) whenever you do a hex or string search, but not when you do a filter search. I find this working with hex search, and string search in

Re: [Wireshark-dev] Wish: Mark/Find the element matching the display filter

2007-11-19 Thread Stig Bjørlykke
On 19. nov.. 2007, at 23.58, Guy Harris wrote: That does raise an interesting question - if a pattern matches *more than one* field in a packet, should find next find the next instance that matches, even if it's in the same packet, or should it find the next instance in that packet and, if