[Wireshark-dev] bug in packet-bgp.c (Ethereal) and print-bgp.c (tcpdump) (fwd)

2006-10-06 Thread Aaron Campbell
The expression (BGP_OSPF_RTYPE_EXT ||BGP_OSPF_RTYPE_NSSA) will always evaluate to 1. As well, neither of these constants are defined as flag values, so a bitwise op was probably not intended either. Commit log for packet-bgp.c in Ethereal shows that this code originated from Aamer Akhter, and

Re: [Wireshark-dev] bug in packet-bgp.c (Ethereal) and print-bgp.c (tcpdump) (fwd)

2006-10-06 Thread Jaap Keuter
Hi, Checked in. Thanx, Jaap On Fri, 6 Oct 2006, Aaron Campbell wrote: The expression (BGP_OSPF_RTYPE_EXT ||BGP_OSPF_RTYPE_NSSA) will always evaluate to 1. As well, neither of these constants are defined as flag values, so a bitwise op was probably not intended either. Commit log for