Re: [Wireshark-dev] format_text_wsp() not working?

2022-11-15 Thread Anders Broman
Hi, Good catch, thanks. Best regards Anders Den tis 15 nov. 2022 kl 15:57 skrev João Valverde : > This is not going to work as intended: > > rawstr = tvb_format_text(pinfo->pool, tvb, offset, realsize - offset); > col_add_fstr(pinfo->cinfo, COL_INFO, "Reply: %s", >

Re: [Wireshark-dev] format_text_wsp() not working?

2022-11-15 Thread João Valverde
This is not going to work as intended:     rawstr = tvb_format_text(pinfo->pool, tvb, offset, realsize - offset);     col_add_fstr(pinfo->cinfo, COL_INFO, "Reply: %s", format_text_wsp(pinfo->pool, rawstr, realsize - offset)); The first call to tvb_format_text() already replaced "\n" with

[Wireshark-dev] format_text_wsp() not working?

2022-11-15 Thread Anders Broman
Hi, I encountered strange problem with https://gitlab.com/wireshark/wireshark/-/merge_requests/8848 packet 2 of the included trace causes a call to col_add_fstr(pinfo->cinfo, COL_INFO, "Reply: %s", format_text_wsp(pinfo->pool, rawstr, realsize - offset)); But it seems like the /n is not replaced