Re: [Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

2015-02-09 Thread Hadriel Kaplan
This appears to be a false positive. According to: https://msdn.microsoft.com/en-us/library/9t02bbsx.aspx ...the warning is generated because If the shift overflowed the 32-bit value, bits are lost. But that's what is actually intended in bitop (it's a 32-bit bit operations library). I

Re: [Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

2015-02-07 Thread Hadriel Kaplan
I'll take a look. -hadriel On Feb 7, 2015, at 4:54 PM, Bill Meier wme...@newsguy.com wrote: Hadriel: MSVC2013 Code Analysis is giving the following warning: ...\ws-git\epan\wslua\lua_bitop.c(116) : warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit

[Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

2015-02-07 Thread Bill Meier
Hadriel: MSVC2013 Code Analysis is giving the following warning: ...\ws-git\epan\wslua\lua_bitop.c(116) : warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value. After quick look at the code, my reaction: Uh Oh...