Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Guy Harris
On Apr 24, 2020, at 9:43 AM, Gerald Combs wrote: > I ran into this recently when upgrading Xcode's command line tools. Builds > fail for me when using the SDK that ships with Xcode.app and succeed when > using the one that ships with the command line tools: Wow, that's a crock. Sounds as if

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Dario Lombardo
It fixes the travis build as well. I'm pushing the fix. On Fri, Apr 24, 2020 at 7:24 PM Lori Jakab wrote: > Thanks Gerald, this was very useful, and fixed my problem. I observed that > it changed the compiler that cmake detects from AppleClang 11.0.0.1133 > to AppleClang 10.0.1.10010046. I

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Lori Jakab
Thanks Gerald, this was very useful, and fixed my problem. I observed that it changed the compiler that cmake detects from AppleClang 11.0.0.1133 to AppleClang 10.0.1.10010046. I assume that the mismatch is from me using a version of XCode updated for Catalina on Mojave. Thanks again, -Lori

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Gerald Combs
I ran into this recently when upgrading Xcode's command line tools. Builds fail for me when using the SDK that ships with Xcode.app and succeed when using the one that ships with the command line tools: $ sw_vers ProductName:Mac OS X ProductVersion: 10.15.4 BuildVersion: 19E287 $

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Lori Jakab
On Fri, Apr 24, 2020 at 6:27 PM Graham Bloice wrote: > > > On Fri, 24 Apr 2020 at 17:22, Lori Jakab wrote: > >> On Fri, Apr 24, 2020 at 6:06 PM Graham Bloice < >> graham.blo...@trihedral.com> wrote: >> >>> The macOS build slave is coping, according to the CMake output it's >>> using: >>> >>> --

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Lori Jakab
I attached my cmake output, in case that helps. -Lori On Fri, Apr 24, 2020 at 6:21 PM Lori Jakab wrote: > On Fri, Apr 24, 2020 at 6:06 PM Graham Bloice > wrote: > >> The macOS build slave is coping, according to the CMake output it's using: >> >> -- The C compiler identification is AppleClang

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Graham Bloice
On Fri, 24 Apr 2020 at 17:22, Lori Jakab wrote: > On Fri, Apr 24, 2020 at 6:06 PM Graham Bloice > wrote: > >> The macOS build slave is coping, according to the CMake output it's using: >> >> -- The C compiler identification is AppleClang 11.0.0.1133 >> -- The CXX compiler identification is

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Lori Jakab
On Fri, Apr 24, 2020 at 6:06 PM Graham Bloice wrote: > The macOS build slave is coping, according to the CMake output it's using: > > -- The C compiler identification is AppleClang 11.0.0.1133 > -- The CXX compiler identification is AppleClang 11.0.0.1133 > > I have the exact same

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Graham Bloice
The macOS build slave is coping, according to the CMake output it's using: -- The C compiler identification is AppleClang 11.0.0.1133 -- The CXX compiler identification is AppleClang 11.0.0.1133 on osx-10.14-x64. Presumably that's an older OS. On Fri, 24 Apr 2020 at 15:48, Lori Jakab

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Lori Jakab
This particular failure can be fixed by this: https://code.wireshark.org/review/36921 However, I get other failures afterwards: FAILED: epan/dissectors/CMakeFiles/dissectors.dir/packet-kerberos.c.o /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Dario Lombardo
Hi, I was aware of such a problem. The travis macOS builder got that while ago. https://travis-ci.org/github/crondaemon/wireshark I didn't bisect, but going back in build history, I looks something between 2acbaf584984828855a36105258033020f338c5c and d30a0a2ce7c17f5d695e9ee7647e92d3cc1156bb. On

Re: [Wireshark-dev] macOS build broken

2020-04-24 Thread Roland Knall
Feel free to give it a go > Am 24.04.2020 um 15:29 schrieb Lori Jakab : > >  > Hi, > > I'm have been building on macOS Mojave for a while without issues, but for > the last few days the build has been broken. I didn't try a git dissect yet > to see which commit broke it, but the issue seems

[Wireshark-dev] macOS build broken

2020-04-24 Thread Lori Jakab
Hi, I'm have been building on macOS Mojave for a while without issues, but for the last few days the build has been broken. I didn't try a git dissect yet to see which commit broke it, but the issue seems to be caused by the usage of the _Nonnull, _Nullable, or _Null_unspecified type specifiers