Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2020-09-14 Thread Christian Kreibich
On 9/14/20 2:46 PM, Guy Harris wrote: One thing is, as reported in one of the pre-commit build failures: ERROR: Please edit your merge request and make sure the setting Allow commits from members who can merge to the target branch is checked so that maintainers can

Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2020-09-14 Thread Guy Harris
On Sep 14, 2020, at 2:19 PM, Christian Kreibich wrote: > I finally got around to this and just submitted an MR: > > https://gitlab.com/wireshark/wireshark/-/merge_requests/281 > > I've not submitted code to Wireshark before, so please let me know if I > overlooked anything here. One thing

Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2020-09-14 Thread Christian Kreibich
On 7/11/19 3:16 PM, Christian Kreibich wrote: On 7/11/19 3:06 PM, Guy Harris wrote: I.e., compute the community ID for the flow to which a packet belongs, and add it to the protocol tree as a calculated field? Yep, exactly. I finally got around to this and just submitted an MR:

Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2019-07-11 Thread Guy Harris
On Jul 11, 2019, at 3:16 PM, Christian Kreibich wrote: > On 7/11/19 3:06 PM, Guy Harris wrote: >> I.e., compute the community ID for the flow to which a packet belongs, and >> add it to the protocol tree as a calculated field? > > Yep, exactly. Sounds good to me.

Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2019-07-11 Thread Christian Kreibich
On 7/11/19 3:06 PM, Guy Harris wrote: I.e., compute the community ID for the flow to which a packet belongs, and add it to the protocol tree as a calculated field? Yep, exactly. How about a higher-level pseudo-code description of the algorithm? That way, it 1) doesn't require the

Re: [Wireshark-dev] Community ID flow hashes in Wireshark

2019-07-11 Thread Guy Harris
On Jul 11, 2019, at 2:32 PM, Christian Kreibich wrote: > How do people here feel about adding the ability to see Community ID flow > hashes in Wireshark? I.e., compute the community ID for the flow to which a packet belongs, and add it to the protocol tree as a calculated field? > For