Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-24 Thread Bálint Réczey
Hi Jakub, 2014-07-22 0:52 GMT+02:00 darkjames...@darkjames.pl: Hi, On Sat, Jul 12, 2014 at 02:27:06AM +0200, B??lint R??czey wrote: I plan using ASAN for all programs which would catch (among others) use-after-free and reading below or over the malloc()-ed memory area. Those can't be

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-24 Thread Evan Huus
On Thu, Jul 24, 2014 at 2:42 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi Jakub, 2014-07-22 0:52 GMT+02:00 darkjames...@darkjames.pl: Hi, On Sat, Jul 12, 2014 at 02:27:06AM +0200, B??lint R??czey wrote: I plan using ASAN for all programs which would catch (among others)

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-21 Thread darkjames-ws
Hi, On Fri, Jul 11, 2014 at 11:12:37PM +0200, B??lint R??czey wrote: Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public. I have only fake one:

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-21 Thread darkjames-ws
Hi, On Sat, Jul 12, 2014 at 02:27:06AM +0200, B??lint R??czey wrote: I plan using ASAN for all programs which would catch (among others) use-after-free and reading below or over the malloc()-ed memory area. Those can't be caught if the program uses another layer of bulk memory allocations.

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
The biggest win, I think, would be if we can avoid calling free_chain at all because tvbs are always allocated in the right scope and so get freed automatically. I think this would involve touching every place that creates new tvbs backed with glib memory though... I will try and think about this

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Bálint Réczey
Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public. I'm not a fan of implementing custom memory management methods because partly because I highly doubt we can beat jemalloc easily on

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 5:12 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public. I'm not a fan of implementing custom memory management

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Anders Broman
Den 11 jul 2014 23:13 skrev Bálint Réczey bal...@balintreczey.hu: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public Ok I'll see if we can use something from the wiki instead. I'm

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 4:08 PM, Evan Huus eapa...@gmail.com wrote: The biggest win, I think, would be if we can avoid calling free_chain at all because tvbs are always allocated in the right scope and so get freed automatically. I think this would involve touching every place that creates

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 6:07 PM, Anders Broman a.broma...@gmail.com wrote: Den 11 jul 2014 23:13 skrev Bálint Réczey bal...@balintreczey.hu: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Bálint Réczey
Hi Evan, 2014-07-11 23:51 GMT+02:00 Evan Huus eapa...@gmail.com: On Fri, Jul 11, 2014 at 5:12 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Bálint Réczey
2014-07-12 0:07 GMT+02:00 Anders Broman a.broma...@gmail.com: Den 11 jul 2014 23:13 skrev Bálint Réczey bal...@balintreczey.hu: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.) To: Bálint Reczey bal...@balintreczey.hu On Fri, Jul 11, 2014 at 8:27 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi Evan, 2014-07-11 23:51 GMT+02:00 Evan Huus eapa