Re: [Wireshark-dev] Gerrit Diff format

2014-03-31 Thread Gerald Combs
On 3/28/14 11:17 AM, Bill Meier wrote: (To: Gerald) Currently the Gerrit diff shows whitespace changes. Previously, when viewing diffs of SVN commits via the web, whitespace changes were not shown. If others agree, is it possible to configure the Gerrit diff to not show whitespace

Re: [Wireshark-dev] Viewing code in Gerrit

2014-03-31 Thread Gerald Combs
On 3/24/14 9:03 AM, Evan Huus wrote: On Mon, Mar 24, 2014 at 11:26 AM, Bill Meier wme...@newsguy.com wrote: On 3/24/2014 9:21 AM, Evan Huus wrote: In summary: the diff is computed locally in javascript, and seems to be worse than O(n) on the size of the underlying file; viewing the diff for

Re: [Wireshark-dev] Is it possible to update the version of gcrypt?

2014-03-31 Thread Gerald Combs
On 3/30/14 10:00 AM, Pascal Quantin wrote: 2014-01-08 0:25 GMT+01:00 Pascal Quantin pascal.quan...@gmail.com mailto:pascal.quan...@gmail.com: Gerald, according to the README.Wireshark file found in gnutls-2.12.18-1.2-win32ws archive, you manually modified the OpenSUSE packages:

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-31 Thread Jeff Morriss
On 03/28/14 10:29, Hadriel Kaplan wrote: Howdy, Is there any reason not to make wireshark 1.11.x and beyond only use Lua 5.2? Right now the automated builds are getting built with 5.1. There's very little difference to end users (i.e., older scripts should continue to work)... but for the

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-31 Thread Gerald Combs
On 3/28/14 8:42 AM, Pascal Quantin wrote: 2014-03-28 16:34 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com mailto:hadriel.kap...@oracle.com: The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only released this past December, but 5.2.2 has been out

Re: [Wireshark-dev] What about backporting fixes to older releases with the new workflow?

2014-03-31 Thread Gerald Combs
On 3/27/14 10:13 PM, Anders Broman wrote: Hi, How do we handle backports in the new work flow with git? The submitter of a patch could help by submitting the backport once the patch has been accepted. But what do we do in the case when this isn't happening? The core developer accepting the

Re: [Wireshark-dev] What about backporting fixes to older releases with the new workflow?

2014-03-31 Thread Hadriel Kaplan
On Mar 31, 2014, at 5:17 PM, Gerald Combs ger...@wireshark.org wrote: For each cherry-pick the release notes need to be updated with any bug fixes, protocol updates and (if needed) an advisory. This can be done by amending or with a separate commit. Huh, I did not know that. Do we need to

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-31 Thread Hadriel Kaplan
On Mar 31, 2014, at 2:55 PM, Gerald Combs ger...@wireshark.org wrote: Yes exactly. Right now our binaries seem to come from http://luabinaries.sourceforge.net/download.html (Gerald will confirm). That's correct. The Lua development teams is one of the few that provide Windows libraries

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-31 Thread Hadriel Kaplan
On Mar 31, 2014, at 2:05 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: Do you mean Wireshark would no longer compile/run if the Lua version was 5.2? Yes, that would be the ultimate goal. That way someone writing a Lua script and wants to share it with others doesn't have to worry

Re: [Wireshark-dev] What about backporting fixes to older releases with the new workflow?

2014-03-31 Thread Pascal Quantin
2014-03-31 23:17 GMT+02:00 Gerald Combs ger...@wireshark.org: On 3/27/14 10:13 PM, Anders Broman wrote: Hi, How do we handle backports in the new work flow with git? The submitter of a patch could help by submitting the backport once the patch has been accepted. But what do we do in

Re: [Wireshark-dev] Is it possible to update the version of gcrypt?

2014-03-31 Thread Pascal Quantin
2014-03-31 20:02 GMT+02:00 Gerald Combs ger...@wireshark.org: On 3/30/14 10:00 AM, Pascal Quantin wrote: 2014-01-08 0:25 GMT+01:00 Pascal Quantin pascal.quan...@gmail.com mailto:pascal.quan...@gmail.com: Gerald, according to the README.Wireshark file found in

Re: [Wireshark-dev] Is it possible to update the version of gcrypt?

2014-03-31 Thread Gerald Combs
On 3/31/14, 6:35 PM, Pascal Quantin wrote: 2014-03-31 20:02 GMT+02:00 Gerald Combs ger...@wireshark.org mailto:ger...@wireshark.org: On 3/30/14 10:00 AM, Pascal Quantin wrote: 2014-01-08 0:25 GMT+01:00 Pascal Quantin pascal.quan...@gmail.com mailto:pascal.quan...@gmail.com