Re: [Wireshark-dev] Change in wireshark[master]: USB: do not take into account implicit structure alignment i...

2015-01-16 Thread Pascal Quantin
2015-01-16 3:40 GMT+01:00 Guy Harris g...@alum.mit.edu: On Jan 15, 2015, at 1:54 PM, Pascal Quantin (Code Review) code-review-do-not-re...@wireshark.org wrote: Pascal Quantin has uploaded a new change for review. https://code.wireshark.org/review/6560 Change subject: USB: do not

Re: [Wireshark-dev] where to put the Bug: line for bugzilla integration

2015-01-16 Thread Alexis La Goutte
On Fri, Jan 16, 2015 at 3:31 AM, Bill Meier wme...@newsguy.com wrote: On 1/15/2015 10:44 AM, Jeff Morriss wrote: On 01/15/15 10:21, Evan Huus wrote: Public service announcement, since I've gotten a few emails from people confused why bugzilla integration seems flaky: The bugzilla

[Wireshark-dev] address to string optimization

2015-01-16 Thread mmann78
A few weeks ago I stumbled across the following comment in address_to_str.c: /*XXX FIXME the code below may be called very very frequently in the future. optimize it for speed and get rid of the slow sprintfs */ /* XXX - perhaps we should have individual address types register a table of

[Wireshark-dev] Packet reassemble - FTP-DATA Dissector - FTP - Export Object

2015-01-16 Thread leonardoc...@libero.it
I already posted this question to Ask.Wireshark.org; as I have a very tight schedule and realise the mailing list is more appropriate, I am posting it here as well. Please advice me if I need to remove the other post. I am implementing object export for the

[Wireshark-dev] Issues packaging Wireshark in Ubuntu

2015-01-16 Thread Juan Jose Martin Carrascosa
Hi all, I have a very quick question: am I supposed to create deb packages by doing make debian-package? The makefile doesn't recognize that option :( Thanks, Juanjo Martin ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Issues packaging Wireshark in Ubuntu

2015-01-16 Thread Bálint Réczey
Hi Juanjo, 2015-01-16 17:04 GMT+01:00 Juan Jose Martin Carrascosa jua...@rti.com: Hi all, I have a very quick question: am I supposed to create deb packages by doing make debian-package? The makefile doesn't recognize that option :( No, by running dpkg-buildpackage -rfakeroot. Cheers, Balint

Re: [Wireshark-dev] Issues packaging Wireshark in Ubuntu

2015-01-16 Thread Juan Jose Martin Carrascosa
It works perfectly. Many thanks for the prompt answer. Juanjo Martin On Fri, Jan 16, 2015 at 5:15 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi Juanjo, 2015-01-16 17:04 GMT+01:00 Juan Jose Martin Carrascosa jua...@rti.com: Hi all, I have a very quick question: am I supposed to

Re: [Wireshark-dev] Packet reassemble - FTP-DATA Dissector - FTP - Export Object

2015-01-16 Thread Pascal Quantin
2015-01-16 16:07 GMT+01:00 leonardoc...@libero.it leonardoc...@libero.it: I already posted this question to Ask.Wireshark.org; as I have a very tight schedule and realise the mailing list is more appropriate, I am posting it here as well. Please advice me if I need to remove the other post.

Re: [Wireshark-dev] address to string optimization

2015-01-16 Thread Guy Harris
On Jan 16, 2015, at 6:04 AM, mman...@netscape.net wrote: A few weeks ago I stumbled across the following comment in address_to_str.c: /*XXX FIXME the code below may be called very very frequently in the future. optimize it for speed and get rid of the slow sprintfs */ /* XXX - perhaps

Re: [Wireshark-dev] address to string optimization

2015-01-16 Thread mmann78
I still like the idea of the address types being centrally registered (in epan directory) and not put into the dissector code, mostly because many of the address types are used in multiple dissector/protocols. You may also introduce epan dependencies (like from proto.c) with the dissectors,

Re: [Wireshark-dev] address to string optimization

2015-01-16 Thread Guy Harris
On Jan 16, 2015, at 11:34 AM, mman...@netscape.net wrote: I still like the idea of the address types being centrally registered (in epan directory) and not put into the dissector code, mostly because many of the address types are used in multiple dissector/protocols. Perhaps libwireshark