Hi Constantine,
If I read the review history correctly, you were asked to perform some changes
that you did 2 days ago. This is not abnormal not to get any feedback in such a
short period, and that does not mean the receiver lost interest but simply that
he is busy.
So my suggestion is to be a
21 mars 2021 14:25:53 Constantine Gavrilov :
> Pascal, thank you again.
>
> Two days is not the end of the world. Initial review has taken one week, and
> that was a bit long for me, but it is not the end of the world either. Anders
> comment was a good answer, because he said that he could
Sometime ago, I started to work on NVMEoF dissector. I have already
contributed the number of fixes and improvements and they have already
been merged.
My goal is to have a full dissection for connection establishment,
management and IO flow, and I would like to move on quickly.
The goal is
Pascal, thank you.
> You should accommodate the project, and not the other way around.
I have never assumed otherwise, just tried to reach out...
I will wait until the end of the week and see what happens...
--
Constantine Gavrilov
Storage Architect
While correct as an answer, the main Limitation here is dumpcap. You would have
to implement a mechanism to let dumpcap know which format to use for the
internal pipe to the extcap interrace. DLT could be that. Pcapng has been on
the wishlist for a very long time as a format
Kind regards
Hi
Can an extcap program write to a wiretap-supported file format other than
pcap or pcapng? A quick test (hack to file preamble and frames in
extcap_example.py) suggests not..
Has it to do with synchronising whole frames being read at the wireshark
end of the pipe?
Regards,
Martin
Hi Constantine,
21 mars 2021 13:40:22 Constantine Gavrilov :
> Pascal, thank you for your answer.
>
> What would be a reasonable time to wait? A week, two weeks, a month? Long
> review times a problem by themselves, since I cannot move ahead. But it is
> not even a problem of waiting as much,
Pascal, thank you again.
Two days is not the end of the world. Initial review has taken one week,
and that was a bit long for me, but it is not the end of the world either.
Anders comment was a good answer, because he said that he could not do it,
and he did exactly what I asked -- he has let
I really meant " As a contributor, I canNOT control any form of merge
request assignment or have control over who will look at the merge
request."
The original post misses NOT.
From: "Constantine Gavrilov"
To: wireshark-dev@wireshark.org
Date: 03/21/2021 11:47 AM
Subject:
Pascal, thank you for your answer.
What would be a reasonable time to wait? A week, two weeks, a month? Long
review times a problem by themselves, since I cannot move ahead. But it is
not even a problem of waiting as much, as it is a problem of communication
loss. Dropping a line " will review
On Sun, Mar 21, 2021 at 1:21 PM Martin Mathieson via Wireshark-dev
wrote:
> Can an extcap program write to a wiretap-supported file format other than
> pcap or pcapng? A quick test (hack to file preamble and frames in
> extcap_example.py) suggests not..
> Has it to do with synchronising whole
11 matches
Mail list logo
