Re: [Wireshark-dev] c-string dissector - desegmentation

2006-09-12 Thread Tomasz Noiński
On Tue, 12 Sep 2006 14:50:27 -0700 Guy Harris <[EMAIL PROTECTED]> wrote: > On Sep 12, 2006, at 12:51 PM, Tomasz Noiński wrote: > > > Comments about "new_dissector_t" in packet.h say: > > > > /* > > * Dissector that returns: > > * > > * The amount of data in the protocol's PDU, if it was able

Re: [Wireshark-dev] c-string dissector - desegmentation

2006-09-12 Thread Guy Harris
On Sep 12, 2006, at 12:51 PM, Tomasz Noiński wrote: > Comments about "new_dissector_t" in packet.h say: > > /* > * Dissector that returns: > * > * The amount of data in the protocol's PDU, if it was able to > * dissect all the data; > * > * 0, if the tvbuff doesn't contain a PDU for that

Re: [Wireshark-dev] need urgent info on 802.11n feature development

2006-09-12 Thread Guy Harris
On Sep 12, 2006, at 2:16 AM, joyjit mullick wrote: > i would like to get an idea of the time around which the 802.11n > frames(as according to 802.11n-D1.0.pdf ) decoding support > will be fully implemented in ethereal. And I would like to get an idea of the time around which the 802.11n pro

Re: [Wireshark-dev] How to add a string to the tree

2006-09-12 Thread Guy Harris
On Sep 12, 2006, at 12:28 PM, prashanth joshi wrote: > In the following function, > what is pinfo _U_ (pinfo followed by a blank space and then _U_? _U_ is a macro defined by the Wireshark build process. If the compiler is GCC 2.0 or a later GCC release, it expands to __attribute((unused))__

Re: [Wireshark-dev] c-string dissector - desegmentation

2006-09-12 Thread Tomasz Noiński
On Tue, 12 Sep 2006 12:00:48 + "ronnie sahlberg" <[EMAIL PROTECTED]> wrote: Hello, Thanks for replying. > dissectors are assumed to return either TRUE or FALSE and not the > number of consumed bytes so the lower layers will not call your > dissector again for you. > > This only happens when

[Wireshark-dev] Query regarding a decoder function

2006-09-12 Thread prashanth joshi
prashanth joshi <[EMAIL PROTECTED]> wrote:Hi, In the following function, what is pinfo _U_  (pinfo followed by a blank space and then _U_? I am seeing such kind of variable for the first time. Can i use instead packet_info  * ptr as a formal argument in decode_gtp_chrg_id? And is the calli

Re: [Wireshark-dev] How to add a string to the tree

2006-09-12 Thread prashanth joshi
Hi, In the following function, what is pinfo _U_  (pinfo followed by a blank space and then _U_? I am seeing such kind of variable for the first time. Can i use instead packet_info  * ptr as a formal argument in decode_gtp_chrg_id? And is the calling of function foo( ) correct? Wont it give co

Re: [Wireshark-dev] [Patch] IPFIX

2006-09-12 Thread Anders Broman
Checked in. Brg Anders -Ursprungligt meddelande- Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För Andrew Feren Skickat: den 12 september 2006 20:19 Till: wireshark-dev@wireshark.org Ämne: [Wireshark-dev] [Patch] IPFIX This is a repost from April 2006. The original messages was > Fr

Re: [Wireshark-dev] Ethereal-dev] Crash on Windows XP

2006-09-12 Thread Guy Harris
Tomáš Haniš wrote: > # I build and package Ethereal ver. 0.10.7 on Windows XP (Sp2). At the end of > # building proces it pop's up the window with mesage: > # > # Tethereal has encountered a problem and needs to close. We are sorry for > the > # inconvenience. ... > # Can anybody help

[Wireshark-dev] [Patch] IPFIX

2006-09-12 Thread Andrew Feren
This is a repost from April 2006. The original messages was > From: Luca Deri <[EMAIL PROTECTED]> > Date: Thu, 20 Apr 2006 11:29:51 +0200 > > Dear all, > please find enclosed a patch to the CFlow dissector (packet-netflow.c) > that enables it to decode IPFIX packet traces. > > Regards, Luca The

Re: [Wireshark-dev] need urgent info on 802.11n feature development

2006-09-12 Thread Joerg Mayer
On Tue, Sep 12, 2006 at 02:46:07PM +0530, joyjit mullick wrote: > i would like to get an idea of the time around which the 802.11n frames(as > according to 802.11n-D1.0.pdf ) decoding support > will be fully implemented in ethereal. When a) We have documentation how to implement this protocol (th

Re: [Wireshark-dev] [patch] Stanag 5066 dissector type 25 s_prim parser's bug

2006-09-12 Thread Taner KURTULUŞ
Hi, > Confirmed. > > It was indeed a "copy-paste-did not edit correctly" bug. > > While going over the code once more, I found: > > 1 - One bug in the heuristic. (Changed '&&' to '||') > 2 - One to-do that was already done. (Removed the /* TODO */) > 3 - One to-do that is now done. ;-) > > Patch

Re: [Wireshark-dev] A problem of buildingwiresharkunder cygwin(libpcap)

2006-09-12 Thread Cook, Timothy
Top post Test!!! I'd be interested if you can get Wireshark to build & debug in CYGWIN only!! -Tim > > A It makes it hard to understand the cause and effect. > Q What's wrong with top-posting? Not sure if you like or dislike top posting. I'm using MS Outlook & the posts that I cc show up top

Re: [Wireshark-dev] ESP Patch for Hexadecimal keys

2006-09-12 Thread Frédéric Roudaut
Hi, ronnie sahlberg wrote: > Nice. > Maybe uploading the example to the other examples on the wiki? > > ==> Done > I have made some very minor cosmetic changes to the dissector of yours > that anders checked in. > > Thanks > I also changed it so that the payload inside ah/esp is displayed at

Re: [Wireshark-dev] [patch] Stanag 5066 dissector type 25 s_prim parser's bug

2006-09-12 Thread ronnie sahlberg
checked in On 9/12/06, Menno Andriesse <[EMAIL PROTECTED]> wrote: > Confirmed. > > It was indeed a "copy-paste-did not edit correctly" bug. > > While going over the code once more, I found: > > 1 - One bug in the heuristic. (Changed '&&' to '||') > 2 - One to-do that was already done. (Removed the

Re: [Wireshark-dev] c-string dissector - desegmentation

2006-09-12 Thread ronnie sahlberg
You are correct. You can not use tcp_dissect_pdus() for that case. dissectors are assumed to return either TRUE or FALSE and not the number of consumed bytes so the lower layers will not call your dissector again for you. This only happens when you use tcp_dissect_pdus() since it uses a special ca

Re: [Wireshark-dev] [patch] Stanag 5066 dissector type 25 s_prim parser's bug

2006-09-12 Thread Menno Andriesse
Confirmed. It was indeed a "copy-paste-did not edit correctly" bug. While going over the code once more, I found: 1 - One bug in the heuristic. (Changed '&&' to '||') 2 - One to-do that was already done. (Removed the /* TODO */) 3 - One to-do that is now done. ;-) Patch (including the change be

Re: [Wireshark-dev] redback dissector update vs current svn

2006-09-12 Thread ronnie sahlberg
checked in by the way, it would be nice with a small wiki page for this protocol and possible an example capture for those of us not familiar with this protocol or product On 9/6/06, Florian Lohoff wrote: > > Hi, > after using the redback dissector again i found some more protocol > types: >

Re: [Wireshark-dev] Further HTTP woes...

2006-09-12 Thread ronnie sahlberg
checked in On 9/11/06, Bryant Eastham <[EMAIL PROTECTED]> wrote: > Thanks. I have verified that it works. > > Compiling under Windows (cygwin, actually) I had to manually build the > codecs/codecs.lib library. > > Also, there is still an outstanding issue regarding the default use of > the "media"

Re: [Wireshark-dev] Proposed change to packet-tcp (tcp_dissect_pdus)

2006-09-12 Thread Peter Johansson
For this protocol it is sufficient to know the source port only. Hence it is sufficient to have two different calls to tcp_dissect_pdus with different input functions to the get_pdu_len() function pointer based on the source port in the pinfo structure at hand there. Thank you for pointing this

Re: [Wireshark-dev] Fwd: new dissector for IBM Communication Tools

2006-09-12 Thread ronnie sahlberg
Toralf, Please also change the // comments to /* ones. Please make it hauristic and test if it looks like ICT and return TRUE if it does and is dissected or FALSE if it doesnt look like this protocol and the packet should be given to some other dissector instead. Since this protocol appears to b

Re: [Wireshark-dev] need urgent info on 802.11n feature development

2006-09-12 Thread ronnie sahlberg
On 9/12/06, joyjit mullick <[EMAIL PROTECTED]> wrote: > hi, > i would like to get an idea of the time around which the 802.11n frames(as > according to 802.11n-D1.0.pdf ) decoding support > will be fully implemented in ethereal. > please give me a definite time frame or the relase in which it is ta

[Wireshark-dev] UPnP protocol questions about wireshark

2006-09-12 Thread Niu Mingqiang
Hi, I am sorry to trouble you. Now I am trying to analyze the UPnP protocols with wireshark. UPnP protocols include SSDP, GENA and SOAP, which are over HTTP, while HTTP is over TCP or UDP. The problem is that these protocols are not based on a known port, that is, when the UPnP packets come f

Re: [Wireshark-dev] ESP Patch for Hexadecimal keys

2006-09-12 Thread ronnie sahlberg
Nice. Maybe uploading the example to the other examples on the wiki? I have made some very minor cosmetic changes to the dissector of yours that anders checked in. I also changed it so that the payload inside ah/esp is displayed at the root of the tree. (look at the screenshot at the ESP_preferen

[Wireshark-dev] need urgent info on 802.11n feature development

2006-09-12 Thread joyjit mullick
hi, i would like to get an idea of the time around which the 802.11n frames(as according to 802.11n-D1.0.pdf ) decoding support will be fully implemented in ethereal. please give me a definite time frame or the relase in which it is targeted   and one question i have been an user of ethereal for qu

[Wireshark-dev] Win32: change the install-deps target, so it's creating new dirs instead of putting all into the root source dir?

2006-09-12 Thread Ulf Lamping
Hi List! The current "install-deps" target is used to create a debug environment and will copy things like DLL's into the source dir so you can start a Wireshark there for debugging. In my private nmake file, I'm doing a slightly different approach: I'm creating a whole new dir "DEBUG_GTK1" /

[Wireshark-dev] [patch] Stanag 5066 dissector type 25 s_prim parser's bug

2006-09-12 Thread Taner KURTULUŞ
Hi folks, We think we've found a bug in STANAG 5066 SIS layer dissector. Problem is at S_EXPEDITED_UNIDATA_INDICATION S_Prim's parser and occurs when we receive a U_PDU via expedited unidata channel. Dissector tries to parse first 2 bytes of U_PDU as a header size of type 21 s_prim (S_UNIDATA_IND

Re: [Wireshark-dev] Proposed change to packet-tcp (tcp_dissect_pdus)

2006-09-12 Thread ronnie sahlberg
Is it sufficient to know which tcp port the packet came from in order to decide which protocol it is? If so, you can get this info from the pinfo structure which is available in the tcp_dissect_pdus() fucntion but not passed to the get_pdu_len() helper. Two possibilities: either you can add a

[Wireshark-dev] 0.99.4-SVN-19196 & RTP Stream Analysys Problems

2006-09-12 Thread Keith French
I have just tried this development release and the RTP Analyse Streams seems to be misbehaving.   When an RTP packet is selected using this option, it  does not try & analyse this stream & it's reverse stream, but does all streams in the current trace. In fact it brings up the "Show All Str