[Wireshark-dev] Patch for BACnet (packet-bacapp.c/.h)

2006-10-03 Thread David Richards
Here is a patch for BACnet. It contains numerous changes, most notably: 1) BACnetStatusFlags is bit string, not enum, in NotificationParameters 2) Fixes many places where enclosing context tags were not handled properly. 3) Simplify tag decoding logic. Change to explicit decoding in many

Re: [Wireshark-dev] RTP-MIDI

2006-10-03 Thread Anders Broman \(AL/EAB\)
Hi, Yes why not, but preferedly as a normal dissector not a plugin. An entry to http://wiki.wireshark.org 's protocol pages with a link to the spec and a sample trace would also be nice. Best regards Anders -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf

[Wireshark-dev] Add camel statistics, for counter, and delay time.

2006-10-03 Thread Florent . Drouin
Hello, Please find two new TAP for Camel Statistics. The first one updates counters related to camel operations. It is located in the GSM submenu. The second one , named Camel Service Response Time, gives the time ellapsed between a couple of camel specifics operations. (For example

[Wireshark-dev] Errors in decoder function.

2006-10-03 Thread prashanth joshi
Hi, the following are the statements to manipulate the tvb data in my code:1) void proto_register_gtp(void){ static hf_register_info hf_gtp[] = { { hf_record_type, {" Record Type", "RecordType.val",FT_UINT32, BASE_DEC, NULL,0,"", HFILL }}, ...

[Wireshark-dev] Patch for gtk/capture_dlg.c (Bug 771)

2006-10-03 Thread Florent . Drouin
Hello Could you apply this patch to correct the Bug 771. The patch has been synchronized with SVN19401, and has been tested under linux (not Windows) There are still 2 existing drawbacks: - the menu history is not implemented, so when you reopen the dialog window, you have lost your

[Wireshark-dev] Repost a patch for tap-iostat.c to have new output format

2006-10-03 Thread Florent . Drouin
Hello, I repost a patch to have a new output format for the dates in the statistics. This patch provide new date formats for the statistics generated with tshark. If you are capturing multiple files, you can merge the stats to generate a gnuplot graph.

[Wireshark-dev] Improve Tcap oid management

2006-10-03 Thread Florent . Drouin
Hello, I did improve the OID management in the tcap dissector. Now, when a tcap message is reveived, without upper layer, the ACN is saved in the TCAP context, and can be used for the next messages of the dialogue. It is used only when the upper layer session is opened with Tcap only

Re: [Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-03 Thread ronnie sahlberg
since this uses a ephemeral port number which changes between runs you should not register the dissector to the port itself much better is to once you have detected that port A on host B uses that protocol you create a conversation for host B port A and register the dissector for that particular

Re: [Wireshark-dev] Patch for BACnet (packet-bacapp.c/.h)

2006-10-03 Thread Anders Broman
Checked in. BR Anders -Ursprungligt meddelande- Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För David Richards Skickat: den 3 oktober 2006 10:21 Till: Wireshark developer support list Ämne: [Wireshark-dev] Patch for BACnet (packet-bacapp.c/.h) Here is a patch for BACnet. It

Re: [Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-03 Thread Stephen Fisher
On Wed, Oct 04, 2006 at 01:54:41AM +1000, ronnie sahlberg wrote: since this uses a ephemeral port number which changes between runs you should not register the dissector to the port itself much better is to once you have detected that port A on host B uses that protocol you create a

Re: [Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-03 Thread LEGO
Is it ok to have the preference and register a port (once). What can cause problems is to register a port instead of creating a conversation, think in what would happen if it starts to use ports used by other protocols. On 10/3/06, Stephen Fisher [EMAIL PROTECTED] wrote: On Wed, Oct 04, 2006 at

Re: [Wireshark-dev] Fwd: [Wireshark-commits] rev 19413: /trunk/ /trunk/gtk/: capture_file_dlg.c color_dlg.c win32-file-dlg.c win32-file-dlg.h /trunk/: color_filters.c color_filters.h file.c

2006-10-03 Thread Ulf Lamping
Stephen Fisher wrote: Line 1626 was changed from this: file_color_import_cmd_cb(GtkWidget *w _U_, gpointer data) To this: file_color_import_cmd_cb(GtkWidget *color_filters, gpointer filter_list) Which is causing an error: 'data' undeclared on line 1673 (really 1671):

[Wireshark-dev] Save button removals

2006-10-03 Thread Stephen Fisher
Does the apply button in preferences now also save them? If so, this message should probably be changed to apply your preferences instead of save them: 13:23:22 Warn /home/sfisher/.wireshark/preferences line 1869: No such preference rudp.udp.port (saving your preferences once should

Re: [Wireshark-dev] Save button removals

2006-10-03 Thread Ulf Lamping
Stephen Fisher wrote: Does the apply button in preferences now also save them? It doesn't, but now it does :-) If so, this message should probably be changed to apply your preferences instead of save them: 13:23:22 Warn /home/sfisher/.wireshark/preferences line 1869: No such

Re: [Wireshark-dev] Add camel statistics, for counter, and delay time.

2006-10-03 Thread Anders Broman
Hi, I've checked in the new files but not the makefiles, nor the change to packet-camel-template.c because of problems to build with MSVC6: Linking tshark.exe link @C:\DOCUME~1\GAREN~1\LOKALA~1\Temp\nmc00492. tap-camelsrt.obj : error LNK2001: unresolved external symbol _gcamel_StatSRT

Re: [Wireshark-dev] Wireshark UI

2006-10-03 Thread Ulf Lamping
Steven J Schaeffer wrote: I see that you are making a bunch of much needed updates to the dialogs, good for you. Hopefully good for some one else as well ;-) FWIW, I'm thinking that the Coloring Rules more appropriately belongs on the Prefs dialog than on the View menu. Prefs dialog?!? Do

Re: [Wireshark-dev] Save button removals

2006-10-03 Thread Guy Harris
On Oct 3, 2006, at 2:27 PM, Ulf Lamping wrote: Stephen Fisher wrote: Does the apply button in preferences now also save them? It doesn't, but now it does :-) So if I want to change a protocol preference and *not* have the change (or any other changes I've made) saved to a file, how do I do

Re: [Wireshark-dev] Save button removals

2006-10-03 Thread Ulf Lamping
Guy Harris wrote: So if I want to change a protocol preference and *not* have the change (or any other changes I've made) saved to a file, how do I do that? First of all, that's not the thing most users of Wireshark are require / demand - belief me. Discussed with many person about WS -

Re: [Wireshark-dev] Add camel statistics, for counter, and delay time.

2006-10-03 Thread Ulf Lamping
Anders Broman wrote: Hi, I've checked in the new files but not the makefiles, nor the change to packet-camel-template.c because of problems to build with MSVC6: Linking tshark.exe link @C:\DOCUME~1\GAREN~1\LOKALA~1\Temp\nmc00492. tap-camelsrt.obj : error LNK2001: unresolved external

[Wireshark-dev] Trace available of SCSI-OSD

2006-10-03 Thread Joe Breher
After a license review, I am quite sure I am authorized to disseminate some example traces of SCSI-OSD. To this end, I have added a short example trace to the SampeCaptures, in the SAN-related protocol family section. Look for scsi-osd-example-001.pcap. Enjoy. Joe Breher wrote: Ronnie -