Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Graham Bloice
On 11 December 2013 07:38, Joerg Mayer jma...@loplof.de wrote: Hello, I'd like to move the plugins/ directory into epan/dissectors/. They provide just more dissectors and depend on epan anyway. Are there good reasons not to do that move? And could some of those plugins not be made into

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Martin Kaiser
Thus wrote Joerg Mayer (jma...@loplof.de): I'd like to move the plugins/ directory into epan/dissectors/. They provide just more dissectors and depend on epan anyway. Are there good reasons not to do that move? Couldn't we have plugins for fileformats (wiretap) or taps as well?

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Alexis La Goutte
Also there is a reason to kept HAVE_PLUGINS ? (There is some people build wireshark without plugins ?) On Wed, Dec 11, 2013 at 9:25 AM, Martin Kaiser li...@kaiser.cx wrote: Thus wrote Joerg Mayer (jma...@loplof.de): I'd like to move the plugins/ directory into epan/dissectors/. They

Re: [Wireshark-dev] Mysterious Fuzz Failure

2013-12-11 Thread Pascal Quantin
2013/12/11 Evan Huus eapa...@gmail.com https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9406 Can anybody at all reproduce this one? Gerald, any thoughts on what fuzzbot-specific config might be causing this? Hi Evan, I failed to reproduce it both on Linux x64 and Windows.

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Edwin Groothuis
Hi, As long as the plugins are buildable by themselves without having to link a huge library and then into an executable, no objections from me. But when I'm making something new and there are multiple compile and run events per minute, having to wait for this library to be rebuild and linked,

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Anders Broman
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Graham Bloice Sent: den 11 december 2013 09:24 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/ On 11 December 2013 07:38, Joerg

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Roland Knall
Could I once again suggest sub-directories for all dissectors, as long as we are on the subject of changing epan/dissectors?. It would make development easier. I would like to change the openSAFETY plugin to a epan/dissectors/opensafety sub-directory regard, Roland On Wed, Dec 11, 2013 at 10:57

Re: [Wireshark-dev] Error while installing wireshark 1.10.3

2013-12-11 Thread Guy Harris
On Dec 6, 2013, at 6:41 AM, Sreejith M M sreejith...@gmail.com wrote: Looks like some problem with rpm creation. The problem appears to be that the RPM was created with the dumpcap program having some file capabilities set, and was unpacked into an NFS-mounted directory, which means that the

[Wireshark-dev] tools/make-dissector-reg.py

2013-12-11 Thread Gisle Vanem
I saw the recent change to 'tools/make-dissector-reg.py' to allow reading list of files from a file; the argument dissectorsinfile. I find this a bit awkward. Isn't it better to use the more familiar response-file syntax? So the command to generate register.c would be something like:

Re: [Wireshark-dev] tools/make-dissector-reg.py

2013-12-11 Thread Graham Bloice
On 11 December 2013 13:10, Gisle Vanem gva...@yahoo.no wrote: I saw the recent change to 'tools/make-dissector-reg.py' to allow reading list of files from a file; the argument dissectorsinfile. I find this a bit awkward. Isn't it better to use the more familiar response-file syntax? So the

Re: [Wireshark-dev] tools/make-dissector-reg.py

2013-12-11 Thread Gisle Vanem
Graham Bloice graham.blo...@trihedral.com wrote: and maybe due to my CMake ineptness it turned out to be one file per line. How fast will CMake generate such a temp-file? There are approx 1100 packet-*.c files. I figured this macro does it: MACRO(REGISTER_DISSECTOR_FILES _outputfile

Re: [Wireshark-dev] Error while installing wireshark 1.10.3

2013-12-11 Thread Vishnu Bhatt
I compiled the whole code with: ./configure --prefix=/home2/rahul.rohit/1.10.3._standalone_ra/install --disable-setcap-install --enable-setuid-install --with-libcap --with-dumpcap-group=rncpet But after installing the rpm, the machine is not able to find Wireshark (maybe it's not properly

Re: [Wireshark-dev] Error while installing wireshark 1.10.3

2013-12-11 Thread Christopher Maynard
Vishnu Bhatt vishnu.bhatt@... writes: I compiled the whole code with: ./configure --prefix=/home2/rahul.rohit/1.10.3._standalone_ra/install --disable-setcap-install --enable-setuid-install --with-libcap --with-dumpcap-group=rncpet But after installing the rpm, the machine is not able to

[Wireshark-dev] Mac Mavericks install

2013-12-11 Thread Keith Gunn
HI, I’m experiencing some difficulty installing. When I first downloaded your package and read the installation notes, this computer didn’t have XQuartz on it. So, I finished an installation, but got your message that the latest xQuartz was required. No problem, I downloaded it, and when

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Joerg Mayer
On Wed, Dec 11, 2013 at 08:38:30AM +0100, Joerg Mayer wrote: I'd like to move the plugins/ directory into epan/dissectors/. They provide just more dissectors and depend on epan anyway. Are there good reasons not to do that move? Replying to self after reading the current state of feedback. OK,

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Jakub Zawadzki
On Wed, Dec 11, 2013 at 09:17:00PM +0100, Joerg Mayer wrote: On Wed, Dec 11, 2013 at 08:38:30AM +0100, Joerg Mayer wrote: I'd like to move the plugins/ directory into epan/dissectors/. They provide just more dissectors and depend on epan anyway. Are there good reasons not to do that move?

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Guy Harris
On Dec 11, 2013, at 1:07 AM, Alexis La Goutte alexis.lagou...@gmail.com wrote: Also there is a reason to kept HAVE_PLUGINS ? (There is some people build wireshark without plugins ?) Wireshark is built without plugin support if either 1) GLib doesn't provide dynamic-loading support

[Wireshark-dev] Val_to_str as a macro

2013-12-11 Thread Evan Huus
I've been exploring a few options for the val_to_str function and wmem. One of the tangential things I've been trying to achieve is to make it into a macro so that the compiler will catch format-string mismatches (which have been a source of bugs in the past). This is easy to do inefficiently:

Re: [Wireshark-dev] Val_to_str as a macro

2013-12-11 Thread Jakub Zawadzki
Hi, On Wed, Dec 11, 2013 at 05:22:31PM -0500, Evan Huus wrote: I've been exploring a few options for the val_to_str function and wmem. One of the tangential things I've been trying to achieve is to make it into a macro so that the compiler will catch format-string mismatches (which have been

Re: [Wireshark-dev] Val_to_str as a macro

2013-12-11 Thread Evan Huus
On Wed, Dec 11, 2013 at 5:40 PM, Jakub Zawadzki darkjames...@darkjames.pl wrote: Hi, On Wed, Dec 11, 2013 at 05:22:31PM -0500, Evan Huus wrote: I've been exploring a few options for the val_to_str function and wmem. One of the tangential things I've been trying to achieve is to make it into

Re: [Wireshark-dev] Error while installing wireshark 1.10.3

2013-12-11 Thread Guy Harris
On Dec 11, 2013, at 7:10 AM, Christopher Maynard christopher.mayn...@gtech.com wrote: Before running autogen.sh, did you modify packaging/rpm/SPECS/wireshark.spec.in to meet your needs? Those are the options that matter when creating the rpm. Should %bcond_without gtk2

Re: [Wireshark-dev] Val_to_str as a macro

2013-12-11 Thread Dirk Jagdmann
the original function. I can use a single temp global, but that's just ugly and won't work if we ever do multithreading. It may be ugly, but using thread local storage for that global variable will make it safe for multi-threading. -- --- Dirk Jagdmann http://cubic.org/~doj -