Re: [Wireshark-dev] [Wireshark-commits] rev 54310: /trunk/epan/wslua/ /trunk/epan/wslua/: wslua_tvb.c

2013-12-20 Thread Stig Bjørlykke
On Fri, Dec 20, 2013 at 9:29 PM, wrote: > Add new string_enc and stringz_enc methods that take an encoding value > as an argument, just as the add_packet_field method for a tree does. Why not just add an optional "encoding" argument to the existing string and stringz, whith the default value "

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Michael Lum
Yes! ;) Michael Lum (michael@starsolutions.com) | STAR SOLUTIONS | Principal Software Engineer 4600 Jacombs Road, Richmond BC, Canada V6V 3B1 | +1.604.303.2315 > -Original Message- > From: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun...@wireshark.org] On Behalf

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Jakub Zawadzki
On Fri, Dec 20, 2013 at 11:59:20AM -0800, Michael Lum wrote: > Okay, thanks for the responses. > > I started to make some changes but its probably more than I have time for. > > But in case I pick it up I had a question about the ENC_ values from proto.h. > > This is what I have from SVN: > > #

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Michael Lum
Okay, thanks for the responses. I started to make some changes but its probably more than I have time for. But in case I pick it up I had a question about the ENC_ values from proto.h. This is what I have from SVN: #define ENC_CHARENCODING_MASK 0x7FFE /* mask out byte-order bits */ #

Re: [Wireshark-dev] Change of decoding for Airopeek/Omnipeek 802.11 header with Cisco APs

2013-12-20 Thread Alexis La Goutte
Hi, It is possible to create a bug in bugtracker and attach pcap samples (and the screen in OmniPeek) ? On Fri, Dec 20, 2013 at 3:44 PM, Emburey Samrex Edward -X (emedward - EMBED UR SYSTEMS at Cisco) wrote: > Hi Guy, Alexis, > > > > I think, I should have mentioned this earlier. > > > > Ther

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Guy Harris
On Dec 20, 2013, at 11:24 AM, Jakub Zawadzki wrote: > In euc-kr [1] you can see that it's using ksc5601_to_ucs4() which can be find > in ksc5601.h [2]. > ksc5601_to_ucs4() is using convertation tables: __ksc5601_hangul_to_ucs, > __ksc5601_hanja_to_ucs, __ksc5601_sym_to_ucs > from ksc5601.c [3]

Re: [Wireshark-dev] Being a mentor from Facebook Open Academy

2013-12-20 Thread Alexis La Goutte
Hi, There is also Wireshark Qt project... (Need help to move Wireshark to Qt...) On Fri, Dec 20, 2013 at 7:01 PM, Richard Sharpe wrote: > Another thing that might be useful is: > > 1. Take a capture of say SMB1 or SMB2 from Samba > > 2. Take a level 10 log from Samba > > 3. In Eclipse interle

Re: [Wireshark-dev] Change of decoding for Airopeek/Omnipeek 802.11 header with Cisco APs

2013-12-20 Thread Guy Harris
On Dec 20, 2013, at 6:44 AM, "Emburey Samrex Edward -X (emedward - EMBED UR SYSTEMS at Cisco)" wrote: > I think, I should have mentioned this earlier. Yes. > There does exist two different headers: a 20-byte (legacy) and a 55-byte > (with additional, 802.11n support) The legacy header does

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Jakub Zawadzki
On Fri, Dec 20, 2013 at 10:46:29AM -0800, Michael Lum wrote: > Is there a goal to remove g_iconv calls from Wireshark. Nope, it's not a goal (at least not for me). Goals are two: 1/ To support more encodings in epan, which will make it easier for people to use 2/ Thanks to 1/ more calls can be

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Guy Harris
On Dec 20, 2013, at 10:46 AM, Michael Lum wrote: > Is there a goal to remove g_iconv calls from Wireshark. I'd certainly like to do so to the maximum extent possible. I would like to have *all* code set handling done by using ENC_ arguments to proto_tree_add_item() or tvb_get_string_enc().

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Pascal Quantin
Hi Michael, 2013/12/20 Michael Lum > Is there a goal to remove g_iconv calls from Wireshark. > > I notice the GSM SMS dissector has been changed. > > I'm working on an ANSI SMS change but the replacement of g_iconv is not > straight forward. > > I checked charsets.c/.h and there are two encodin

[Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Michael Lum
Is there a goal to remove g_iconv calls from Wireshark. I notice the GSM SMS dissector has been changed. I'm working on an ANSI SMS change but the replacement of g_iconv is not straight forward. I checked charsets.c/.h and there are two encodings that are not available that are used in the ANS

Re: [Wireshark-dev] Compilation failure on Fedora 20 - GTK3 issues

2013-12-20 Thread Kaul
wireshark-qt compiled fine and looks great. Bubye GTK. Thanks, Y. On Fri, Dec 20, 2013 at 7:46 PM, Joerg Mayer wrote: > As Wireshark development doesn't really care about the compatibility with > future GTK versions (we are migrating to Qt) I have disabled that warning > for cmake builds. So ei

Re: [Wireshark-dev] Being a mentor from Facebook Open Academy

2013-12-20 Thread Richard Sharpe
Another thing that might be useful is: 1. Take a capture of say SMB1 or SMB2 from Samba 2. Take a level 10 log from Samba 3. In Eclipse interleave the info and then allow a user to click on a packet and using the log file entry closest to it, go to the code that handles that packet or generated

Re: [Wireshark-dev] Change of decoding for Airopeek/Omnipeek 802.11 header with Cisco APs (forw)

2013-12-20 Thread Joerg Mayer
Hit the wrong reply button that did not include the list... - Forwarded message from Joerg Mayer - Date: Fri, 20 Dec 2013 11:39:26 +0100 From: Joerg Mayer To: Alexis La Goutte Subject: Re: [Wireshark-dev] Change of decoding for Airopeek/Omnipeek 802.11 header with Cisco APs In

Re: [Wireshark-dev] Compilation failure on Fedora 20 - GTK3 issues

2013-12-20 Thread Joerg Mayer
As Wireshark development doesn't really care about the compatibility with future GTK versions (we are migrating to Qt) I have disabled that warning for cmake builds. So either apply a similar change to the autotools build or use cmake to build (see README.cmake). Ciao Jöarg On Fri, Dec 20, 2

Re: [Wireshark-dev] FT_BYTES hf with len==0

2013-12-20 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): > > > 5392 label_fill(label_str, 0, hfinfo, > > > 5393 (bytes) ? bytes_to_str(bytes, > > > fvalue_length(&fi->value)) : ""); > > > 5394 break; > > > It'd be good to make them consistent, allow empty b

Re: [Wireshark-dev] Being a mentor from Facebook Open Academy

2013-12-20 Thread Richard Sharpe
On Thu, Dec 19, 2013 at 11:23 PM, Jay Borenstein wrote: > Hello, > > I am Jay Borenstein from Stanford's Computer Science Department. I'm > teaching software engineering through Facebook's generosity to hundreds of > top international computer science students in collaboration with open > source

Re: [Wireshark-dev] FT_BYTES hf with len==0

2013-12-20 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): > Thus wrote Jakub Zawadzki (darkjames...@darkjames.pl): > > proto_item_fill_label() allows empty bytes: > > 5389 case FT_BYTES: > > 5390 case FT_UINT_BYTES: > > 5391 bytes = (guint8 *)fvalue_get(&fi->value); > > 5392 la

Re: [Wireshark-dev] Compilation failure on Fedora 20 - GTK3 issues

2013-12-20 Thread Peter Wu
Hi Kaul, On Friday 20 December 2013 13:20:37 Kaul wrote: > Doesn't happen on a fully updated Fedora 19, just on my Fedora 20: > CC libgtkui_a-addr_resolution_dlg.o > In file included from /usr/include/gtk-3.0/gtk/gtkapplication.h:27:0, > from /usr/include/gtk-3.0/gtk/gtkwi

[Wireshark-dev] Compilation failure on Fedora 20 - GTK3 issues

2013-12-20 Thread Kaul
Doesn't happen on a fully updated Fedora 19, just on my Fedora 20: CC libgtkui_a-addr_resolution_dlg.o In file included from /usr/include/gtk-3.0/gtk/gtkapplication.h:27:0, from /usr/include/gtk-3.0/gtk/gtkwindow.h:33, from /usr/include/gtk-3.0/gtk/gtkdialo

Re: [Wireshark-dev] Change of decoding for Airopeek/Omnipeek 802.11 header with Cisco APs

2013-12-20 Thread Guy Harris
On Dec 20, 2013, at 12:03 AM, Alexis La Goutte wrote: > Do you have a packet of Joerg ? No, but I asked Joerg if he still has one. > Because in the screenshot, there is "Magic Value" may be the value is > different It might be, but I wouldn't be surprised to find that the magic number i

Re: [Wireshark-dev] Git + Gerrit: next steps

2013-12-20 Thread Dario Lombardo
On Thu, Dec 19, 2013 at 8:51 PM, Gerald Combs wrote: > BTW, I *might* be able to have Gerrit's SSH daemon listen on port 22 > instead of 29418. Would this be useful? > In testing/lab/home networks access to outside is normally open (or can be opened). That means that port 80, 22, 443 or XXX is a

Re: [Wireshark-dev] Change of decoding for Airopeek/Omnipeek 802.11 header with Cisco APs

2013-12-20 Thread Alexis La Goutte
Hi Guy, Do you have a packet of Joerg ? Because in the screenshot, there is "Magic Value" may be the value is different (there is also a type field may be the other field is different if type have other value) Regards, On Fri, Dec 20, 2013 at 2:03 AM, Guy Harris wrote: > > On Dec 19, 2013