Re: [Wireshark-dev] cmake giving options the compiler does not understand

On Thu, Jan 02, 2014 at 04:30:14PM -0800, Guy Harris wrote: > Are we really encountering a case where the C compiler accepts > -Wshorten-64-to-32 but the C++ compiler doesn't, or *vice versa*? Or are we > encountering a case where *neither* compiler accepts it, but CMake isn't > detecting that?

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On Jan 2, 2014, at 4:21 PM, Joerg Mayer wrote: > On Thu, Jan 02, 2014 at 03:16:17PM -0800, Guy Harris wrote: > >> But, if that's the case, was it cached when a compiler that *does* support >> -Wshorten-64-to-32 was used, and then a *different* compiler was used? >> (Building in a directory s

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On Thu, Jan 02, 2014 at 03:16:17PM -0800, Guy Harris wrote: > > On Jan 2, 2014, at 2:44 PM, Jeff Morriss wrote: > > > Cmake has that function which I listed that is supposed to do it for us but > > it doesn't seem to work (at least for me or at least not all the time). > > Given that at least

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On Jan 2, 2014, at 2:44 PM, Jeff Morriss wrote: > Cmake has that function which I listed that is supposed to do it for us but > it doesn't seem to work (at least for me or at least not all the time). Given that at least two people have said that blowing away the build directory sometimes fixe

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On 01/02/14 17:15, Guy Harris wrote: On Jan 2, 2014, at 1:55 PM, Jeff Morriss wrote: On 01/02/14 16:34, Alexis La Goutte wrote: Hi Jeff, I have also some time the some error message... Only sometimes? I had to take that option out of CMakeLists.txt to get it compile. With autotools, -

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On 01/02/14 17:05, Peter Wu wrote: Hi, On Thursday 02 January 2014 16:02:08 Jeff Morriss wrote: It took me a while to get my cmake build going again today; one of the reasons was that the builds would immediately fail with: > cc: error: unrecognized command line option -Wshorten-64-to-32 As

Re: [Wireshark-dev] cmake giving options the compiler does not understand

Hi, On Thursday 02 January 2014 16:02:08 Jeff Morriss wrote: > It took me a while to get my cmake build going again today; one of the > reasons was that the builds would immediately fail with: > > > cc: error: unrecognized command line option -Wshorten-64-to-32 > > As far as I can tell the pro

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On Jan 2, 2014, at 1:55 PM, Jeff Morriss wrote: > On 01/02/14 16:34, Alexis La Goutte wrote: >> Hi Jeff, >> >> I have also some time the some error message... > > Only sometimes? I had to take that option out of CMakeLists.txt to get it > compile. > >> With autotools, -Wshorten-64-to-32 is

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On 01/02/14 16:34, Alexis La Goutte wrote: Hi Jeff, I have also some time the some error message... Only sometimes? I had to take that option out of CMakeLists.txt to get it compile. With autotools, -Wshorten-64-to-32 is limited to only C... True but my problem is with C compiler (it do

Re: [Wireshark-dev] cmake giving options the compiler does not understand

On Jan 2, 2014, at 1:34 PM, Alexis La Goutte wrote: > I have also some time the some error message... > > With autotools, -Wshorten-64-to-32 is limited to only C... Because, to quote the comment in configure.ac: # The Qt headers generate a ton of shortening errors on 64-bit systems

Re: [Wireshark-dev] cmake giving options the compiler does not understand

Hi Jeff, I have also some time the some error message... With autotools, -Wshorten-64-to-32 is limited to only C... Regards, On Thu, Jan 2, 2014 at 10:02 PM, Jeff Morriss wrote: > Hi folks, > > It took me a while to get my cmake build going again today; one of the > reasons was that the build

[Wireshark-dev] cmake giving options the compiler does not understand

Hi folks, It took me a while to get my cmake build going again today; one of the reasons was that the builds would immediately fail with: > cc: error: unrecognized command line option -Wshorten-64-to-32 As far as I can tell the problem is simply that check_c_compiler_flag() isn't working in

Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u

Some remarks and clarifications: I tested with a fully installed wireshark/qtshark. On Thu, Jan 02, 2014 at 02:18:59PM -0500, Jeff Morriss wrote: > >- The plugins list is empty (maybe something wrong with my setup?) > > > > No i have the some issue... (with Linux and Windows) > >(On my l

Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u

On 01/02/14 14:57, Alexis La Goutte wrote: On Thu, Jan 2, 2014 at 8:18 PM, Jeff Morriss mailto:jeff.morriss...@gmail.com>> wrote: On 01/02/14 13:52, Alexis La Goutte wrote: - The plugins list is empty (maybe something wrong with my setup?) No i have the some

Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u

On Thu, Jan 2, 2014 at 8:18 PM, Jeff Morriss wrote: > On 01/02/14 13:52, Alexis La Goutte wrote: > >> >> >> >> On Thu, Jan 2, 2014 at 7:12 PM, Joerg Mayer > > wrote: >> >> On Thu, Jan 02, 2014 at 05:04:10PM +, alagou...@wireshark.org >>

Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u

On 01/02/14 13:52, Alexis La Goutte wrote: On Thu, Jan 2, 2014 at 7:12 PM, Joerg Mayer mailto:jma...@loplof.de>> wrote: On Thu, Jan 02, 2014 at 05:04:10PM +, alagou...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?v

Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u

On Thu, Jan 2, 2014 at 7:12 PM, Joerg Mayer wrote: > On Thu, Jan 02, 2014 at 05:04:10PM +, alagou...@wireshark.org wrote: > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54557 > > > > User: alagoutte > > Date: 2014/01/02 05:04 PM > > > > Log: > > Add About window for Wir

Re: [Wireshark-dev] [Wireshark-commits] rev 54557: /trunk/ /trunk/image/: about.qrc /trunk/ui/qt/: CMakeLists.txt Makefile.am Makefile.common QtShark.pro about_dialog.cpp about_dialog.h about_dialog.u

On Thu, Jan 02, 2014 at 05:04:10PM +, alagou...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54557 > > User: alagoutte > Date: 2014/01/02 05:04 PM > > Log: > Add About window for Wireshark Qt Great! Just some nitpicks: - The plugins list is empty (

Re: [Wireshark-dev] [Wireshark-commits] rev 54559: /trunk/ /trunk/packaging/nsis/: wireshark.nsi /trunk/plugins/: Makefile.am Makefile.nmake /trunk/: CMakeLists.txt Makefile.am

On Thu, Jan 02, 2014 at 05:47:34PM +, etx...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54559 > > User: etxrab > Date: 2014/01/02 05:47 PM > > Log: > Stop building and distributing the asn1 plugin. I bleleve it to be obsolete. This should be adde

Re: [Wireshark-dev] Compile warning turning error in wiretap/camins.c

On Thu, Jan 02, 2014 at 03:46:33PM +0100, Joerg Mayer wrote: > /home/jmayer/work/wireshark/svn/trunk/wiretap/camins.c: In function > ‘read_block’: > /home/jmayer/work/wireshark/svn/trunk/wiretap/camins.c:118:5: error: passing > argument 3 of ‘file_read’ from incompatible pointer type [-Werror] >

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 9607] TFShark (Terminal FileShark)

Although I have to say I kinda liked Michal's suggestion of Omnivoroushark (or something similar with "omni") if fileshark doesn't work out. My only complaint with Omnivoroushark is that we want to separate capture files (Wireshark) from non-capture (fileshark) files, so it's not really "omni"

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 9607] TFShark (Terminal FileShark)

On Mon, Dec 30, 2013 at 02:20:09PM +, bugzilla-dae...@wireshark.org wrote: > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9607 > > Michael Mann changed: > >What|Removed |Added > ---

[Wireshark-dev] Compile warning turning error in wiretap/camins.c

/home/jmayer/work/wireshark/svn/trunk/wiretap/camins.c: In function ‘read_block’: /home/jmayer/work/wireshark/svn/trunk/wiretap/camins.c:118:5: error: passing argument 3 of ‘file_read’ from incompatible pointer type [-Werror] bytes_read = file_read((void *)buf, buf_len, fh); ^ In file i

Re: [Wireshark-dev] Git + Gerrit: next steps

On Wed, Jan 01, 2014 at 02:11:43PM -0800, Gerald Combs wrote: > I was able to shoehorn openid-selector > (http://code.google.com/p/openid-selector/) into the login page on > test.code.wireshark.org. If you have an account at one of the top > providers listed at http://meta.stackoverflow.com/a/14787

Re: [Wireshark-dev] [Wireshark-commits] rev 54526: /trunk/wiretap/ /trunk/wiretap/: mpeg.c

On Tue, Dec 31, 2013 at 11:49:09PM +, g...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54526 > > User: guy > Date: 2013/12/31 11:49 PM > > Log: > Back out a change so that we can check it in again with the correct > commit message. As long as we