Re: [Wireshark-dev] proto_tree_add_subtree[_format]

2014-06-24 Thread Alexis La Goutte
On Mon, Jun 23, 2014 at 12:21 AM, wrote: > In an effort to further remove proto_tree_add_text calls from the Wireshark > source, I've created proto_tree_add_subtree and > proto_tree_add_subtree_format. The use case is to combine > proto_tree_add_text + proto_item_add_subtree into a single call w

Re: [Wireshark-dev] wiretap/AUTHORS?

2014-06-24 Thread Evan Huus
I would merge it with the main AUTHORS file (if there are any names different) and remove it. On Tue, Jun 24, 2014 at 10:13 PM, Jeff Morriss wrote: > I just noticed that there's an AUTHORS file in wiretap/. It looks old and > significantly incomplete/out of date. > > Should we keep it or just

[Wireshark-dev] wiretap/AUTHORS?

2014-06-24 Thread Jeff Morriss
I just noticed that there's an AUTHORS file in wiretap/. It looks old and significantly incomplete/out of date. Should we keep it or just remove it? I suppose it was initially created on the theory that wiretap might be a standalone product. __

[Wireshark-dev] CMake doesn't create a libui.lib or libuicli.lib

2014-06-24 Thread Graham Bloice
The Windows nmake build creates a libui.lib in the ui directory and a libuicli.lib that is linked into all interested executables, but the CMake build just compiles the same source files multiple times into each target directory, e.g. tap-expert.obj is in tshark.dir\RelWithDebInfo and tfshark.dir\R

Re: [Wireshark-dev] Packaging .dlls from Qt 5.2 on Windows?

2014-06-24 Thread Graham Bloice
On 24 June 2014 16:40, hsivank wrote: > Hello, > > Do you plan to make a solution based on cmake + cpack + nsis ? > > There are two interesting module : InstallRequiredSystemLibraries and > fixup_bundle from BundleUtilities ( > http://www.cmake.org/Wiki/BundleUtilitiesExample) > > It works pretty

Re: [Wireshark-dev] Packaging .dlls from Qt 5.2 on Windows?

2014-06-24 Thread Graham Bloice
On 24 June 2014 16:26, Anders Broman wrote: > > Den 24 jun 2014 16:49 skrev "Graham Bloice" : > > > > > On 24 June 2014 15:41, Anders Broman wrote: > >> > >> Hi, > >> > >> I think with Qt5.2 there is more dlls and new subdirectories to be > added to the NSIS installer – anyone looking into that?

Re: [Wireshark-dev] Packaging .dlls from Qt 5.2 on Windows?

2014-06-24 Thread hsivank
Hello, Do you plan to make a solution based on cmake + cpack + nsis ? There are two interesting module : InstallRequiredSystemLibraries and fixup_bundle from BundleUtilities (http://www.cmake.org/Wiki/BundleUtilitiesExample) It works pretty well for me with Qt5.2 / Qt5.3 Hsivank Le 24 juin

[Wireshark-dev] DCERPC generated files

2014-06-24 Thread mmann78
To the discussion on "generated" source files - I still can't build the DCERPC files on Windows (I blame Yapp, but it could also be ignorance). It would be GREAT if the build magicians could fix that. However, thanks to Evan at Sharkfest, I now have a lubuntu setup that I am trying to learn.

Re: [Wireshark-dev] [Wireshark-commits] master 9079e3a: Cheat and try to fix the generated file manually.

2014-06-24 Thread Anders Broman
Den 24 jun 2014 16:54 skrev "Alexis La Goutte" : > > On Mon, Jun 23, 2014 at 10:32 PM, Pascal Quantin > wrote: > > Hi all, > > > > Le 23/06/2014 22:22, Jakub Zawadzki a écrit : > >> Hello Evan, > >> > >> On Mon, Jun 23, 2014 at 02:10:13PM -0400, Evan Huus wrote: > >>> Storing generated files in so

Re: [Wireshark-dev] Packaging .dlls from Qt 5.2 on Windows?

2014-06-24 Thread Anders Broman
Den 24 jun 2014 16:49 skrev "Graham Bloice" : > > On 24 June 2014 15:41, Anders Broman wrote: >> >> Hi, >> >> I think with Qt5.2 there is more dlls and new subdirectories to be added to the NSIS installer – anyone looking into that? >> >> (MSVC 2012). Check for Qt version needed? (how?) >> >> >> >

Re: [Wireshark-dev] [Wireshark-commits] master 9079e3a: Cheat and try to fix the generated file manually.

2014-06-24 Thread Alexis La Goutte
On Mon, Jun 23, 2014 at 10:32 PM, Pascal Quantin wrote: > Hi all, > > Le 23/06/2014 22:22, Jakub Zawadzki a écrit : >> Hello Evan, >> >> On Mon, Jun 23, 2014 at 02:10:13PM -0400, Evan Huus wrote: >>> Storing generated files in source control makes maintenance and patch >>> review much harder and p

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Alexis La Goutte
Hi Joerg On Tue, Jun 24, 2014 at 5:26 AM, Joerg Mayer wrote: > On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: >> > >> So perhaps what we should do is: >> > >> >> > >> not check generated code into Git; >> > >> >> > >> put all generated code into the source tarballs. >

Re: [Wireshark-dev] Packaging .dlls from Qt 5.2 on Windows?

2014-06-24 Thread Graham Bloice
On 24 June 2014 15:41, Anders Broman wrote: > Hi, > > I think with Qt5.2 there is more dlls and new subdirectories to be added > to the NSIS installer – anyone looking into that? > > (MSVC 2012). Check for Qt version needed? (how?) > > > > > I don't know for sure about 5.2, but 5.3 definitely do

[Wireshark-dev] Packaging .dlls from Qt 5.2 on Windows?

2014-06-24 Thread Anders Broman
Hi, I think with Qt5.2 there is more dlls and new subdirectories to be added to the NSIS installer - anyone looking into that? (MSVC 2012). Check for Qt version needed? (how?) Regards Anders ___ Sent via:Wireshark-dev mai

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Anders Broman
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Peter Wu Sent: den 24 juni 2014 16:22 To: wireshark-dev@wireshark.org; bal...@balintreczey.hu Subject: Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was:

[Wireshark-dev] MAKEDIR NSIS packaging issue with Wireshark 1.10.8

2014-06-24 Thread Ben Burwell
Hello, When trying to create a package using NSIS, I've run into an issue where $MAKEDIR contains spaces (C:\Program Files (x86)\...), which does not seem to be handled correctly. I've found this bug report, which is nearly two years old: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=787

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Peter Wu
On Tuesday 24 June 2014 15:42:38 Bálint Réczey wrote: > 2014-06-24 5:26 GMT+02:00 Joerg Mayer : > > On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: > >> > >> So perhaps what we should do is: > >> > >> > >> > >> not check generated code into Git; > +1 +1 > >> > >> > >> > >>

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Bálint Réczey
2014-06-24 5:26 GMT+02:00 Joerg Mayer : > On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: >> > >> So perhaps what we should do is: >> > >> >> > >> not check generated code into Git; +1 >> > >> >> > >> put all generated code into the source tarballs. > > +2 How about rele

Re: [Wireshark-dev] MAKEDIR NSIS packaging issue with Wireshark 1.10.8

2014-06-24 Thread Graham Bloice
On 24 June 2014 14:07, Ben Burwell wrote: > Hello, > > When trying to create a package using NSIS, I've run into an issue where > $MAKEDIR contains spaces (C:\Program Files (x86)\...), which does not seem > to be handled correctly. > > I've found this bug report, which is nearly two years old: >

[Wireshark-dev] MAKEDIR NSIS packaging issue with Wireshark 1.10.8

2014-06-24 Thread Ben Burwell
Hello, When trying to create a package using NSIS, I've run into an issue where $MAKEDIR contains spaces (C:\Program Files (x86)\...), which does not seem to be handled correctly. I've found this bug report, which is nearly two years old: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=787