On Mon, Jun 23, 2014 at 12:21 AM, mman...@netscape.net wrote:
In an effort to further remove proto_tree_add_text calls from the Wireshark
source, I've created proto_tree_add_subtree and
proto_tree_add_subtree_format. The use case is to combine
proto_tree_add_text + proto_item_add_subtree
On Wed, Jun 25, 2014 at 4:44 AM, Evan Huus eapa...@gmail.com wrote:
I would merge it with the main AUTHORS file (if there are any names
different) and remove it.
+1
May be it is time to add also some part of AUTHORS generate by git ?
Like a git shortlog -se (or using other command from
Hello,
How does Wireshark gets the absolute time (system time)? Which APIs are used by
Wireshark to get the absolute time?
Thanks
DISCLAIMER: This message is proprietary to Aricent and is intended solely for
the use of the individual to whom it is addressed. It may contain privileged or
-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Alexis La Goutte
Sent: den 25 juni 2014 08:45
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] proto_tree_add_subtree[_format]
On Mon, Jun 23,
I have no objection to adding G_GNUC_WARN_UNUSED_RESULT to
proto_tree_add_subtree[_format] as it appears to already be used on
proto_item_add_subtree.
The intent of proto_tree_add_subtree[_format] is more directed at trying to
remove proto_tree_add_text calls. The use of proto_tree_add_text
https://code.wireshark.org/review/2645
On 06/24/14 22:44, Evan Huus wrote:
I would merge it with the main AUTHORS file (if there are any names
different) and remove it.
On Tue, Jun 24, 2014 at 10:13 PM, Jeff Morriss
jeff.morriss...@gmail.com mailto:jeff.morriss...@gmail.com wrote:
I
Hi,
Since Pascal's change (TCP: do desegmentation sanity checks for all sub
dissectors types), the whois dissector was starting to throw:
Dissector bug, protocol TCP, in packet 6: epan/dissectors/packet-tcp.c:3953:
failed assertion save_desegment_offset == pinfo-desegment_offset
On Wednesday 25 June 2014 18:32:44 Peter Wu wrote:
Hi,
Since Pascal's change (TCP: do desegmentation sanity checks for all sub
dissectors types), the whois dissector was starting to throw:
Dissector bug, protocol TCP, in packet 6: epan/dissectors/packet-tcp.c:3953:
failed assertion
On Wed, Jun 25, 2014 at 12:54 PM, Evan Huus eapa...@gmail.com wrote:
On Wed, Jun 25, 2014 at 12:32 PM, Peter Wu pe...@lekensteyn.nl wrote:
Hi,
Since Pascal's change (TCP: do desegmentation sanity checks for all sub
dissectors types), the whois dissector was starting to throw:
Dissector
On Wednesday 25 June 2014 12:56:21 Evan Huus wrote:
On Wed, Jun 25, 2014 at 12:54 PM, Evan Huus eapa...@gmail.com wrote:
On Wed, Jun 25, 2014 at 12:32 PM, Peter Wu pe...@lekensteyn.nl wrote:
Hi,
Since Pascal's change (TCP: do desegmentation sanity checks for all sub
dissectors
On Tue, Jun 24, 2014 at 5:34 PM, mman...@netscape.net wrote:
Hi Michael
To the discussion on generated source files - I still can't build the
DCERPC files on Windows (I blame Yapp, but it could also be ignorance). It
would be GREAT if the build magicians could fix that.
However, thanks to
With this change, the comment at wiretap/libpcap.c:769 is stale since it
still references 64KB. Not a major issue, but makes me wonder where else in
the code we've accidentally hardcoded that assumption... I guess we'll find
out :)
On Wed, Jun 25, 2014 at 4:27 PM, Wireshark code review
On 06/25/2014 09:27 PM, Alexis La Goutte wrote:
On Tue, Jun 24, 2014 at 5:34 PM, mman...@netscape.net wrote:
Hi Michael
To the discussion on generated source files - I still can't build the
DCERPC files on Windows (I blame Yapp, but it could also be ignorance). It
would be GREAT if the
I added a new buildslave running Windows 8.1 32-bit. It will replace our
XP buildslave. I also upgraded the Ubuntu buildslave from 12.04 to 14.04.
Next up: Buildbot ↔ Gerrit integration.
___
Sent via:Wireshark-dev mailing
14 matches
Mail list logo