Hi,
Should reassembly be enabled in as many TCP protocols as possible? That
is, is it desirable that TCP-based protocols use dissect_tcp_pdus with
reassembly set to true?
I am asking because I was fixing an error in the return value of the
Plan 9 dissector[1]. While at it, I converted it to use
2014-07-03 12:45 GMT+02:00 Jasper Bongertz jas...@packet-foo.com:
2014-07-02 20:59 GMT+02:00 Jasper Bongertz jas...@packet-foo.com:
Hello,
as promised during Sharkfest, I checked the latest developer builds
for the accuracy of the calculation of initial RTT for TCP
Yes I think tcp_dissect_pdus should be used as much as possible. I even made a
list (at least a few months ago) of potential dissectors that could be
converted:
packet-banana.c
packet-beep.c - maybe
packet-bzr.c
packet-cigi.c
packet-classicstun.c
packet-distcc.c
packet-dtn.c
packet-dtpt.c
On Jul 4, 2014, at 1:36 AM, Peter Wu pe...@lekensteyn.nl wrote:
Should reassembly be enabled in as many TCP protocols as possible?
Yes.
That is, is it desirable that TCP-based protocols use dissect_tcp_pdus with
reassembly set to true?
That is a different question.
TCP-based protocols
The list I provided
(http://www.wireshark.org/lists/wireshark-dev/201407/msg00018.html) follows the
criteria mentioned by Guy. The maybes are where it appeared at first/quick
glance that the contents can be calculated within the first N bytes, but
there was too much logic/code to follow to
