[Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Jakub Zawadzki
Hi, On Sat, Jun 21, 2014 at 10:12:48PM +0200, Jakub Zawadzki wrote: If we're in topic of optimizing 'slower' [de]allocations in common functions: - tvb allocation/deallocation (2.5%, or 3.4% when no filtering) 243,931,671 * ???:tvb_new

Re: [Wireshark-dev] Backport request for proto_tree_add_subtree[_format]

2014-07-11 Thread Peter Wu
On Thursday 10 July 2014 23:54:59 mman...@netscape.net wrote: The proto_tree_add_subtree[_format] code refactoring was very intentionally post-1.12 and I don't see much point to just having the API there without it. Further refactoring of specific dissectors like SSL and DTLS probably won't

[Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Bill Meier
I've been working with the current 'pre-commit' and have noticed the following issues: 1. Using the current pre-commit which calls checkAPIs, etc, it doesn't seem possible to make changes to certain files (e.g., wsgetopt.c) and submit them to Gerrit. - The files fail checkAPIs.pl

Re: [Wireshark-dev] Move to VS2013 for Wireshark 1.99?

2014-07-11 Thread Gerald Combs
On 7/10/14 9:28 AM, Graham Bloice wrote: Folks, Can we consider moving to VS2013 for the windows builds, maybe moving the Win 8.1 buildbot to use it? I need to renew my MSDN subscription but otherwise I have no objections.

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wme...@newsguy.com wrote: I've been working with the current 'pre-commit' and have noticed the following issues: 1. Using the current pre-commit which calls checkAPIs, etc, it doesn't seem possible to make changes to certain files (e.g.,

Re: [Wireshark-dev] [Wireshark-commits] master 599b880: Handle the UTC timestamps in NetMon 2.3 files.

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 4:03 PM, Gerald Combs ger...@wireshark.org wrote: On 7/7/14 9:10 PM, Evan Huus wrote: On Sun, Jul 6, 2014 at 12:59 PM, Alexis La Goutte alexis.lagou...@gmail.com mailto:alexis.lagou...@gmail.com wrote: On Sat, Jul 5, 2014 at 11:49 PM, Evan Huus

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
The biggest win, I think, would be if we can avoid calling free_chain at all because tvbs are always allocated in the right scope and so get freed automatically. I think this would involve touching every place that creates new tvbs backed with glib memory though... I will try and think about this

Re: [Wireshark-dev] [Wireshark-commits] master 599b880: Handle the UTC timestamps in NetMon 2.3 files.

2014-07-11 Thread Gerald Combs
On 7/7/14 9:10 PM, Evan Huus wrote: On Sun, Jul 6, 2014 at 12:59 PM, Alexis La Goutte alexis.lagou...@gmail.com mailto:alexis.lagou...@gmail.com wrote: On Sat, Jul 5, 2014 at 11:49 PM, Evan Huus eapa...@gmail.com It would be nice to have different tags for Refs-Bug and

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wme...@newsguy.com wrote: I've been working with the current 'pre-commit' and have noticed the following issues: 1. Using the current pre-commit which calls checkAPIs, etc, it doesn't seem possible to make changes to certain files (e.g.,

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Bill Meier
On 7/11/2014 3:09 PM, Evan Huus wrote: On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wme...@newsguy.com When you try and push a change to gerrit without a Commit-ID, the error message it returns includes the Commit-ID it's expecting, so you can manually git commit --amend and paste that into the

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Bálint Réczey
Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public. I'm not a fan of implementing custom memory management methods because partly because I highly doubt we can beat jemalloc easily on

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 5:12 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public. I'm not a fan of implementing custom memory management

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Anders Broman
Den 11 jul 2014 23:13 skrev Bálint Réczey bal...@balintreczey.hu: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public Ok I'll see if we can use something from the wiki instead. I'm

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 4:08 PM, Evan Huus eapa...@gmail.com wrote: The biggest win, I think, would be if we can avoid calling free_chain at all because tvbs are always allocated in the right scope and so get freed automatically. I think this would involve touching every place that creates

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 6:07 PM, Anders Broman a.broma...@gmail.com wrote: Den 11 jul 2014 23:13 skrev Bálint Réczey bal...@balintreczey.hu: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Bálint Réczey
Hi Evan, 2014-07-11 23:51 GMT+02:00 Evan Huus eapa...@gmail.com: On Fri, Jul 11, 2014 at 5:12 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Bálint Réczey
2014-07-12 0:07 GMT+02:00 Anders Broman a.broma...@gmail.com: Den 11 jul 2014 23:13 skrev Bálint Réczey bal...@balintreczey.hu: Hi All, Please provide the input data for letting others reproduce the results or perform the performance tests on pcap files already available to the public

[Wireshark-dev] Fwd: tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
(sorry Balint for the double-post, I don't know why my reply button dropped the mailing list) -- Forwarded message -- From: Evan Huus eapa...@gmail.com Date: Fri, Jul 11, 2014 at 9:05 PM Subject: Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2:

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 9:08 PM, Evan Huus eapa...@gmail.com wrote: (sorry Balint for the double-post, I don't know why my reply button dropped the mailing list) -- Forwarded message -- From: Evan Huus eapa...@gmail.com Date: Fri, Jul 11, 2014 at 9:05 PM Subject: Re: