Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Pascal Quantin
2015-02-16 16:48 GMT+01:00 Richard Sharpe realrichardsha...@gmail.com: On Mon, Feb 16, 2015 at 7:11 AM, Evan Huus eapa...@gmail.com wrote: On Mon, Feb 16, 2015 at 10:08 AM, Richard Sharpe realrichardsha...@gmail.com wrote: On Mon, Feb 16, 2015 at 6:55 AM, Evan Huus eapa...@gmail.com wrote:

Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Richard Sharpe
On Mon, Feb 16, 2015 at 7:11 AM, Evan Huus eapa...@gmail.com wrote: On Mon, Feb 16, 2015 at 10:08 AM, Richard Sharpe realrichardsha...@gmail.com wrote: On Mon, Feb 16, 2015 at 6:55 AM, Evan Huus eapa...@gmail.com wrote: Create the wmem_map using g_int64_equal instead of g_direct_equal and

Re: [Wireshark-dev] How do you start a petri-dish review in the review page?

2015-02-16 Thread Alexis La Goutte
On Mon, Feb 16, 2015 at 3:13 AM, Bill Meier wme...@newsguy.com wrote: On 2/15/2015 8:46 PM, Richard Sharpe wrote: Hi folks, How can I start a petri-dish build etc? Can't seem to figure it out. On the review page, you should have sections Code-Review Verified Petri-Dish Click +1 Test

Re: [Wireshark-dev] function of dissector_try_uint()

2015-02-16 Thread Vishnu Bhatt
Thanks for the reply. Can you please tell me what is the function of p_get_proto_data() in Wireshark. Specifically, in case of FP frame, what is the role of this function? p_fp_info = (fp_info *)p_get_proto_data(wmem_file_scope(), pinfo, proto_fp, 0); Thanks Vishnu Bhatt From:

Re: [Wireshark-dev] function of dissector_try_uint()

2015-02-16 Thread Anders Broman
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Vishnu Bhatt Sent: den 16 februari 2015 14:55 To: Developer support list for Wireshark Subject: [Wireshark-dev] function of dissector_try_uint() Hi, I have a dissector code (atmii) and I am

[Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Richard Sharpe
Hi, Guy has identified a problem with my handling of SCSI dissection in the RSVD dissector. I am using a 64-bit value as the key for a wmem_map_insert and this will not work on 32-bit systems. Having looked at the key values some more what it seems that Windows is doing here is taking a 32-bit

[Wireshark-dev] function of dissector_try_uint()

2015-02-16 Thread Vishnu Bhatt
Hi, I have a dissector code (atmii) and I am having problem in understanding the following two lines of code: In proto_register_atmii() aal_dissector_table = register_dissector_table(atmii.aal2_payload, AAL payload type, FT_UINT8, BASE_DEC); and then in dissect_atmii() if

Re: [Wireshark-dev] function of dissector_try_uint()

2015-02-16 Thread Anders Broman
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Anders Broman Sent: den 16 februari 2015 15:05 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] function of dissector_try_uint() From:

Re: [Wireshark-dev] function of dissector_try_uint()

2015-02-16 Thread Pascal Quantin
Hi Vishnu, 2015-02-16 14:55 GMT+01:00 Vishnu Bhatt vishnu.bh...@aricent.com: Hi, I have a dissector code (atmii) and I am having problem in understanding the following two lines of code: In proto_register_atmii() aal_dissector_table = register_dissector_table(atmii.aal2_payload,

Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Evan Huus
Create the wmem_map using g_int64_equal instead of g_direct_equal and wmem_int64_hash instead of g_direct_hash. Create a wmem_file_scope() copy of the key, and pass the resulting pointer to the insert function. Evan On Mon, Feb 16, 2015 at 9:31 AM, Richard Sharpe realrichardsha...@gmail.com

Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Richard Sharpe
On Mon, Feb 16, 2015 at 6:55 AM, Evan Huus eapa...@gmail.com wrote: Create the wmem_map using g_int64_equal instead of g_direct_equal and wmem_int64_hash instead of g_direct_hash. Create a wmem_file_scope() copy of the key, and pass the resulting pointer to the insert function. Hmmm, why do

Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Evan Huus
On Mon, Feb 16, 2015 at 10:08 AM, Richard Sharpe realrichardsha...@gmail.com wrote: On Mon, Feb 16, 2015 at 6:55 AM, Evan Huus eapa...@gmail.com wrote: Create the wmem_map using g_int64_equal instead of g_direct_equal and wmem_int64_hash instead of g_direct_hash. Create a wmem_file_scope()

Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Martin Mathieson
The idiom I use for keys that are 32 bits is to have a function to return a key, with a 'persist' flag e.g. in packet-pdcp-lte.c : /* Convenience function to get a pointer for the hash_func to work with */ static gpointer get_report_hash_key(guint16 SN, guint32 frameNumber,

Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Richard Sharpe
On Mon, Feb 16, 2015 at 7:11 AM, Evan Huus eapa...@gmail.com wrote: On Mon, Feb 16, 2015 at 10:08 AM, Richard Sharpe realrichardsha...@gmail.com wrote: On Mon, Feb 16, 2015 at 6:55 AM, Evan Huus eapa...@gmail.com wrote: Create the wmem_map using g_int64_equal instead of g_direct_equal and

Re: [Wireshark-dev] The RSVD dissector and 32-bit builds ...

2015-02-16 Thread Richard Sharpe
On Mon, Feb 16, 2015 at 7:11 AM, Evan Huus eapa...@gmail.com wrote: On Mon, Feb 16, 2015 at 10:08 AM, Richard Sharpe realrichardsha...@gmail.com wrote: On Mon, Feb 16, 2015 at 6:55 AM, Evan Huus eapa...@gmail.com wrote: Create the wmem_map using g_int64_equal instead of g_direct_equal and