Re: [Wireshark-dev] payload_proto_id in SCPT dissector

2019-08-17 Thread João Valverde
On 17/08/19 11:16, Peter Wu wrote: On Fri, Aug 16, 2019 at 10:09:43AM +0100, João Valverde wrote: Using a hash table is an indirect method of passing data. A void pointer function argument is a direct method of passing data. So why would the former present problems with nested TLS traffic

Re: [Wireshark-dev] payload_proto_id in SCPT dissector

2019-08-17 Thread Peter Wu
On Fri, Aug 16, 2019 at 10:09:43AM +0100, João Valverde wrote: > > > On 15/08/19 23:48, Peter Wu wrote: > > The problem was introduced with v3.1.1rc0-144-gede7be3440 ("TLS: allow > > dissectors to set the appdata protocol via the data param"). Since that > > commit, the "data" parameter of TCP

Re: [Wireshark-dev] Wireshark Windows libraries

2019-08-17 Thread Pascal Quantin
Hi Jaap, Le sam. 17 août 2019 à 10:18, Jaap Keuter a écrit : > > On 16 Aug 2019, at 17:43, Pascal Quantin wrote: > > I'm currently working on a patch that will update the 3 dependencies. > > > Thanks Pascal, both changes look good to me (but I’m not a Windows > developer, so what do I know ;)

Re: [Wireshark-dev] Wireshark Windows libraries

2019-08-17 Thread Jaap Keuter
> On 16 Aug 2019, at 17:43, Pascal Quantin wrote: > > I'm currently working on a patch that will update the 3 dependencies. Thanks Pascal, both changes look good to me (but I’m not a Windows developer, so what do I know ;) ) Thanks, Jaap