[Wireshark-dev] Add generated hf_register_info during proto_register_...

2021-09-27 Thread Michael Lum
Hi, I've got a bunch of statically entered entries for the "normal" way of registering the field array: I.e. using static hf_register_info hf[] = { ...} proto_register_field_array(proto_ublox, hf, array_length(hf)); Now I have chunk of code were I want to do this: #defineNUM_PORT_VALS

Re: [Wireshark-dev] Testing Someone Else's Merge Request

2021-09-27 Thread chuck c
Thanks! https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html#idp2 I broke the WSDG rule "Unless you know exactly what you are doing, you should strictly follow the recommendations below." and modified my git flow. Since gitlab mirrors my fork in the background, there is just a

Re: [Wireshark-dev] Testing Someone Else's Merge Request

2021-09-27 Thread Dr. Matthias St. Pierre
The main GitLab repository (assuming it’s called ‘origin’) automatically maintains references to the head of the pull requests and their merge commits with the target branch: refs/merge-requests//head refs/merge-requests//merge So instead of looking up the owner and the branch name for merge